From 162bd6a8c33142f1e5e9ae4ff9dd12290f1b0451 Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 16 Apr 2019 09:47:08 +0900 Subject: [PATCH 1/2] Fix node drag and drop animation --- .../@node-red/editor-client/src/js/ui/palette.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js index 3c158b4a7..91066d4af 100755 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js @@ -254,7 +254,7 @@ RED.palette = (function() { $(d).draggable({ helper: 'clone', appendTo: 'body', - revert: true, + revert: 'invalid', revertDuration: 50, containment:'#main-container', start: function() { @@ -264,11 +264,7 @@ RED.palette = (function() { }, stop: function() { d3.select('.link_splice').classed('link_splice',false); if (spliceTimer) { clearTimeout(spliceTimer); spliceTimer = null;}}, drag: function(e,ui) { - - // TODO: this is the margin-left of palette node. Hard coding - // it here makes me sad - //console.log(ui.helper.position()); - ui.position.left += 17.5; + ui.originalPosition.left = $('#' + e.target.id).offset().left; if (def.inputs > 0 && def.outputs > 0) { mouseX = ui.position.left-paletteWidth+(ui.helper.width()/2) - chartOffset.left + chart.scrollLeft(); From 44b75f0b921645546c02848328a6eea50bac355d Mon Sep 17 00:00:00 2001 From: Kazuhito Yokoi Date: Tue, 16 Apr 2019 11:01:20 +0900 Subject: [PATCH 2/2] Adjust node animation speed --- .../node_modules/@node-red/editor-client/src/js/ui/palette.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js index 91066d4af..ebfd7413b 100755 --- a/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js +++ b/packages/node_modules/@node-red/editor-client/src/js/ui/palette.js @@ -255,7 +255,7 @@ RED.palette = (function() { helper: 'clone', appendTo: 'body', revert: 'invalid', - revertDuration: 50, + revertDuration: 300, containment:'#main-container', start: function() { paletteWidth = $("#palette").width();