From 56a4530ec65f7004e2ae05ff4ef06fd4017035d0 Mon Sep 17 00:00:00 2001
From: Dave Conway-Jones <dceejay@users.noreply.github.com>
Date: Fri, 6 Dec 2024 22:22:37 +0000
Subject: [PATCH] Fix delay node not dropping when nodeMessageBufferMaxLength
 is set (#4973)

* Fix delay node not dropping when nodeMessageBufferMaxLength is set

to close #4966

* Rmove redundant codes

* Tidy up code removal

---------

Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
---
 .../@node-red/nodes/core/function/89-delay.js | 52 ++++++-------------
 1 file changed, 16 insertions(+), 36 deletions(-)

diff --git a/packages/node_modules/@node-red/nodes/core/function/89-delay.js b/packages/node_modules/@node-red/nodes/core/function/89-delay.js
index 8f9964115..17cbd2f4f 100644
--- a/packages/node_modules/@node-red/nodes/core/function/89-delay.js
+++ b/packages/node_modules/@node-red/nodes/core/function/89-delay.js
@@ -291,43 +291,23 @@ module.exports = function(RED) {
                     }
                 }
                 else if (!msg.hasOwnProperty("reset")) {
-                    if (maxKeptMsgsCount(node) > 0) {
-                        if (node.intervalID === -1) {
-                            node.send(msg);
-                            node.intervalID = setInterval(sendMsgFromBuffer, node.rate);
-                        } else {
-                            if (node.allowrate && msg.hasOwnProperty("rate") && !isNaN(parseFloat(msg.rate)) && node.rate !== msg.rate) {
-                                node.rate = msg.rate;
-                                clearInterval(node.intervalID);
-                                node.intervalID = setInterval(sendMsgFromBuffer, node.rate);
-                            }
-                            if (node.buffer.length < _maxKeptMsgsCount) {
-                                var m = RED.util.cloneMessage(msg);
-                                node.buffer.push({msg: m, send: send, done: done});
-                            } else {
-                                node.trace("dropped due to buffer overflow. msg._msgid = " + msg._msgid);
-                                node.droppedMsgs++;
-                            }
-                        }
+                    if (node.allowrate && msg.hasOwnProperty("rate") && !isNaN(parseFloat(msg.rate))) {
+                        node.rate = msg.rate;
                     }
-                    else {
-                        if (node.allowrate && msg.hasOwnProperty("rate") && !isNaN(parseFloat(msg.rate))) {
-                            node.rate = msg.rate;
-                        }
-                        var timeSinceLast;
-                        if (node.lastSent) {
-                            timeSinceLast = process.hrtime(node.lastSent);
-                        }
-                        if (!node.lastSent) { // ensuring that we always send the first message
-                            node.lastSent = process.hrtime();
-                            send(msg);
-                        }
-                        else if ( ( (timeSinceLast[0] * SECONDS_TO_NANOS) + timeSinceLast[1] ) > (node.rate * MILLIS_TO_NANOS) ) {
-                            node.lastSent = process.hrtime();
-                            send(msg);
-                        } else if (node.outputs === 2) {
-                            send([null,msg])
-                        }
+                    var timeSinceLast;
+                    if (node.lastSent) {
+                        timeSinceLast = process.hrtime(node.lastSent);
+                    }
+                    if (!node.lastSent) { // ensuring that we always send the first message
+                        node.lastSent = process.hrtime();
+                        send(msg);
+                    }
+                    else if ( ( (timeSinceLast[0] * SECONDS_TO_NANOS) + timeSinceLast[1] ) > (node.rate * MILLIS_TO_NANOS) ) {
+                        node.lastSent = process.hrtime();
+                        send(msg);
+                    }
+                    else if (node.outputs === 2) {
+                        send([null,msg])
                     }
                     done();
                 }