From 261495fc2de13cbe8478df293a83ee804d7af3c3 Mon Sep 17 00:00:00 2001 From: Ben Hardill Date: Sun, 13 Apr 2025 08:43:50 +0100 Subject: [PATCH 1/4] Fix the capitisation for ALPN settings in http-request part of node-red/node-red#5104 --- .../@node-red/nodes/core/network/21-httprequest.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js index 90c4134a4..adf2b5dd9 100644 --- a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js +++ b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js @@ -586,6 +586,10 @@ in your Node-RED user directory (${RED.settings.userDir}). opts.https.certificate = opts.https.cert; delete opts.https.cert; } + if (opts.https.ALPNProtocols) { + opts.https.alpnProtocols = opts.https.ALPNProtocols + delete opts.https.ALPNProtocols + } } else { if (msg.hasOwnProperty('rejectUnauthorized')) { opts.https = { rejectUnauthorized: msg.rejectUnauthorized }; From f3b47c5659f3a5eab5b482bc22f3fa63dfa46329 Mon Sep 17 00:00:00 2001 From: Ben Hardill Date: Mon, 14 Apr 2025 13:27:02 +0100 Subject: [PATCH 2/4] Update packages/node_modules/@node-red/nodes/core/network/21-httprequest.js Co-authored-by: Nick O'Leary --- .../node_modules/@node-red/nodes/core/network/21-httprequest.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js index adf2b5dd9..1c1b83ce6 100644 --- a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js +++ b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js @@ -586,6 +586,8 @@ in your Node-RED user directory (${RED.settings.userDir}). opts.https.certificate = opts.https.cert; delete opts.https.cert; } + // The got library uses a different case for some https properties compared to the + // standard node tls options object. if (opts.https.ALPNProtocols) { opts.https.alpnProtocols = opts.https.ALPNProtocols delete opts.https.ALPNProtocols From 0b271f11852b40f2e64d86d7353ea9807d18c610 Mon Sep 17 00:00:00 2001 From: Ben Hardill Date: Thu, 17 Apr 2025 15:32:31 +0100 Subject: [PATCH 3/4] Remove http.servername as got doesn't support --- .../@node-red/nodes/core/network/21-httprequest.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js index 1c1b83ce6..cb1ba0b6f 100644 --- a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js +++ b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js @@ -592,6 +592,10 @@ in your Node-RED user directory (${RED.settings.userDir}). opts.https.alpnProtocols = opts.https.ALPNProtocols delete opts.https.ALPNProtocols } + // The got library doesn't support servername at this time + if (opts.https.servername) { + delete opts.https.servername + } } else { if (msg.hasOwnProperty('rejectUnauthorized')) { opts.https = { rejectUnauthorized: msg.rejectUnauthorized }; From f961a7276be4e3627f3ea00525461f7739376cb5 Mon Sep 17 00:00:00 2001 From: Ben Hardill Date: Thu, 17 Apr 2025 15:39:19 +0100 Subject: [PATCH 4/4] Better comment --- .../node_modules/@node-red/nodes/core/network/21-httprequest.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js index cb1ba0b6f..194d06175 100644 --- a/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js +++ b/packages/node_modules/@node-red/nodes/core/network/21-httprequest.js @@ -593,6 +593,7 @@ in your Node-RED user directory (${RED.settings.userDir}). delete opts.https.ALPNProtocols } // The got library doesn't support servername at this time + // https://github.com/sindresorhus/got/issues/2320 if (opts.https.servername) { delete opts.https.servername }