Node-Red
/
node-red
mirror of https://github.com/node-red/node-red.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

pull/5448/head
Nick O'Leary 2026-03-10 15:02:10 +00:00 committed by GitHub
parent 667479f7d0
commit 1edac26805
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 40 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/node_modules/@node-red/editor-client/src/js/ui/common/menu.js vendored
View File

@ -275,8 +275,30 @@ RED.menu = (function() {
var {x, y} = getSubmenuPosition(item[0], submenu[0], direction);
submenu.css({
'top': y + 'px',
'left': x + 'px'
'left': x + 'px',
maxHeight: ""
});
const windowHeight = $(window).height();
const menuHeight = submenu.outerHeight();
const spaceAbove = y;
const bottomOverlap = menuHeight - (windowHeight - y);
if (bottomOverlap > 0) {
if (spaceAbove > bottomOverlap + 5) {
// There is room to move the menu up and still show it all
submenu.css({
top: (menuHeight - bottomOverlap - 5) + "px"
})
} else {
// There is not room for the whole menu.
// 1. move it to the top
// 2. enable overflow/scrolling
submenu.css({
top: "5px",
maxHeight: (windowHeight - 25) + "px",
overflowY: "auto"
});
}
}
}
function cleanUpSubmenu() {

39
packages/node_modules/@node-red/editor-client/src/js/ui/contextMenu.js vendored
View File

@ -275,10 +275,10 @@ RED.contextMenu = (function () {
});
menu.show();
var menuHeight = menu.outerHeight();
var menuWidth = menu.outerWidth();
var spaceBelow = windowHeight - top;
var spaceAbove = top;
const menuHeight = menu.outerHeight();
const menuWidth = menu.outerWidth();
const spaceAbove = top;
const bottomOverlap = menuHeight - (windowHeight - top);
// Adjust horizontal position if menu would overflow right edge
if (left + menuWidth > windowWidth - 10) {
@ -287,26 +287,21 @@ RED.contextMenu = (function () {
}
// Check if menu overflows below viewport
if (menuHeight > spaceBelow - 10) {
// Try repositioning above the click point first
if (spaceAbove > spaceBelow && menuHeight <= spaceAbove - 10) {
if (bottomOverlap > 0) {
if (spaceAbove > bottomOverlap + 5) {
// There is room to move the menu up and still show it all
menu.css({
top: (top - menuHeight) + "px"
});
top: (top - bottomOverlap - 5) + "px"
})
} else {
// Enable scrolling with max available space above or below
if (spaceAbove > spaceBelow) {
menu.css({
top: "10px",
maxHeight: (top - 20) + "px",
overflowY: "auto"
});
} else {
menu.css({
maxHeight: (spaceBelow - 10) + "px",
overflowY: "auto"
});
}
// There is not room for the whole menu.
// 1. move it to the top
// 2. enable overflow/scrolling
menu.css({
top: "5px",
maxHeight: (windowHeight - 25) + "px",
overflowY: "auto"
});
}
}
// set focus to first item so that pressing escape key closes the menu