From eb7b75e9ba9663aea65ae3343a53a6cf505e421a Mon Sep 17 00:00:00 2001
From: Chris Veilleux <veilleux.chris@gmail.com>
Date: Fri, 17 Aug 2018 13:49:08 -0500
Subject: [PATCH] added navigation to the github repository for the skill

---
 .../skill-detail/skill-detail.component.html   | 10 +++++++---
 .../skill-detail/skill-detail.component.scss   | 18 ++++++++----------
 .../skill-detail/skill-detail.component.ts     |  3 +++
 3 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.html b/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.html
index 14488629..f66b8f3e 100644
--- a/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.html
+++ b/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.html
@@ -12,10 +12,14 @@
             </div>
             <div class="skill-detail-header-right">
                 <button mat-button>INSTALL</button>
-                <div class="mat-body-1">
+                <button
+                    mat-flat-button
+                    class="github-button"
+                    (click)="navigateToGithubRepo(skill.repository_url)"
+                >
                     <fa-icon [icon]="githubIcon"></fa-icon>
                     GitHub Repository
-                </div>
+                </button>
             </div>
         </div>
 
@@ -34,7 +38,7 @@
                     <div class="mat-body-1">{{skill.description}}</div>
                 </div>
                 <div class="skill-detail-section">
-                    <div class="mat-subheading-1">AUTHOR</div>
+                    <div class="mat-subheading-1">AUTHOR(S)</div>
                     <div class="mat-body-1">{{skill.author}}</div>
                 </div>
             </div>
diff --git a/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.scss b/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.scss
index 3f4ab47e..d3115c67 100644
--- a/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.scss
+++ b/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.scss
@@ -1,7 +1,6 @@
 @import '../../../stylesheets/global';
 
 .skill-detail {
-    height: 800px;
     max-width: 1000px;
     .skill-detail-header {
         background-color: $mycroft-blue-grey;
@@ -11,7 +10,7 @@
         padding: 30px;
         .skill-detail-header-left {
             color: $mycroft-secondary;
-            width: 75%;
+            width: 70%;
             h1 {
                 font-family: 'Roboto Mono', monospace;
                 margin-bottom: 15px;
@@ -23,17 +22,17 @@
             }
         }
         .skill-detail-header-right {
-            width: 25%;
+            width: 30%;
             button {
                 @include action-button;
                 margin-top: 5px;
-                width: 135px;
+                width: 160px;
             }
-            .mat-body-1 {
+            .github-button {
+                background-color: $mycroft-blue-grey;
                 color: $mycroft-dark-grey;
-                padding-top: 10px;
                 fa-icon {
-                    margin-right: 5px;
+                    padding-right: 5px;
                 }
             }
         }
@@ -42,13 +41,12 @@
         background-color: $mycroft-white;
         border-bottom-left-radius: 10px;
         border-bottom-right-radius: 10px;
-        height: 600px;
         padding: 30px;
         .mat-subheading-1 {
             color: $mycroft-dark-grey
         }
         .skill-detail-body-left {
-            width: 75%;
+            width: 70%;
             button {
                 @include skill-trigger-button;
                 @include ellipsis-overflow;
@@ -56,7 +54,7 @@
             }
         }
         .skill-detail-body-right {
-            width: 25%;
+            width: 30%;
             img {
                 padding-right: 15px;
             }
diff --git a/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.ts b/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.ts
index 8c6b8741..20fd267e 100644
--- a/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.ts
+++ b/market/frontend/v1/market-ui/src/app/skills/skill-detail/skill-detail.component.ts
@@ -31,6 +31,9 @@ export class SkillDetailComponent implements OnInit {
         );
     }
 
+    navigateToGithubRepo(githubRepoUrl) {
+        window.open(githubRepoUrl);
+    }
     // returnToSummary() {
     //     this.router.navigate(['/skills']);
     // }