Moving conversion from the repository to the endpoint class

pull/162/head
Matheus Lima 2019-05-29 13:43:02 -03:00
parent 4615684de5
commit c41e46213a
2 changed files with 8 additions and 3 deletions

View File

@ -38,6 +38,7 @@ class SkillSettingsEndpoint(SeleneEndpoint):
def get(self, skill_id): def get(self, skill_id):
self._authenticate() self._authenticate()
skill_settings = self._get_skill_settings(skill_id) skill_settings = self._get_skill_settings(skill_id)
# The response object is manually built here to bypass the camel case conversion
return Response(response=json.dumps(skill_settings), status=HTTPStatus.OK, content_type='application_json') return Response(response=json.dumps(skill_settings), status=HTTPStatus.OK, content_type='application_json')
@property @property
@ -52,8 +53,11 @@ class SkillSettingsEndpoint(SeleneEndpoint):
def _get_skill_settings(self, skill_id: str): def _get_skill_settings(self, skill_id: str):
skill_settings = self.setting_repository.get_skill_settings(skill_id) skill_settings = self.setting_repository.get_skill_settings(skill_id)
skill_settings = list(map(lambda setting: {
'settingsDisplay': setting['settings_display'],
'settingsValues': setting['settings_values'],
'devices': setting['devices']}, skill_settings))
_parse_selection_options(skill_settings) _parse_selection_options(skill_settings)
return skill_settings return skill_settings
def put(self, skill_id): def put(self, skill_id):

View File

@ -25,8 +25,9 @@ class SkillSettingRepository(RepositoryBase):
settings_display = row['settings_display']['skillMetadata'] settings_display = row['settings_display']['skillMetadata']
skill_settings.append( skill_settings.append(
dict( dict(
settingsDisplay=settings_display, skill_id=skill_id,
settingsValues=row['settings_values'], settings_display=settings_display,
settings_values=row['settings_values'],
devices=row['devices'] devices=row['devices']
) )
) )