mycroft-core/mycroft/skills
Åke ab242a2c82
Handle multiple intents with the same name (#2921)
* Add check for duplicate adapt intents

There are two cases, duplicated named intent and duplicated anonymous intent.

A named intent will cause a ValueError exception notifying the skill
author that there is a collision.

An anonymous intent will silently derive a new name and use that
instead of the default generated one.

* Add tests for intent collisions

* Make enable/disable intent handle the new exception

The enable/disable intent did not mark an intent as detached, instead it
remained in the list of intents after disabling in the IntentServiceInterface
to be retrieved when the intent should be re-enabled.

This moves detached intents into a list of detached intents to so they
won't cause the double enable exception.

* Add move logic to find if intent is detached

MycroftSkill.enable_intent() will now check if the intent is detached
before trying to re-enable it.

* Lock updates of intents

This should avoid some race conditions that may occur if multiple
threads tries to enable / disable intents
2022-11-23 15:52:56 +09:30
..
intent_services Merge pull request #3003 from Joanguitar/dev 2021-10-21 12:25:34 +09:30
mycroft_skill Handle multiple intents with the same name (#2921) 2022-11-23 15:52:56 +09:30
__init__.py Provide AdaptIntent from mycroft.skills 2021-08-09 15:55:04 +09:30
__main__.py docstring cleanup 2021-05-11 15:10:32 +09:30
api.py docstring cleanup 2021-05-11 15:10:32 +09:30
audioservice.py docstring cleanup 2021-05-11 15:10:32 +09:30
common_iot_skill.py Fix sphinxdoc warning in common_iot_skill.py 2021-05-11 15:10:32 +09:30
common_play_skill.py Merge pull request #2900 from MycroftAI/bugfix/common-play-active 2021-06-29 20:59:33 +09:30
common_query_skill.py Remove unused imports from common_query_skill.py 2022-02-24 10:22:09 +09:30
context.py docstring cleanup 2021-05-11 15:10:32 +09:30
core.py Refactor skill manager (#2237) 2019-08-20 12:02:39 +02:00
event_scheduler.py Slight cleanup 2021-08-05 10:04:45 +02:00
fallback_skill.py docstring cleanup 2021-05-11 15:10:32 +09:30
intent_service.py Merge pull request #3003 from Joanguitar/dev 2021-10-21 12:25:34 +09:30
intent_service_interface.py Handle multiple intents with the same name (#2921) 2022-11-23 15:52:56 +09:30
msm_wrapper.py Rename to get_temp_path and add docstring 2021-04-30 16:49:59 +09:30
settings.py docstring cleanup 2021-05-11 15:10:32 +09:30
skill_data.py docstring cleanup 2021-05-11 15:10:32 +09:30
skill_loader.py Fixed formatting error in skill loader log message 2021-10-15 14:51:05 -05:00
skill_manager.py docstring cleanup 2021-05-11 15:10:32 +09:30
skill_updater.py Slight cleanup 2021-08-05 10:04:45 +02:00