* Shellcheck and update mycroft-config
* Shellcheck and update mycroft-pip
* Shellcheck and update mycroft-cli-client
* Shellcheck and update mycroft-help
* Shellcheck and update mycroft-listen
* Shellcheck and update mycroft-mic-test
* Shellcheck and update mycroft-msk
* Shellcheck and update mycroft-msm
* Shellcheck and update mycroft-say-to
* Shellcheck and update mycroft-skill-testrunner
* Shellcheck and update mycroft-speak
* Shellcheck and update mycroft-start
* Shellcheck and update mycroft-stop
* Add shellcheck step to github actions
This runs most of the shellcheck tests. The excludes are:
- SC1091: Avoids errors when shellcheck can't find sourced file
- SC2034: Unused variables, for example colors that aren't used yet
- SC2012: use of ls, from what I can see in our case this is fine (wc -l)
The version is locked to latest master as of November 2 2021
* [log_format] Add an option to change the log format
Hacing an option to change the log format could be useful when logs
are shipped into an aggregator such as Elasticsearch.
The current format is very hard to parse.
* [log_format] Set default Formatter
Because mycroft.configuration.Configuration() class import LOG class,
a default Formatter have to be defined before import the
mycroft.configuration.Configuration() class.
* Upgrade websocket-client to 1.2.1
core equivalent of https://github.com/MycroftAI/mycroft-messagebus-client/pull/21
There was an incompability with the latest websocket-client and the
messagebus which needed fixing for Linux distro compatibility. Since
messagebus-client was going to depend on websocket-client 1.2.1, let's
do the same in core
* Bump message bus client and tornado versions
New version of the messagebus-client released.
Upgraded Tornado to match new function signature.
* Revert removal of websocket-client
It is still used in the `mycroft.client.text.gui_server`
Should investigate removal of this so that websocket client versions do not need to be
kept in sync between mycroft-core and mycroft-messagebus-client.
Co-authored-by: Kris Gesling <kris.gesling@mycroft.ai>
This changes the internally used names for entities and entity values when
sent on the messagebus and used interanally in the intent service from start / end to entity_value and entity_type.
This makes the terminology easier to understand and follow across into Adapt.
The old terms are still included and usable for compatibility but should be
removed in an upcoming major release (22.02).
Setuptools deprecated use of `use_2to3` from v58
See changelog:
https://setuptools.readthedocs.io/en/latest/history.html#v58-0-0
This has been reported upstream to both packages. The simplest fix
seems to be removing Python2 support. It's more difficult to pin
setuptools as this is installed via system packages in dev_setup.sh