Issue-2567 - Fixing not initialized dialog_render (#2685)

Fixes #2567

mycroft/skills/mycroft_skill/mycroft_skill.py

@@ -1134,9 +1134,17 @@ class MycroftSkill:
             wait (bool):            set to True to block while the text
                                     is being spoken.
         """
-        data = data or {}
+        if self.dialog_renderer:
-        self.speak(self.dialog_renderer.render(key, data),
+            data = data or {}
-                   expect_response, wait, meta={'dialog': key, 'data': data})
+            self.speak(
+                self.dialog_renderer.render(key, data),
+                expect_response, wait, meta={'dialog': key, 'data': data}
+            )
+        else:
+            self.log.warning(
+                'dialog_render is None, does the locale/dialog folder exist?'
+            )
+            self.speak(key, expect_response, wait, {})
 
     def acknowledge(self):
         """Acknowledge a successful request.

test/unittests/skills/test_mycroft_skill.py

@@ -602,6 +602,13 @@ class TestMycroftSkill(unittest.TestCase):
         # Restore lang to en-us
         s.config_core['lang'] = 'en-us'
 
+    def test_speak_dialog_render_not_initialized(self):
+        """Test that non-initialized dialog_renderer won't raise an error."""
+        s = SimpleSkill1()
+        s.bind(self.emitter)
+        s.dialog_renderer = None
+        s.speak_dialog(key='key')
+
 
 class _TestSkill(MycroftSkill):
     def __init__(self):