MycroftAI
/
mycroft-core
mirror of https://github.com/MycroftAI/mycroft-core.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add safety around skillMetadata 

skillMetadata could be accessed in settings without it when checking if remote update was needed.
pull/2104/head
Åke Forslund 2019-04-24 14:27:09 +02:00
parent 6eb2aefbaa
commit 4518a11528
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mycroft/skills/settings.py
View File

@ -311,7 +311,8 @@ class SkillSettings(dict):
Args:
skill_settings (dict): skill
"""
self._save_uuid(skill_settings['uuid'])
if 'uuid' in skill_settings:
self._save_uuid(skill_settings['uuid'])
if 'skillMetadata' in skill_settings:
sections = skill_settings['skillMetadata']['sections']
for section in sections:
@ -624,7 +625,8 @@ class SkillSettings(dict):
@property
def _should_upload_from_change(self):
changed = False
if hasattr(self, '_remote_settings'):
if (hasattr(self, '_remote_settings') and
'skillMetadata' in self._remote_settings):
sections = self._remote_settings['skillMetadata']['sections']
for i, section in enumerate(sections):
for j, field in enumerate(section['fields']):