From 8a295dbfb3f093fcdb5885d1e65acf4a8d31baa3 Mon Sep 17 00:00:00 2001 From: Henry Heino Date: Sun, 10 Nov 2024 20:32:35 -0800 Subject: [PATCH] Move pages deployment to a separate job (as suggested by the actions documentation) --- .github/workflows/main.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 573e49de3bb..1adc3d9f019 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -3,10 +3,6 @@ on: schedule: - cron: "0 */6 * * *" workflow_dispatch: -# Permissions required for deployment to GitHub pages -permissions: - pages: write - id-token: write jobs: # We run the plugin website CI in a separate job that doesn't have # SSH key access for extra security because it handles untrusted markdown. @@ -99,6 +95,15 @@ jobs: uses: actions/upload-pages-artifact@v3 with: path: 'joplin-website/docs/' + Deploy: + runs-on: ubuntu-latest + needs: Main + permissions: + # Permissions needed for pages deployment. See + # https://github.com/actions/deploy-pages + pages: write + id-token: write + steps: - name: Deploy to GitHub Pages id: deployment uses: actions/deploy-pages@v4