Follow up to #893
Now using middleware to set the tags when a note is selected
This avoids the ugly code in the NoteTextComponent where we determine
if tags are to be fetched, identify if they have been modified, fetch
them and then dispatch an action to update the store which might
again re-render the component.
Also implements style related fixes from #1000
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
Fixes: #469
* Add external editor actions to the note context menu.
Also start up external editor on note double click.
These changes enhance user experience by placing the actions where
they feel natural.
* Remove double-click behaviour and change menu text.
Changes in response to review comments.
* Move handling of external editor actions to main screen from note text
This is to ensure correct behaviour even when the user launches the
action on a note in the list that is under the pointer, but not selected.
* Move external edit actions to NoteListUtils from MainScreen.
* Reconnect external edit action in main edit menu.
* Started updating to use external renderer package
* Added way to build renderer assets
* Done mobile compatilibty
* Upgrade joplin-renderer
* Added joplin-renderer package
* Moved button row to separate component file and started Sharing dialog
* Adding Sharing dialog
* Applied "npx react-codemod rename-unsafe-lifecycles"
* More UI
* Tools: Improved TypeScript integration
* Improved share dialog
* Tools Added support for translation validation in CI, and added support for plural translations
* Improved UI and sharing workflow
* Share workflow
* Cleaned up and improved sharing config error handling
* Fixed build scripts and doc for TypeScript
* Run linter
* Delete unused file
* Implement CssUtils
* Inject custom CSS styles
* Add info about custom CSS styles to README
* Add note that ElectronClient/app/app.js is generated
* Add support for Setting.TYPE_BUTTON
* Add buttons in Preferences to open custom CSS files
* Swap custom CSS filenames
* Swap custom CSS filenames
* Wrap "Edit" with translation fn
* Incorporate PR feedback from @laurent22
* Add openOrCreateFile to Settings
* Move openOrCreateFile to shim
* Removing header for now - see https://github.com/laurent22/joplin/pull/2099#discussion_r353120915
* Added highlight_mark token to Ace editor rules
* Fix edge case for highlight_mark Ace rule
* Add ==mark== rule only if plugin is enabled
* Rm temporary highlight class
* Require --open-dev-tools along with --env dev in command line options to make opening of Dev Tools optional when in Developer mode.
* Restore original lines then comment out the call to openDevTools
* Adding node counts for folders and tags
* Add unit tests
* Fix count update when the tag list for a note is updated
* Right align note counts and remove from the settings screen
* Folder note count calculation update to include descendants
* Update Setting.js
* Change count style and fix click on counts
* Fix tag/folder count update on delete/add note
* Review updates
* Add keyboard modes to editor (vim, emacs, default)
This adds a new option to settings, and then sets the
appropriate keyboard handler in the ace editor.
The "default" option is equivalent to the old keyboard
behaviour.
* Remove stray console.log
* Move the keyboard-mode setting to the general section
* Change `keyboardMode` setting to `editor.keyboardMode`
* Prevent horizontal scrolling on Linux when a scrollbar is present in the note list.
* max-width usage specifically to target Linux horizontal scroll problem.
* Add forkawesome icons
* Add resource icon for specific filetypes
* Ignore resource link styling on mobile
* whtiespace
* render txt icons and adjust icon sizes
* Replace fork-awesome font with inline svg so icons work on mobile
* Add comment describing the source of resource icons
* Added options for selecting layout
* Toggle through the layouts based on config
* Used redux state for getting layout settings
* Removed duplicated strings for layout options
* Moved option for selecting layouts to "View" menu
* Add menu item to toggle note list #1988
* Hiding the noteList now fully works + standardized casing for noteList #1988
* hiding verticalResizer to fully hide note list and its extra border #1988
* curly braces on the same line #1988
* fa-tasks is "less" worse as an icon for toggle note list #1988
* liking this icon a whole lot more
* removed useless width tweak
* Misc. typo and whitespace fixes
Found via `codespell -q 3 -S *.po,*.pot,./ElectronClient/app/locales,./ReactNativeClient/locales,./CliClient/locales -L adresse,ba,fonction,te,whet`
* Revert a previous change
* add setting: export.pdfPageSize
* create 2 settings: size and orientation
* export.pdfPageOrientation: use string instead of boolean
* add other page formats supported by Electron
The changelong text is truncated if it's longer than 1000 characters,
but avoids cutting off a partial line, unless that would lead to cutting
off too much of the text. An ellipsis is added to mark the truncation.
Additionally, when the changelong is truncated, it adds a "Full Release Notes"
button that opens the GitHub release page in a browser window.
* add checkmark to menu item, if Dev Tools are on
If one closed the dev tools window, one could think that the Dev Tools are closed.
This is not the case. After the next action, the window opens again. This can be
confusing, therefore I added a checkmark to the menu item so that it is very clear.
* fix no-case-declarations
* fix reducer issue
* set cancel as the default in dangerous operations, rename buttons (delete, remove) and context menu (for tags)
fixes#1662 (partially, because I can't fix the upstream issue, unless we update Electron)
* add default value for buttonLabel
* Revert "Revert "Desktop: Add ENEX to HTML export (#1795)""
This reverts commit 50b66cceca.
* Revert "Revert "Desktop, Cli: Fixed interop service so that it still allow auto-detecting importer based on format (required for Cli and for test units)""
This reverts commit c7c57ab2a5.
* Fix the .md importer
* Add comment re future refactor
* Rm importerClass for .md importer
* Fix EnexToMd module name
* Add `escape` to go back from Dropbox Login screen
* Add .vscode/ to .gitignore
* Remove call to enexXmlToMd
* The 2 enex importers have distinct functionality!
* Add tmp #deleteAllNotebooks
* checkbox state still not persisting
* images now fixed, but checkboxes still broken
* Figured out that #ipcProxySendToHost is important for handling checkbox
* cleanup closing br and en-todo tags + add notes
* Handle en-media, add NOTEs & TODOs, & format html
* Clean up some of the logging
* cleanHtml is a nice beautifier, but callback hell ensues...
* Rm #htmlFormat
* Recreating the xml actually seems to work
* Add test (not functional rn)
* Add test for checkboxes
* Add test for image en-media
* Separate tests into 2 function calls
* Clean up test
* Add `en-media-audio` test
* Add bad resource test
* Misc cleanup
* Rm SlateEditor files
* Misc cleanup
* Remove #deleteAllNotebooks button
* Add names to tests
* Extract resourceUtils
* Rm DropboxLoginScreen esc behavior, part of another PR
* Misc cleanup
* Improve audioElement, add attachment import support
* Misc cleanup
* Add svg test for enex_to_html
* Clean up test
* Set markup_language to MARKUP_LANGUAGE_HTML to tell renderer that the content is only HTML
* Rename to newModuleByFormat_ for clarity
* Add comment to clarify newModuleFromPath_
* Update eslint config
* Applied linter to lib
* Applied eslint config to CliClient/app
* Removed prettier due to https://github.com/prettier/prettier/pull/4765
* First pass on test units
* Applied linter config to test units
* Applied eslint config to clipper
* Applied to plugin dir
* Applied to root of ElectronClient
* Applied on RN root
* Applied on CLI root
* Applied on Clipper root
* Applied config to tools
* test hook
* test hook
* test hook
* Added pre-commit hook
* Applied rule no-trailing-spaces
* Make sure root packages are installed when installing sub-dir
* Added doc
* enable drag and drop fileURLs
* fix windows fileURL syntax
* introduce encodeURI function
* fixed encoding issue
* use path-utils.js to deal with fileURL path conversion
* add changes as requested
* Minor rewording 'On the' -> 'In the', additional info about attaching files
* change call of toFileProtocolPath
* enable test script to check syntax for all OS-platforms
Laurent Cozic
Caleb John
Abijeet Patro
mic704b
Laurent Cozic
Rafael Cavalcanti
Helmut K. C. Tessarek
Devon Zuegel
barbowza
Diego Erdody
Shane Kilkelly
boring10
Subodh Dahal
aerotog
Daniel Landau
Stephanie Foskitt
Tommy Bergeron
luzpaz
Matthew Crumley
Devon Zuegel
Nathan Leiby
Dom Goodwin
tfinnberg