Joplin
/
joplin
mirror of https://github.com/laurent22/joplin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tools: Throw an error if IPHONEOS_DEPLOYMENT_TARGET versions do not match in pbxproj file

pull/5876/head
Laurent Cozic 2021-12-16 17:04:52 +01:00
parent 10c6af8aa7
commit 586542e15e
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/tools/release-ios.ts
View File

@ -1,5 +1,6 @@
import * as fs from 'fs-extra';
import { execCommand2, rootDir, gitPullTry } from './tool-utils';
const { unique } = require('@joplin/lib/ArrayUtils');
const mobileDir = `${rootDir}/packages/app-mobile`;
@ -37,12 +38,35 @@ async function updateCodeProjVersions(filePath: string) {
return { newVersion, newVersionId };
}
// Check that deployment targets of all projects match
// IPHONEOS_DEPLOYMENT_TARGET
// If they don't we get this kind of error:
// https://github.com/laurent22/joplin/issues/4945#issuecomment-995802706
async function checkDeploymentTargets(filePath: string) {
const content = await fs.readFile(filePath, 'utf8');
const re = /IPHONEOS_DEPLOYMENT_TARGET = ([0-9.]+)/g;
let match = re.exec(content);
let versions: string[] = [];
while (match) {
versions.push(match[1]);
match = re.exec(content);
}
versions = unique(versions);
if (versions.length > 1) throw new Error(`Detected mismatched IPHONEOS_DEPLOYMENT_TARGET: ${versions.join(', ')}. Set them all to the same target. In ${filePath}`);
if (!versions.length) throw new Error(`Could not find IPHONEOS_DEPLOYMENT_TARGET in ${filePath}`);
}
async function main() {
await gitPullTry();
const pbxprojFilePath = `${mobileDir}/ios/Joplin.xcodeproj/project.pbxproj`;
await checkDeploymentTargets(pbxprojFilePath);
console.info('Updating version numbers...');
const { newVersion, newVersionId } = await updateCodeProjVersions(`${mobileDir}/ios/Joplin.xcodeproj/project.pbxproj`);
const { newVersion, newVersionId } = await updateCodeProjVersions(pbxprojFilePath);
console.info(`New version: ${newVersion} (${newVersionId})`);
const tagName = `ios-v${newVersion}`;