From 30201249b539ae75026f7048e6c6e774c57ff015 Mon Sep 17 00:00:00 2001 From: Laurent Cozic Date: Mon, 31 Dec 2018 17:33:20 +0100 Subject: [PATCH] Mobile: Fixes #1068: Handle case where notebook has a parent that no longer exists --- ReactNativeClient/lib/models/Folder.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ReactNativeClient/lib/models/Folder.js b/ReactNativeClient/lib/models/Folder.js index 2d055eac40..ad9f5f638d 100644 --- a/ReactNativeClient/lib/models/Folder.js +++ b/ReactNativeClient/lib/models/Folder.js @@ -167,7 +167,13 @@ class Folder extends BaseItem { if (!folder.parent_id) { rootFolders.push(folder); } else { - idToFolders[folder.parent_id].children.push(folder); + if (!idToFolders[folder.parent_id]) { + // It means the notebook is refering a folder that doesn't exist. In theory it shouldn't happen + // but sometimes does - https://github.com/laurent22/joplin/issues/1068#issuecomment-450594708 + rootFolders.push(folder); + } else { + idToFolders[folder.parent_id].children.push(folder); + } } }