Joplin
/
joplin
mirror of https://github.com/laurent22/joplin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Desktop: Fixes very slow startup since Electron 4 upgrade

pull/1290/head
Laurent Cozic 2019-02-28 23:24:28 +00:00
parent 677aa7d59b
commit 2256b0c5ec
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ReactNativeClient/lib/services/ExternalEditWatcher.js
View File

@ -2,7 +2,6 @@ const { Logger } = require('lib/logger.js');
const Note = require('lib/models/Note'); const Note = require('lib/models/Note');
const Setting = require('lib/models/Setting'); const Setting = require('lib/models/Setting');
const { shim } = require('lib/shim'); const { shim } = require('lib/shim');
const chokidar = require('chokidar');
const EventEmitter = require('events'); const EventEmitter = require('events');
const { splitCommandString } = require('lib/string-utils'); const { splitCommandString } = require('lib/string-utils');
const { fileExtension } = require('lib/path-utils'); const { fileExtension } = require('lib/path-utils');
@ -40,9 +39,20 @@ class ExternalEditWatcher {
return this.logger_; return this.logger_;
} }
async preload() {
// Chokidar is extremely slow to load since Electron 4 - it takes over 4 seconds
// on my computer. So load it in the background.
setTimeout(() => {
if (this.chokidar_) return;
this.chokidar_ = require('chokidar');
}, 1000);
}
watch(fileToWatch) { watch(fileToWatch) {
if (!this.chokidar_) return;
if (!this.watcher_) { if (!this.watcher_) {
this.watcher_ = chokidar.watch(fileToWatch); this.watcher_ = this.chokidar_.watch(fileToWatch);
this.watcher_.on('all', async (event, path) => { this.watcher_.on('all', async (event, path) => {
this.logger().debug('ExternalEditWatcher: Event: ' + event + ': ' + path); this.logger().debug('ExternalEditWatcher: Event: ' + event + ': ' + path);