diff --git a/packages/app-cli/tests/support/onenote/note_with_audio_embedded.zip b/packages/app-cli/tests/support/onenote/note_with_audio_embedded.zip new file mode 100644 index 0000000000..617d09606a Binary files /dev/null and b/packages/app-cli/tests/support/onenote/note_with_audio_embedded.zip differ diff --git a/packages/lib/services/interop/InteropService_Importer_OneNote.test.ts b/packages/lib/services/interop/InteropService_Importer_OneNote.test.ts index 293b68ab31..766c1c168e 100644 --- a/packages/lib/services/interop/InteropService_Importer_OneNote.test.ts +++ b/packages/lib/services/interop/InteropService_Importer_OneNote.test.ts @@ -220,4 +220,17 @@ describe('InteropService_Importer_OneNote', () => { } BaseModel.setIdGenerator(originalIdGenerator); }); + + skipIfNotCI('should render audio as links to resource', async () => { + let idx = 0; + const originalIdGenerator = BaseModel.setIdGenerator(() => String(idx++)); + const notes = await importNote(`${supportDir}/onenote/note_with_audio_embedded.zip`); + + expect(notes.length).toBe(2); + + for (const note of notes) { + expect(note.body).toMatchSnapshot(note.title); + } + BaseModel.setIdGenerator(originalIdGenerator); + }); }); diff --git a/packages/lib/services/interop/__snapshots__/InteropService_Importer_OneNote.test.js.snap b/packages/lib/services/interop/__snapshots__/InteropService_Importer_OneNote.test.js.snap index ffa60e8849..f4f457dd63 100644 --- a/packages/lib/services/interop/__snapshots__/InteropService_Importer_OneNote.test.js.snap +++ b/packages/lib/services/interop/__snapshots__/InteropService_Importer_OneNote.test.js.snap @@ -1166,6 +1166,148 @@ exports[`InteropService_Importer_OneNote should remove hyperlink from title: 风 " `; +exports[`InteropService_Importer_OneNote should render audio as links to resource: My title 1`] = ` +" + + + + My title + + + + +
My title
+
Friday, March 7, 2025
+
11:16 AM
+

Audio Recording.wav

+

 

+

 

+

 

+

Some text here

+

 

+
+ + + +" +`; + +exports[`InteropService_Importer_OneNote should render audio as links to resource: Quick Notes 1`] = ` +" + + + + Quick Notes + + + + + + + + + + + +" +`; + exports[`InteropService_Importer_OneNote should render links properly by ignoring wrongly set indices when the first character is a hyperlink marker: Is Mexico safe for shooting Street Photography 1`] = ` " diff --git a/packages/onenote-converter/src/page/embedded_file.rs b/packages/onenote-converter/src/page/embedded_file.rs index c625bc1cca..9488423be8 100644 --- a/packages/onenote-converter/src/page/embedded_file.rs +++ b/packages/onenote-converter/src/page/embedded_file.rs @@ -22,9 +22,10 @@ impl<'a> Renderer<'a> { let file_type = Self::guess_type(file); match file_type { - FileType::Audio => content = format!("", filename), + // TODO: we still don't have support for the audio tag on html notes https://github.com/laurent22/joplin/issues/11939 + // FileType::Audio => content = format!("", filename), FileType::Video => content = format!("", filename), - FileType::Unknown => { + FileType::Unknown | FileType::Audio => { content = format!( "

{}

", filename, filename