Joplin
/
joplin
mirror of https://github.com/laurent22/joplin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Mobile: Resolves #2715: Close sidebar when displaying error dialog (#2720) 

* added a new close function to close sidebar for an error and fixed #2715

* changed function to inline call of dispatch fixes #2715
pull/2730/head
Ishant Gupta 2020-03-14 01:28:17 +05:30 committed by GitHub
parent d208da577f
commit 115eb6f511
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ReactNativeClient/lib/components/screens/note.js
View File

@ -184,6 +184,7 @@ class NoteScreenComponent extends BaseScreenComponent {
this.cameraView_onPhoto = this.cameraView_onPhoto.bind(this); this.cameraView_onPhoto = this.cameraView_onPhoto.bind(this);
this.cameraView_onCancel = this.cameraView_onCancel.bind(this); this.cameraView_onCancel = this.cameraView_onCancel.bind(this);
this.properties_onPress = this.properties_onPress.bind(this); this.properties_onPress = this.properties_onPress.bind(this);
this.showOnMap_onPress = this.showOnMap_onPress.bind(this);
this.onMarkForDownload = this.onMarkForDownload.bind(this); this.onMarkForDownload = this.onMarkForDownload.bind(this);
this.sideMenuOptions = this.sideMenuOptions.bind(this); this.sideMenuOptions = this.sideMenuOptions.bind(this);
this.folderPickerOptions_valueChanged = this.folderPickerOptions_valueChanged.bind(this); this.folderPickerOptions_valueChanged = this.folderPickerOptions_valueChanged.bind(this);
@ -599,6 +600,7 @@ class NoteScreenComponent extends BaseScreenComponent {
const url = Note.geolocationUrl(note); const url = Note.geolocationUrl(note);
Linking.openURL(url); Linking.openURL(url);
} catch (error) { } catch (error) {
this.props.dispatch({ type: 'SIDE_MENU_CLOSE' });
await dialogs.error(this, error.message); await dialogs.error(this, error.message);
} }
} }