Desktop: Fixes #4049: Keymap editor crash when an invalid command is used

release-1.3
Laurent Cozic 2020-11-06 11:51:36 +00:00
parent 496b19b3f1
commit 0cfcc00912
1 changed files with 7 additions and 2 deletions

View File

@ -30,9 +30,14 @@ const getLabel = (commandName: string):string => {
return _('Command palette');
case 'config':
return shim.isMac() ? _('Preferences') : _('Options');
default:
throw new Error(`Command: ${commandName} is unknown`);
}
// We don't throw an error if a command is not found because if for
// example a command is removed from one version to the next, or a
// command is renamed, we still want the keymap editor to work. So in
// that case, we simply display the command name and it is up to the
// user to fix the shortcut if needed.
return `${commandName} (${_('Invalid')})`;
};
export default getLabel;