Joplin
/
joplin
mirror of https://github.com/laurent22/joplin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
joplin/packages/app-desktop/gui/MainScreen/commands/toggleVisiblePanes.ts

21 lines
520 B
TypeScript
Raw Normal View History

Tools: Renamed package namespace from @joplinapp to @joplin
2020-11-07 15:59:37 +00:00
import { CommandDeclaration, CommandRuntime } from '@joplin/lib/services/CommandService';
import { _ } from '@joplin/lib/locale';
Desktop: Refactored command system The goal is to make the command system more modular, so each command can be defined as a single object that includes a declaration (name, label, etc.) and a runtime (to execute the command, test if it should be enabled, etc.) Utility methods are provided to convert a command to a menu item or a toolbar button, thus reducing duplicated and boiler plate code across the codebase (often the menu item logic was duplicated in the toolbar button logic and vice versa). The goal is to make it easier to add new commands (and associated menu item and toolbar buttons) and to call them from anywhere. This is also useful for plugins, which can also easily define new commands. Could also allow creating a command palette.
2020-07-03 21:32:39 +00:00
Tools: Apply rule @typescript-eslint/type-annotation-spacing
2020-11-12 19:13:28 +00:00
export const declaration: CommandDeclaration = {
Desktop: Refactored command system The goal is to make the command system more modular, so each command can be defined as a single object that includes a declaration (name, label, etc.) and a runtime (to execute the command, test if it should be enabled, etc.) Utility methods are provided to convert a command to a menu item or a toolbar button, thus reducing duplicated and boiler plate code across the codebase (often the menu item logic was duplicated in the toolbar button logic and vice versa). The goal is to make it easier to add new commands (and associated menu item and toolbar buttons) and to call them from anywhere. This is also useful for plugins, which can also easily define new commands. Could also allow creating a command palette.
2020-07-03 21:32:39 +00:00
name: 'toggleVisiblePanes',
label: () => _('Toggle editor layout'),
Desktop: UI update (#3586)
2020-09-15 13:01:07 +00:00
iconName: 'icon-layout ',
Desktop: Refactored command system The goal is to make the command system more modular, so each command can be defined as a single object that includes a declaration (name, label, etc.) and a runtime (to execute the command, test if it should be enabled, etc.) Utility methods are provided to convert a command to a menu item or a toolbar button, thus reducing duplicated and boiler plate code across the codebase (often the menu item logic was duplicated in the toolbar button logic and vice versa). The goal is to make it easier to add new commands (and associated menu item and toolbar buttons) and to call them from anywhere. This is also useful for plugins, which can also easily define new commands. Could also allow creating a command palette.
2020-07-03 21:32:39 +00:00
};
Tools: Apply rule @typescript-eslint/type-annotation-spacing
2020-11-12 19:13:28 +00:00
export const runtime = (comp: any): CommandRuntime => {
Desktop: Refactored command system The goal is to make the command system more modular, so each command can be defined as a single object that includes a declaration (name, label, etc.) and a runtime (to execute the command, test if it should be enabled, etc.) Utility methods are provided to convert a command to a menu item or a toolbar button, thus reducing duplicated and boiler plate code across the codebase (often the menu item logic was duplicated in the toolbar button logic and vice versa). The goal is to make it easier to add new commands (and associated menu item and toolbar buttons) and to call them from anywhere. This is also useful for plugins, which can also easily define new commands. Could also allow creating a command palette.
2020-07-03 21:32:39 +00:00
return {
execute: async () => {
comp.props.dispatch({
type: 'NOTE_VISIBLE_PANES_TOGGLE',
});
},
Desktop: Simplified and improve command service, and added command palette - Commands "enabled" state is now expressed using a "when-clause" like in VSCode - A command palette has been added to the Tools menu
2020-10-18 20:52:10 +00:00
enabledCondition: 'markdownEditorVisible && oneNoteSelected',
Desktop: Refactored command system The goal is to make the command system more modular, so each command can be defined as a single object that includes a declaration (name, label, etc.) and a runtime (to execute the command, test if it should be enabled, etc.) Utility methods are provided to convert a command to a menu item or a toolbar button, thus reducing duplicated and boiler plate code across the codebase (often the menu item logic was duplicated in the toolbar button logic and vice versa). The goal is to make it easier to add new commands (and associated menu item and toolbar buttons) and to call them from anywhere. This is also useful for plugins, which can also easily define new commands. Could also allow creating a command palette.
2020-07-03 21:32:39 +00:00
};
};