1f5f5cb789
Background of the bug: Prior to this patch we actually tried writing points that were older than the retention period of the shard. This caused race condition when it came to writing points to a shard that's being dropped, which will happen frequently if the user is loading old data (by accident). This is demonstrated in the test in this commit.This bug was previously addressed in #985. It turns the fix for #985 wasn't enough. A user reported in #1078 that some shards are left behind and not deleted. It turns out that while the shard is being dropped more write requests could come in and end up on line `cluster/shard.go:195` which will cause the datastore to create a shard on disk that isn't tracked anywhere in the metadata. This shard will live forever and never get deleted. This fix address this issue by not writing old points in, but there are still some edge cases with the current implementation, at least not as bad as current master. Close #1078 |
||
|---|---|---|
| .. | ||
| storage | ||
| datastore_test.go | ||
| interface.go | ||
| mock_user_test.go | ||
| point_iterator.go | ||
| point_iterator_stream.go | ||
| raw_column_value.go | ||
| shard.go | ||
| shard_datastore.go | ||
| shard_datastore_test.go | ||
| storage_key.go | ||
| utils.go | ||