05189fdb00
Prior to this change background tasks that we feed into `AdapterStream` can panic but that would just end the stream without any user-visible error (except for the panic message on stdout/stderr). This was found while developing #4964. I have proposed another fix in #4966 but found that I actually developed an existing solution a 2nd time: `watch_task`. But I also see a major issue with the existing API: one can create `AdapterStream` with ordinary tokio tasks that are not watched at all, leaving the burden to the implementor to check for that (and actually we forgot that in `parquet_file`). So this change takes a slightly different approach: The `AdapterStream` does NOT accept ordinary join handles any longer but requires that you pass a "watched task". The newly introduced `WatchedTask` does the same as we did manually before: wrapping a future into a tokio task, watch it and wrap the watcher into a task. It is now way more difficult to do anything stupid (sure you can still mix up the tasks and the channels, but we need at least some flexibility here to allow for "split" and potential future fan-in/out constructs). Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| src | ||
| Cargo.toml | ||
| README.md | ||
README.md
IOx Query Layer
The IOx query layer is responsible for translating query requests from different query languages and planning and executing them against Chunks stored across various IOx storage systems.
Query Frontends
- SQL
- Storage gRPC
- Flux (possibly in the future)
- InfluxQL (possibly in the future)
- Others (possibly in the future)
Sources of Chunk data
- ReadBuffer
- MutableBuffer
- Parquet Files
- Others (possibly in the future, like Remote Chunk?)
The goal is to use the shared query / plan representation in order to avoid N*M combinations of language and Chunk source.
Thus query planning is implemented in terms of traits, and those traits are implemented by different chunk implementations.
Among other things, this means that this crate should not depend directly on the ReadBuffer or the MutableBuffer.
┌───────────────┐ ┌────────────────┐ ┌──────────────┐ ┌──────────────┐
│Mutable Buffer │ │ Read Buffer │ │Parquet Files │ ... │Future Source │
│ │ │ │ │ │ │ │
└───────────────┘ └────────────────┘ └──────────────┘ └──────────────┘
▲ ▲ ▲ ▲
└───────────────────┴─────────┬──────────┴─────────────────────┘
│
│
┌─────────────────────────────────┐
│ Shared Common │
│ Predicate, Plans, Execution │
└─────────────────────────────────┘
▲
│
│
┌──────────────────────┼─────────────────────────┐
│ │ │
│ │ │
│ │ │
┌───────────────────┐ ┌──────────────────┐ ┌──────────────────┐
│ SQL Frontend │ │ gRPC Storage │ ... │ Future Frontend │
│ │ │ Frontend │ │ (e.g. InfluxQL) │
└───────────────────┘ └──────────────────┘ └──────────────────┘
We are trying to avoid ending up with something like this:
┌─────────────────────────────────────────────────┐
│ │
▼ │
┌────────────┐ │
│Read Buffer │ ┌────────────────────────┤
┌──────────┼────────────┼─────┬────────────┼────────────────────────┤
│ └────────────┘ │ ▼ │
▼ ▲ │ ┌──────────────┐ │
┌───────────────┐ │ │ │Parquet Files │ │
│Mutable Buffer │ │ ├───▶│ │... │
│ │◀────────┼───────────┤ └──────────────┘ ┌─────────────┼┐
└───────────────┘ │ │ ▲ │Future Source││
▲ │ ├────────────┼─────────▶│ ││◀─┐
│ │ │ │ └─────────────┼┘ │
│ │ │ │ │ │
│ │ │ │ │ │
│ ┌──────────┘ │ │ │ │
│ │ │ │ │ │
│ ├──────────────────────┼────────────┘ │ │
└──────┤ │ │ │
│ │ │ │
│ │ │ │
│ │ │ │
│ │ │ │
│ │ │ │
│ │ │ │
│ │ │ │
┌───────────────────┐ ┌──────────────────┐ ┌──────────────────┐ │ │
│ SQL Frontend │ │ gRPC Storage │ ... │ Future Frontend │ │ │
│ │ │ Frontend │ │ (e.g. InfluxQL) │──┴───┘
└───────────────────┘ └──────────────────┘ └──────────────────┘