influxdb/authz_test.go

package influxdb_test

import (
	"testing"

	platform "github.com/influxdata/influxdb/v2"
	platform2 "github.com/influxdata/influxdb/v2/kit/platform"
	influxdbtesting "github.com/influxdata/influxdb/v2/testing"
)

func TestAuthorizer_PermissionAllowed(t *testing.T) {
	tests := []struct {
		name        string
		permission  platform.Permission
		permissions []platform.Permission
		allowed     bool
	}{
		{
			name: "global permission",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type: platform.BucketsResourceType,
					},
				},
			},
			allowed: true,
		},
		{
			name: "bad org id in permission",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(0),
					ID:    influxdbtesting.IDPtr(0),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: false,
		},
		{
			name: "bad resource id in permission",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(0),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: false,
		},
		{
			name: "bad resource id in permissions",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(0),
					},
				},
			},
			allowed: false,
		},
		{
			name: "matching action resource and ID",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: true,
		},
		{
			name: "matching action resource with total",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: true,
		},
		{
			name: "matching action resource no ID",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: true,
		},
		{
			name: "matching action resource differing ID",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(2),
					},
				},
			},
			allowed: false,
		},
		{
			name: "differing action same resource",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.ReadAction,
					Resource: platform.Resource{
						Type:  platform.BucketsResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: false,
		},
		{
			name: "same action differing resource",
			permission: platform.Permission{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    influxdbtesting.IDPtr(1),
				},
			},
			permissions: []platform.Permission{
				{
					Action: platform.WriteAction,
					Resource: platform.Resource{
						Type:  platform.TasksResourceType,
						OrgID: influxdbtesting.IDPtr(1),
						ID:    influxdbtesting.IDPtr(1),
					},
				},
			},
			allowed: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			allowed := platform.PermissionAllowed(tt.permission, tt.permissions)
			if allowed != tt.allowed {
				t.Errorf("got allowed = %v, expected allowed = %v", allowed, tt.allowed)
			}
		})
	}
}

func TestPermission_Valid(t *testing.T) {
	type fields struct {
		Action   platform.Action
		Resource platform.Resource
	}
	tests := []struct {
		name    string
		fields  fields
		wantErr bool
	}{
		{
			name: "valid bucket permission with ID",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					ID:    validID(),
					OrgID: influxdbtesting.IDPtr(1),
				},
			},
		},
		{
			name: "valid bucket permission with nil ID",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					ID:    nil,
					OrgID: influxdbtesting.IDPtr(1),
				},
			},
		},
		{
			name: "invalid bucket permission with an invalid ID",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					ID:    func() *platform2.ID { id := platform2.InvalidID(); return &id }(),
					OrgID: influxdbtesting.IDPtr(1),
				},
			},
			wantErr: true,
		},
		{
			name: "invalid permission without an action",
			fields: fields{
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
				},
			},
			wantErr: true,
		},
		{
			name: "invalid permission without a resource",
			fields: fields{
				Action: platform.WriteAction,
			},
			wantErr: true,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			p := &platform.Permission{
				Action:   tt.fields.Action,
				Resource: tt.fields.Resource,
			}
			if err := p.Valid(); (err != nil) != tt.wantErr {
				t.Errorf("Permission.Valid() error = %v, wantErr %v", err, tt.wantErr)
			}
		})
	}
}

func TestPermissionAllResources_Valid(t *testing.T) {
	var resources = []platform.ResourceType{
		platform.UsersResourceType,
		platform.OrgsResourceType,
		platform.TasksResourceType,
		platform.BucketsResourceType,
		platform.DashboardsResourceType,
		platform.SourcesResourceType,
		platform.NotebooksResourceType,
		platform.AnnotationsResourceType,
	}

	for _, rt := range resources {
		p := &platform.Permission{
			Action: platform.WriteAction,
			Resource: platform.Resource{
				Type: rt,
				ID:   influxdbtesting.IDPtr(1),
			},
		}

		if err := p.Valid(); err != nil {
			t.Errorf("PermissionAllResources.Valid() error = %v", err)
		}
	}
}

func TestPermissionAllActions(t *testing.T) {
	var actions = []platform.Action{
		platform.ReadAction,
		platform.WriteAction,
	}

	for _, a := range actions {
		p := &platform.Permission{
			Action: a,
			Resource: platform.Resource{
				Type:  platform.TasksResourceType,
				OrgID: influxdbtesting.IDPtr(1),
			},
		}

		if err := p.Valid(); err != nil {
			t.Errorf("PermissionAllActions.Valid() error = %v", err)
		}
	}
}

func TestPermission_String(t *testing.T) {
	type fields struct {
		Action   platform.Action
		Resource platform.Resource
		Name     *string
	}
	tests := []struct {
		name   string
		fields fields
		want   string
	}{
		{
			name: "valid permission with no id",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
				},
			},
			want: `write:orgs/0000000000000001/buckets`,
		},
		{
			name: "valid permission with an id",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type:  platform.BucketsResourceType,
					OrgID: influxdbtesting.IDPtr(1),
					ID:    validID(),
				},
			},
			want: `write:orgs/0000000000000001/buckets/0000000000000064`,
		},
		{
			name: "valid permission with no id or org id",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type: platform.BucketsResourceType,
				},
			},
			want: `write:buckets`,
		},
		{
			name: "valid permission with no org id",
			fields: fields{
				Action: platform.WriteAction,
				Resource: platform.Resource{
					Type: platform.BucketsResourceType,
					ID:   influxdbtesting.IDPtr(1),
				},
			},
			want: `write:buckets/0000000000000001`,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			p := platform.Permission{
				Action:   tt.fields.Action,
				Resource: tt.fields.Resource,
			}
			if got := p.String(); got != tt.want {
				t.Errorf("Permission.String() = %v, want %v", got, tt.want)
			}
		})
	}
}

func validID() *platform2.ID {
	id := platform2.ID(100)
	return &id
}