Commit Graph

14114 Commits (fd21a0b326be9e58bbe02e38fb28122b18129ba9)

Author SHA1 Message Date
Ben Johnson 844b7ef9bf
Merge pull request #10299 from influxdata/bj-tsm1-panic-fix
Fix TSM1 panic on reader error.
2018-10-10 08:12:17 -06:00
Hercules Mango Churchill 86ac358448 Update changelog 2018-10-09 16:08:23 +00:00
Edd Robinson ee61ed3dca
Merge pull request #10327 from influxdata/er-duplicate-tsm
Cleanup failed TSM snapshots
2018-10-09 17:08:04 +01:00
Edd Robinson 86c011e697
Merge pull request #10341 from influxdata/er-buildtsi
Set cache size when building TSI index
2018-10-09 16:18:39 +01:00
Mark Rushakoff 94f9b251ac
Merge pull request #10345 from bvwells/uuid
golint uuid package
2018-10-08 14:42:35 -07:00
bvwells fa9cf639b4 golint uuid package 2018-10-08 21:21:44 +01:00
Mark Rushakoff f4af254f34
Merge pull request #10344 from bvwells/monitor
golint monitor package
2018-10-08 13:13:12 -07:00
bvwells faf153d233 golint monitor 2018-10-08 20:53:29 +01:00
Edd Robinson c57c1744ed Set cache size when building TSI index
If there is a significant amount of data in the WAL, then building the
TSI index can be problematic without being able to set the max cache
size to something larger.

This commit adds an option to se the maximum cache size.
2018-10-08 16:26:37 +01:00
Hercules Mango Churchill 13e3dd5828 Update changelog 2018-10-08 14:35:28 +00:00
Ben Johnson 1580f90be4
Merge pull request #10339 from influxdata/bj-fix-series-index-tombstone
Fix series file tombstoning.
2018-10-08 08:35:05 -06:00
Hercules Mango Churchill 576c14c018 Update changelog 2018-10-08 14:31:38 +00:00
Ben Johnson b5c82a82e9
Merge pull request #10326 from influxdata/bj-fix-nil-tsi-iterator
Fix append of possible nil iterator.
2018-10-08 08:31:19 -06:00
Ben Johnson 2cb97146f0
Fix series file tombstoning.
This commit fixes an issue with the series file compaction process
where tombstones are lost after compaction and series existence
checks are not correct. This commit also fixes some smaller flushing
issues within the series file that mainly related to testing.
2018-10-05 08:23:25 -06:00
Hercules Mango Churchill 634f4219fd Update changelog 2018-10-04 18:55:37 +00:00
Jonathan A. Sternberg ad83a19ad9
Merge pull request #10333 from influxdata/js-subquery-fixes
Assorted fixes to subquery regressions in 1.6
2018-10-04 13:55:21 -05:00
Jonathan A. Sternberg 22fc9f6a19
Strip tags from a subquery when the outer query does not group by that tag
The following would, erroneously, not strip the tag from the inner
query:

    SELECT value FROM (SELECT value FROM cpu GROUP BY host)

The inner query was supposed to group by the host tag, but the outer
query should strip it away since it is not being grouped by anymore.
This fixes things so that the result will have the tags stripped away
when they are not requested in the grouping.
2018-10-04 10:05:46 -05:00
Jonathan A. Sternberg 634471f12e
Fix subquery functionality when a function references a tag from the subquery
It has previously been allowed for a subquery to use a tag within a
function (such as `count()`) when the tag is from a subquery and the
subquery itself references a field at some point to perform the join.

This functionality regressed in 1.6 because of a change in how
subqueries were executed that forgot to treat a tag the same as a string
field.

This fixes that regression and adds a test case to avoid hitting that
regression again.
2018-10-04 10:05:20 -05:00
Stuart Carnie 8d07870717 fix(flux): Fix panic when executing a query that returns no results
fixes https://github.com/influxdata/flux/issues/81
2018-10-03 11:55:48 -07:00
Stuart Carnie 552e54ba14 fix(flux): Fix panic when executing a group / distinct query
fixes https://github.com/influxdata/flux/issues/81
2018-10-03 11:55:48 -07:00
Gershon Shif e529bf57fb Merge branch 'eirinikos-update-license' 2018-10-03 09:00:21 -07:00
Edd Robinson d649d5928b Cleanup failed TSM snapshot
If there was an error after the cache has been snapshotted to one or
more TSM files, but before the cache and WAL are cleaned up, then the
cache would be repeatedly snapshotted, generated duplicate level 1 TSM
files.

This commit attempts to clean those files up by removing the temporary
TSM file(s). The snapshot will be retried.
2018-10-03 16:34:54 +01:00
Gershon Shif 2a9744f801 Merge branch 'update-license' of https://github.com/eirinikos/influxdb into eirinikos-update-license 2018-10-02 20:29:00 -07:00
Ben Johnson bdcbad3fc9
Fix append of possible nil iterator.
This commit updates an iterator list to ignore `nil` iterators.
Adding a `nil` caused the `SeriesIterators.Close()` to panic.
2018-10-02 13:19:21 -06:00
Hercules Mango Churchill c6889b1a95 Update changelog 2018-10-02 14:43:52 +00:00
Jonathan A. Sternberg e219d9f582
Merge pull request #10321 from ryuhhnn/master
Changes /ping route to return status code 200 instead of 204 when verbose is set
2018-10-02 09:43:34 -05:00
Ryan Coleman 76fe3f081c
Changes /ping route to return status code 200 instead of 204 when verbose is set
Closes #9772.
2018-10-02 09:11:55 -05:00
Jonathan A. Sternberg 677552f093
Merge pull request #9806 from mschoenlaub/master
Print error message for unknown errors in client
2018-10-01 16:27:16 -05:00
Manuel Schoenlaub 15bd336efd
Print error message for unknown errors, e.g. server crashes without message 2018-10-01 16:25:37 -05:00
Jonathan A. Sternberg 857afc1006
Merge pull request #10125 from sangyun-han/master
update UDP client example
2018-10-01 16:16:06 -05:00
Sangyun Han fcb20c2c95
update UDP client example
- fix NewUDPClient to use UDPConfig
2018-10-01 16:14:24 -05:00
Ben Johnson 55a985bdf2
Merge pull request #10310 from influxdata/bj-fix-tsi1-sketches
Fix TSI1 Sketch Locking
2018-10-01 14:36:54 -06:00
Ben Johnson 0d777ad423
Fix tsi1 sketch locking. 2018-09-26 17:01:47 -06:00
Adam 5bb62597c8
Backup continue on errors (#10307)
* mod backup to continue if a shard fails to backup
2018-09-26 14:44:14 -04:00
Stuart Carnie 68e5807c82 fix(storage): Set the Type field to Tag
Transforming an RPC predicate to InfluxQL should set the Type field
to Tag, as it is explicitly set as a tag in the protobuf predicate
2018-09-25 16:58:57 -07:00
Ben Johnson da2dfa495e
Fix TSM1 panic on reader error.
This commit fixes an error check so that a `nil` TSM reader does
not cause a panic.
2018-09-24 08:54:28 -06:00
Edd Robinson 8d679cf0c3
Merge pull request #10265 from influxdata/er-go1.11
Update to Go 1.11
2018-09-21 12:04:57 -07:00
Edd Robinson 05694a2c0e Add gcc to 32 bit build 2018-09-21 10:55:24 -07:00
Edd Robinson 453f3e96ce
Merge pull request #10234 from influxdata/er-roaring-cache
Improve TSI query planning with cached bitsets
2018-09-18 16:19:02 -07:00
Edd Robinson 812ac6da25 PR feedback 2018-09-18 15:58:38 -07:00
Edd Robinson a15bdeef92 Fix megacheck 2018-09-18 15:58:38 -07:00
Edd Robinson 76237d80f2 Address PR feedback 2018-09-18 15:58:38 -07:00
Ben Johnson e651153f1c Add TagValueSeriesIDCache.Delete(). 2018-09-18 15:58:38 -07:00
Ben Johnson fcbc03240a Inline mutex into TagValueSeriesIDCache. 2018-09-18 15:58:38 -07:00
Ben Johnson e4f8637234 Fix ParseSeriesKeyInto() buffer shrinkage. 2018-09-18 15:58:38 -07:00
Edd Robinson bdc293abdd Tidy up 2018-09-18 15:58:38 -07:00
Edd Robinson cc6f8c3502 Reduce allocations in TSI TagSets implementation
Since all tag sets are materialised to strings before this method
returns, a large number of allocations can be avoided by carefully
resuing buffers and containers.

This commit reduces allocations by about 75%, which can be very
significant for high cardinality workloads.

The benchmark results shown below are for a benchmark that asks for all
series keys matching `tag5=value0'. There are 100K matching series keys.

benchmark                                       old ns/op     new ns/op     delta
BenchmarkIndexSet_TagSets/1M_series/inmem-8     10959963      11144345      +1.68%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      23632757      18768888      -20.58%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     10496303      10380551      -1.10%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      24344359      19020234      -21.87%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     10359864      10818296      +4.43%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      23453357      19027445      -18.87%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     10479519      10400619      -0.75%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      26364965      19023749      -27.84%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     10437794      10557066      +1.14%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      23126946      19196955      -16.99%

benchmark                                       old allocs     new allocs     delta
BenchmarkIndexSet_TagSets/1M_series/inmem-8     51             51             +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      80067          20071          -74.93%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     51             51             +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      80067          20071          -74.93%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     51             51             +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      80067          20071          -74.93%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     51             51             +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      80067          20071          -74.93%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     51             51             +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      80067          20071          -74.93%

benchmark                                       old bytes     new bytes     delta
BenchmarkIndexSet_TagSets/1M_series/inmem-8     3556728       3556728       +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      12677328      5157992       -59.31%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     3556728       3556728       +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      12677328      5157992       -59.31%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     3556728       3556728       +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      12677328      5157992       -59.31%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     3556728       3556728       +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      12677328      5157992       -59.31%
BenchmarkIndexSet_TagSets/1M_series/inmem-8     3556728       3556728       +0.00%
BenchmarkIndexSet_TagSets/1M_series/tsi1-8      12677328      5157992       -59.31%
2018-09-18 15:58:38 -07:00
Edd Robinson d8af622333 Add benchmark for TagSets across indexes 2018-09-18 15:58:38 -07:00
Edd Robinson 5c88a1dd0e Fix locking on cache 2018-09-18 15:58:38 -07:00
Edd Robinson 6d12f5d323 Debug 2018-09-18 15:58:38 -07:00