fb3c837de9
code review sugestions applied
2019-02-06 09:10:51 +01:00
5525240de3
reuse ValuerEval objects
...
Scanner objects and iterators often need a ValuerEval. This
object is created, often with a function call, and has at
least one interface in it, so it allocates storage. Then it's
dropped again right away. The only part of it that might be
subject to change is usually a map. While the map's contents
change over time, the actual map doesn't change for the
lifetime of the object.
So, in both iterators and scanners, stash the ValuerEval
and continue reusing it. On a query returning a fair number
of data points, this produces a small (<5% in practice)
improvement in observed performance, visible as a significant
reduction in time spent in runtime (mallocgc, newobject,
etcetera).
The performance improvement isn't big, but it's reasonably
easy to evaluate it and establish that it's a safe change
to make.
Signed-off-by: seebs <seebs@seebs.net>
2019-02-05 15:10:23 -06:00
cb9b89015d
Add back newlines to minimize changes
2019-02-05 07:47:29 -05:00
502ac291e7
Move resp after Store.Read
2019-02-05 07:45:59 -05:00
9aace188cc
Add back newline
2019-02-04 22:28:35 -05:00
4bd67c5c68
Merge branch '1.8' into fix-null-pointer-reference
2019-02-04 22:20:05 -05:00
d2e6b91de2
Updated servePromRead to match #10617 and updated handler_test.go to reflect changes
2019-02-04 22:15:44 -05:00
def9589584
Merge pull request #10522 from hahnjo/fix-compaction-cache-snapshots
...
Fix compaction logic on infrequent cache snapshots
2019-02-04 08:34:03 -07:00
5c2577df8c
Merge pull request #10502 from hpbieker/hpb-no-series-rebuild-on-delete-when-series-still-in-cache
...
No rebuild series index on delete when the series still exists in cache
2019-02-04 08:32:34 -07:00
4083ae01e3
Merge branch '1.8' into hpb-no-series-rebuild-on-delete-when-series-still-in-cache
2019-02-04 08:32:04 -07:00
6afad6e322
Merge branch '1.8' into modify-contextkey
2019-02-04 20:41:11 +09:00
e9dee25dda
Merge pull request #9916 from datamuc/master
...
add test case for #9522
2019-02-04 03:36:54 -08:00
e72b24653a
Merge pull request #10546 from iguanesolutions/clientv2_queryctx
...
clientv2 - QueryCtx()
2019-02-04 03:34:19 -08:00
f086930d42
Merge pull request #10480 from ShiKaiWi/refactor-writeToShard
...
improve error handling of PointsWriter.writeToShard
2019-02-04 03:24:40 -08:00
3a81921bb0
Merge pull request #10505 from hpbieker/hpb-no-series-rebuild-on-delete-without-overlap-timerange
...
Do not rebuild series index on delete for series not overlapping in time
2019-02-04 03:22:00 -08:00
603e0c9837
Merge pull request #10350 from bvwells/golint-logger
...
Golint logger package
2019-02-04 02:42:10 -08:00
17bec0438f
Merge pull request #10392 from bvwells/misspell
...
Fix misspelling identified by misspell
2019-02-04 02:38:38 -08:00
e9bada090f
Fix misspelling identified by misspell
2019-02-03 20:27:43 +00:00
c6cd433306
Golint logger package
2019-02-03 20:11:31 +00:00
35638abd7a
linting all udp error messages
2019-02-03 00:46:59 +01:00
6133f91d67
Merge branch '1.8' into master
2019-02-02 17:33:04 +01:00
59e4d86cbf
Merge pull request #10438 from smasuda/feature/fix_pr_template
...
to fix the dead link to InfluxQL in the PR template
2019-02-01 15:52:33 -08:00
0c6d77d952
Merge pull request #9944 from michaelyou/hotfix-hashring-mod
...
Hash ring's hash mod
2019-02-01 12:54:15 -08:00
7431808996
Merge pull request #10403 from gupsho/fix_golint_warnings_services_graphite
...
Fix golint warnings for services/graphite
2019-02-01 08:20:42 -08:00
424dce8173
Merge pull request #10401 from gupsho/fix_lint_warnings_snapshotter
...
Fix lint warnings snapshotter
2019-02-01 08:06:26 -08:00
4356c06a71
Merge pull request #10336 from wrrn/error-golint
...
Fix linting errors in the errlist package
2019-02-01 07:58:05 -08:00
87adbea5f3
Update changelog
2019-02-01 15:55:05 +00:00
e7a40402ea
Merge pull request #10276 from brookst/abs-fix
...
Fix bug with incorrect ABS results for negative integer values
2019-02-01 07:54:46 -08:00
7520253ec9
Merge pull request #11615 from influxdata/BP1.8-er-cow-off
...
Remove copy-on-write when caching bitmaps
2019-01-28 11:55:39 -08:00
301ab71ba0
Remove copy-on-write when caching bitmaps
...
In the case of caching TSI bitmaps belonging to immutable .tsi files,
the underlying bitset data can be mmapped. It is possible, though rare,
for this data to be unmapped (e.g., via a TSI compaction) but for the
cached bitmap to be subsequently read. This leads to a segfault.
This only happens when copy-on-write is set to true on the roaring
bitmap, because in that case only the internal pointers are cloned.
This change will reduce the TSI cache performance by around 10%, which I
have deemed to account for only a few microseconds typically.
2019-01-25 18:02:48 +00:00
7590d807e5
Update changelog
2019-01-25 17:33:27 +00:00
7da81848de
Merge pull request #11525 from influxdata/er-cache-config
...
Allow TSI bitset cache to be configured
2019-01-25 17:33:09 +00:00
efdddbb31a
Allow TSI bitset cache size to be configured
...
This commit adds a config option to the tsdb Config allowing the size of
the bitset cached in the TSI index to be specified.
Setting the cache size to 0 will disable the cache.
2019-01-24 17:41:45 +00:00
e20541d2ba
Expose functional option for setting TSI cache size
2019-01-23 17:15:48 +00:00
26afe32611
Merge pull request #11001 from influxdata/changelog-1.x-only
...
Only update the changelog on 1.x branches
2019-01-11 09:43:55 -08:00
489a0f6ad0
Merge pull request #10958 from influxdata/er-sketch-cardinality
...
Fix cardinality estimation error
2019-01-11 17:28:05 +00:00
beb6848d95
Only update the changelog on 1.x branches
...
Master is switching to 2.x development today, and we are not going to
continue using the changelog strategy we used in 1.x.
2019-01-11 08:54:44 -08:00
c47a3ea2af
feat(flux): Add support for optionally logging Flux queries
...
New configuration:
```toml
[http]
flux-log-enabled = true
```
will produce log entries similar to:
```
ts=2019-01-11T14:47:46.124347Z lvl=info msg="Executed Flux query" log_id=0CwLysq0000 service=httpd compiler_type=flux response_size=1467 query="from(bucket:\"test\") |> range(start: -5000h) |> limit(n:5)" stat_total_duration=3.949ms stat_compile_duration=3.183ms stat_queue_duration=0.026ms stat_plan_duration=0.055ms stat_requeue_duration=0.000ms stat_execute_duration=0.668ms stat_max_allocated=3200 stat_concurrency=1
```
2019-01-11 09:09:26 -07:00
3a055a6107
Fix cardinality estimation error
...
This commit fixes an error in the TSI index with estimating the
cardinality of series recently added and then removed.
2019-01-10 17:46:30 +00:00
a62e7864bb
Update changelog
2019-01-09 23:10:14 +00:00
2987bcec1c
Merge pull request #10664 from influxdata/js-fix-function-types
...
Marked functions that always return floats as always returning floats
2019-01-09 17:09:58 -06:00
865e6a05f0
Marked functions that always return floats as always returning floats
...
These functions, when used on non-float types in subqueries, would
return incorrect results as the type system thought they would return a
different type than the actual implementation would return.
2019-01-09 16:56:29 -06:00
8ab48459ce
Merge pull request #10617 from influxdata/dn-fix-prom-api-panic
...
Fix panic in Prometheus read API
2019-01-09 10:15:26 -05:00
8026cd6c86
fix #10595 : fix panic in Prometheus read API
2019-01-08 13:41:41 -05:00
4d21ab9e0e
Merge pull request #10613 from influxdata/readme-fix
...
Fixing date; capitalization of InfluxDB
2019-01-07 12:30:25 -06:00
3fe2e9db9a
Merge pull request #10608 from influxdata/flux-staging
...
chore: update Flux to v0.12.0
2019-01-07 10:56:17 -07:00
b2bc1cd315
Fixing date; capitalization of InfluxDB
2019-01-07 11:28:06 -06:00
7ecab55018
chore: update Flux to v0.12.0
2019-01-03 15:14:10 -07:00
dd481f35df
Merge pull request #10599 from influxdata/sgc-check-utf8
...
Add -check-utf8 to verify sub-command
2019-01-02 13:29:43 -07:00
8aba6f73a5
feat(influx_inspect): Add -check-utf8 to verify sub-command
2018-12-21 10:44:43 -07:00
Grzegorz Pomykala
Seebs
Dilan Bellinghoven
Ben Johnson
KimMachineGun
Edd Robinson
Ben Wells
Edouard Hur
datamuc
Hercules Mango Churchill
Mark Rushakoff
Mark Rushakoff
Stuart Carnie
Jonathan A. Sternberg
David Norton
Tim Yocum
Nathaniel Cook
Tim Yocum