Commit Graph

14352 Commits (fb99e615981409f441f33899beb992376858057c)

Author SHA1 Message Date
Edd Robinson 8b5b0fc5d2
Merge pull request #10375 from KimMachineGun/modify-contextkey
Modify context key type
2019-02-11 10:48:24 +00:00
Edd Robinson 05e7def600
Merge pull request #10332 from ludweeg/ludweeg/unslice
Simplify s[:] to s where s is a slice
2019-02-11 10:24:43 +00:00
Hercules Mango Churchill 42ec806e7e Update changelog 2019-02-11 10:23:34 +00:00
Edd Robinson 42267331bd
Merge pull request #10206 from rda0/master
Fix legacy restore bug #10072
2019-02-11 10:23:15 +00:00
Edd Robinson 65b80cc742
Merge pull request #10591 from dbellinghoven/fix-null-pointer-reference
[BUG FIX] Fix nil pointer dereference at /api/v1/prom/read
2019-02-08 22:53:16 +00:00
Hercules Mango Churchill 126e4e2263 Update changelog 2019-02-07 01:14:32 +00:00
Gunnar cba956943a
Merge pull request #11742 from influxdata/ga-amzn-linux-2
Use Systemd for Amazon Linux 2
2019-02-06 17:14:13 -08:00
Gunnar Aasen 0350557c16 Use Systemd for Amazon Linux 2 packages 2019-02-06 16:28:48 -08:00
Grzegorz Pomykala 8448cf4a9c build fixed 2019-02-06 16:27:59 +01:00
Hercules Mango Churchill 5e1e0b122a Update changelog 2019-02-06 15:14:52 +00:00
Jonathan A. Sternberg 2811cde76d
Merge pull request #10414 from seebs/seebs/valuerReuse
reuse ValuerEval objects
2019-02-06 09:14:15 -06:00
Grzegorz Pomykala fb3c837de9 code review sugestions applied 2019-02-06 09:10:51 +01:00
Seebs 5525240de3 reuse ValuerEval objects
Scanner objects and iterators often need a ValuerEval. This
object is created, often with a function call, and has at
least one interface in it, so it allocates storage. Then it's
dropped again right away. The only part of it that might be
subject to change is usually a map. While the map's contents
change over time, the actual map doesn't change for the
lifetime of the object.

So, in both iterators and scanners, stash the ValuerEval
and continue reusing it. On a query returning a fair number
of data points, this produces a small (<5% in practice)
improvement in observed performance, visible as a significant
reduction in time spent in runtime (mallocgc, newobject,
etcetera).

The performance improvement isn't big, but it's reasonably
easy to evaluate it and establish that it's a safe change
to make.

Signed-off-by: seebs <seebs@seebs.net>
2019-02-05 15:10:23 -06:00
Dilan Bellinghoven cb9b89015d
Add back newlines to minimize changes 2019-02-05 07:47:29 -05:00
Dilan Bellinghoven 502ac291e7
Move resp after Store.Read 2019-02-05 07:45:59 -05:00
Dilan Bellinghoven 9aace188cc
Add back newline 2019-02-04 22:28:35 -05:00
Dilan Bellinghoven 4bd67c5c68
Merge branch '1.8' into fix-null-pointer-reference 2019-02-04 22:20:05 -05:00
Dilan Bellinghoven d2e6b91de2
Updated servePromRead to match #10617 and updated handler_test.go to reflect changes 2019-02-04 22:15:44 -05:00
Ben Johnson def9589584
Merge pull request #10522 from hahnjo/fix-compaction-cache-snapshots
Fix compaction logic on infrequent cache snapshots
2019-02-04 08:34:03 -07:00
Ben Johnson 5c2577df8c
Merge pull request #10502 from hpbieker/hpb-no-series-rebuild-on-delete-when-series-still-in-cache
No rebuild series index on delete when the series still exists in cache
2019-02-04 08:32:34 -07:00
Ben Johnson 4083ae01e3
Merge branch '1.8' into hpb-no-series-rebuild-on-delete-when-series-still-in-cache 2019-02-04 08:32:04 -07:00
KimMachineGun 6afad6e322
Merge branch '1.8' into modify-contextkey 2019-02-04 20:41:11 +09:00
Edd Robinson e9dee25dda
Merge pull request #9916 from datamuc/master
add test case for #9522
2019-02-04 03:36:54 -08:00
Edd Robinson e72b24653a
Merge pull request #10546 from iguanesolutions/clientv2_queryctx
clientv2 - QueryCtx()
2019-02-04 03:34:19 -08:00
Edd Robinson f086930d42
Merge pull request #10480 from ShiKaiWi/refactor-writeToShard
improve error handling of PointsWriter.writeToShard
2019-02-04 03:24:40 -08:00
Edd Robinson 3a81921bb0
Merge pull request #10505 from hpbieker/hpb-no-series-rebuild-on-delete-without-overlap-timerange
Do not rebuild series index on delete for series not overlapping in time
2019-02-04 03:22:00 -08:00
Edd Robinson 603e0c9837
Merge pull request #10350 from bvwells/golint-logger
Golint logger package
2019-02-04 02:42:10 -08:00
Edd Robinson 17bec0438f
Merge pull request #10392 from bvwells/misspell
Fix misspelling identified by misspell
2019-02-04 02:38:38 -08:00
Ben Wells e9bada090f Fix misspelling identified by misspell 2019-02-03 20:27:43 +00:00
Ben Wells c6cd433306 Golint logger package 2019-02-03 20:11:31 +00:00
Edouard Hur 35638abd7a
linting all udp error messages 2019-02-03 00:46:59 +01:00
datamuc 6133f91d67
Merge branch '1.8' into master 2019-02-02 17:33:04 +01:00
Edd Robinson 59e4d86cbf
Merge pull request #10438 from smasuda/feature/fix_pr_template
to fix the dead link to InfluxQL in the PR template
2019-02-01 15:52:33 -08:00
Ben Johnson 0c6d77d952
Merge pull request #9944 from michaelyou/hotfix-hashring-mod
Hash ring's hash mod
2019-02-01 12:54:15 -08:00
Edd Robinson 7431808996
Merge pull request #10403 from gupsho/fix_golint_warnings_services_graphite
Fix golint warnings for services/graphite
2019-02-01 08:20:42 -08:00
Edd Robinson 424dce8173
Merge pull request #10401 from gupsho/fix_lint_warnings_snapshotter
Fix lint warnings snapshotter
2019-02-01 08:06:26 -08:00
Edd Robinson 4356c06a71
Merge pull request #10336 from wrrn/error-golint
Fix linting errors in the errlist package
2019-02-01 07:58:05 -08:00
Hercules Mango Churchill 87adbea5f3 Update changelog 2019-02-01 15:55:05 +00:00
Edd Robinson e7a40402ea
Merge pull request #10276 from brookst/abs-fix
Fix bug with incorrect ABS results for negative integer values
2019-02-01 07:54:46 -08:00
Edd Robinson 7520253ec9
Merge pull request #11615 from influxdata/BP1.8-er-cow-off
Remove copy-on-write when caching bitmaps
2019-01-28 11:55:39 -08:00
Edd Robinson 301ab71ba0 Remove copy-on-write when caching bitmaps
In the case of caching TSI bitmaps belonging to immutable .tsi files,
the underlying bitset data can be mmapped. It is possible, though rare,
for this data to be unmapped (e.g., via a TSI compaction) but for the
cached bitmap to be subsequently read. This leads to a segfault.

This only happens when copy-on-write is set to true on the roaring
bitmap, because in that case only the internal pointers are cloned.

This change will reduce the TSI cache performance by around 10%, which I
have deemed to account for only a few microseconds typically.
2019-01-25 18:02:48 +00:00
Hercules Mango Churchill 7590d807e5 Update changelog 2019-01-25 17:33:27 +00:00
Edd Robinson 7da81848de
Merge pull request #11525 from influxdata/er-cache-config
Allow TSI bitset cache to be configured
2019-01-25 17:33:09 +00:00
Edd Robinson efdddbb31a Allow TSI bitset cache size to be configured
This commit adds a config option to the tsdb Config allowing the size of
the bitset cached in the TSI index to be specified.

Setting the cache size to 0 will disable the cache.
2019-01-24 17:41:45 +00:00
Edd Robinson e20541d2ba Expose functional option for setting TSI cache size 2019-01-23 17:15:48 +00:00
Mark Rushakoff 26afe32611
Merge pull request #11001 from influxdata/changelog-1.x-only
Only update the changelog on 1.x branches
2019-01-11 09:43:55 -08:00
Edd Robinson 489a0f6ad0
Merge pull request #10958 from influxdata/er-sketch-cardinality
Fix cardinality estimation error
2019-01-11 17:28:05 +00:00
Mark Rushakoff beb6848d95 Only update the changelog on 1.x branches
Master is switching to 2.x development today, and we are not going to
continue using the changelog strategy we used in 1.x.
2019-01-11 08:54:44 -08:00
Stuart Carnie c47a3ea2af feat(flux): Add support for optionally logging Flux queries
New configuration:

```toml
[http]
flux-log-enabled = true
```

will produce log entries similar to:

```
ts=2019-01-11T14:47:46.124347Z lvl=info msg="Executed Flux query" log_id=0CwLysq0000 service=httpd compiler_type=flux response_size=1467 query="from(bucket:\"test\") |> range(start: -5000h) |> limit(n:5)" stat_total_duration=3.949ms stat_compile_duration=3.183ms stat_queue_duration=0.026ms stat_plan_duration=0.055ms stat_requeue_duration=0.000ms stat_execute_duration=0.668ms stat_max_allocated=3200 stat_concurrency=1
```
2019-01-11 09:09:26 -07:00
Edd Robinson 3a055a6107 Fix cardinality estimation error
This commit fixes an error in the TSI index with estimating the
cardinality of series recently added and then removed.
2019-01-10 17:46:30 +00:00