Commit Graph

750 Commits (ec2af515bbf91235005c55c284c19543a8457d93)

Author SHA1 Message Date
Tim Raymond 493befbdc7 Enforce default constraints on first/last source
Whenver sources are present, there should be exactly one default source.
Prior to this commit, it was possible to add the first source as a
non-default source and circumvent this invariant. This unfortunately
requires a bit of special-casing logic in s.Add and requires a query to
fetch the number of sources currently persisted.

Tests have been added to cover this as well as deleting the final
source, to ensure that there aren't any odd indexing panics that might
result from trying to find another candidate default source when
deleting.
2016-11-07 18:13:23 -05:00
Tim Raymond d03d47b9ad Extract Default source enforcement logic
Enforcing the constraint that there be exactly one default source
whenever there are sources present isn't really a concern of the
traditional CRUD methods that are provided by SourcesStore. This makes
this separation a little more explicit and provides a place to glue some
documentation onto what would otherwise be a confusing bit of business
logic in the write path of SourcesStore.
2016-11-07 18:13:23 -05:00
Tim Raymond 193765ead2 Auto-set default source on Add and Delete
Previously, when adding a new default source, it was possible to create
more than one default source, since the previous default would not be unset.

Implementing this revealed another issue where deleting the default
source would leave no default set. If the default source is deleted now,
another source is chosen to be the new default.
2016-11-07 18:13:23 -05:00
Tim Raymond 4a02ad7525 Enforce single default source on update
This ensures that there will only be on default source upon setting a
new default by unsetting the default flag on all other sources. This
only happens when the source to be updated has Default set to true to
avoid a performance hit when updating other attributes.
2016-11-07 18:13:23 -05:00
Will Piers 352a39539d Switch order of save and test buttons for slack 2016-11-07 14:48:20 -08:00
nathan haugo fd17d09478 First rev of getting started 2016-11-07 14:45:04 -08:00
Will Piers b4b9752601 Merge pull request #398 from influxdata/syntax-errors
Fix syntax errors
2016-11-07 14:38:42 -08:00
Chris Goller b274363149 Add groupby options to layouts 2016-11-07 16:31:48 -06:00
Kevin Fitzpatrick ddd80b8754 Show missing alerts
It was key collision.
2016-11-07 14:30:10 -08:00
Chris Goller 61ca5f4efd Merge pull request #393 from influxdata/fix/390-change-alert-name
change name to alertName in alerts query
2016-11-07 15:58:47 -06:00
Jade McGough 57cfb0dae4 change name to alertName in alerts query 2016-11-07 13:50:14 -08:00
Sean Beckett fa370be042 Update README.md 2016-11-07 14:26:51 -07:00
Will Piers 299d91bc90 Fix syntax errors 2016-11-07 13:22:56 -08:00
Andrew Watkins 122bd75b64 Change all 1d to 24h 2016-11-07 13:08:04 -08:00
Andrew Watkins 4c1ae216a6 Remove more than and less than 2016-11-07 13:03:58 -08:00
Kevin Fitzpatrick ea12c46225 Merge branch 'feature/handle-empty-alert-set' 2016-11-07 12:02:14 -08:00
Jade McGough fe16ba68d9 Merge branch 'fix/horizontal-graphs' 2016-11-07 11:40:37 -08:00
Kevin Fitzpatrick 55a6bfcdda Stop displaying 'loading' when empty set of alerts 2016-11-07 11:06:23 -08:00
Nathan Haugo 4b7e6baf65 Merge pull request #383 from influxdata/docs/update_readme
Prep readme for opensourcing
2016-11-07 10:35:26 -08:00
nathan haugo ee5d12b598 Update readme from feedback 2016-11-07 10:34:56 -08:00
Chris Goller 8fe8de3de1 Merge pull request #387 from influxdata/remove-mrfusion
Remove mrfusion name from source
2016-11-07 11:33:23 -06:00
Chris Goller 0d1579e4b9 Merge pull request #386 from influxdata/update-cli-options
Update cli options
2016-11-07 11:29:05 -06:00
Chris Goller d52b094b67 Remove mrfusion name from source 2016-11-07 11:22:23 -06:00
Chris Goller 93799c289b Update Makefile to use default chronograf port 2016-11-07 11:10:47 -06:00
Chris Goller 96a135f2e4 Update cli/env options to use port 10000 and remove TLS for now 2016-11-07 11:09:51 -06:00
Kevin Fitzpatrick 883ef32569 Merge branch 'develop' 2016-11-07 09:07:55 -08:00
Chris Goller c56ac82033 Merge pull request #384 from influxdata/fix-layout-names
Fix layout names
2016-11-07 10:52:02 -06:00
Chris Goller 3e4755b45b Merge pull request #385 from influxdata/feature/update-canned-packaging
Update package canned directory
2016-11-07 10:51:53 -06:00
Ross McDonald 83b036f255 Update package canned directory. 2016-11-07 10:49:10 -06:00
Chris Goller 25d49793b2 Update apps test to have a logger 2016-11-07 10:27:35 -06:00
Chris Goller 6539839113 Update layouts to not use UUIDs in name and only use filesystem 2016-11-07 10:10:26 -06:00
Jade McGough 9cc9151724 ignore layout positions, force graphs to cascade horizontally 2016-11-07 00:07:03 -08:00
Jade McGough b111f40ce9 adjust layout row height 2016-11-06 23:17:44 -08:00
nathan haugo 9ae3e648c0 Prep readme for opensourcing 2016-11-06 21:23:57 -08:00
Nathan Haugo 648bcf6656 Merge pull request #378 from influxdata/feature/warn-on-kapacitor-connection-error
Warn when we can't ping the kapacitor
2016-11-06 12:13:03 -08:00
Jade McGough d4cfc85343 remove debugger 2016-11-05 11:20:34 -07:00
Jade McGough d88758a40f Use a single ReactGridLayout so layouts don't overlap. 2016-11-04 20:21:21 -07:00
Kevin Fitzpatrick e20cc4548c Rename Data/Explorer tabs 2016-11-04 18:39:20 -07:00
Kevin Fitzpatrick 89725fcaca Warn when we can't ping the kapacitor 2016-11-04 18:31:24 -07:00
Nathan Haugo ccd98b2b21 Merge pull request #376 from influxdata/feature/rules-index-#307
Refactor KapacitorRulePage
2016-11-04 17:30:48 -07:00
Will Piers 20b5c96e29 Refactor KapacitorRulePage to work for new and existing rules, and add new rule button 2016-11-04 16:39:19 -07:00
Kevin Fitzpatrick 39fac80ae7 Fix filtering
Also, fixes displaying mutliple alerts with the same name
2016-11-04 16:24:58 -07:00
Chris Goller 8076c5b2cf Merge pull request #372 from influxdata/fix-kapa-deadman-camels
Fix tickscript deadman output and use camelCase
2016-11-04 18:12:41 -05:00
Chris Goller c67e3cdb36 Fix tickscript deadman output and use camelCase 2016-11-04 18:07:56 -05:00
Kevin Fitzpatrick 617e08adb6 Fix filtering
Also, fixes displaying mutliple alerts with the same name
2016-11-04 15:55:19 -07:00
Chris Goller 0ab8d66e41 Merge pull request #368 from influxdata/add-kapa-relative-abs
Add relative comparison with absolutes change
2016-11-04 17:29:18 -05:00
Chris Goller 48d658fa23 Add relative comparison with absolutes change 2016-11-04 17:25:57 -05:00
Chris Goller 7fefd96e5e Merge pull request #365 from influxdata/feature/fix-kapa-percentage
Update tickscript to evaluate between [0-100] instead of [0-1]
2016-11-04 17:10:36 -05:00
Kevin Fitzpatrick f3bc379507 Change Alert -> Name in the alerts table 2016-11-04 15:07:14 -07:00
Kevin Fitzpatrick 96698f8db7 Change Alerts to Alerting 2016-11-04 15:06:12 -07:00