add test for hydrateVars
dashboard variable dropdown test: inspect values, not just array length
add RTL test for variable dropdown changes
lint
fix: Disable saving threshold check if no threshold selected (#15348)
* Prevent check saving if no thresholds
* Add tests
* Add changes to changelog
* make optional props optional
* use false instead of null for boolean
changelog
fix(ui): ignore false change events in VariableForm (#15317)
closes#15059
the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
while exploring containerization of the frontend, i decided to remove the
existing environment configuration from package.json and push them into
external files in an attempt to improve the caching strategies available
for local development. the CI pipeline should be watching the lock file,
but changes to the testing environment locally shouldn't cause a rebuild
of node_modules.
closes#15059
the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
* Add init event markers
* Add events to dashboard graphs
* Add level coloring and styling to event markers
* Window statuses by time and graph groups of events
* Put event markers behind feature flag
* init tooltip
* Upgrade giraffe library
* Add Tooltip
* Add status query to Time Machine
* Status rows return lowercase check level statuses
* rename events to statuses
* Radically improve tooltip style
Co-authored-by: alexpaxton <thealexpaxton@gmail.com>
* Add time formatting
* Make status query more readable
* Clean up comments
* refactor(ui): add vector graphic logos for each client library
* refactor(ui): replace mock content with real content
* refactor(ui): display client library content in overlays with routes
* refactor(ui): cleanup factored out components
* refactor(ui): increase size of client library overlays
* refactor(ui): make client library overlays wider
* refactor(ui): add link to docs for each client library
* refactor(ui): cleanup commented code
* refacotor(ui): split first time create check button into one for each type
* refactor(ui): replace create check button with dropdown
* refactor(ui): remove check type toggle from conditions card
* refactor(ui): split check creation into 2 routes
* refactor(ui): change default check depending on type
* refactor(ui): hide function selector when building a deadman check
* refactor(ui): move validation popover to check save button
* refactor(ui): remove unused component
* refactor(ui): ensure deadman queries do not have an aggregate function
Co-Authored-By: Deniz Kusefoglu <deniz@influxdata.com>
* refactor(ui): update alerting get started copy
* refactor(ui): update e2e test
* refactor(ui): use existing checkType type
Closes https://github.com/influxdata/influxdb/issues/15060
Previously, the create button for a variable wouldn't be enabled unless
the user clicked in the text box, despite a query being present. This
adds an aditional check to the `isFormValid` method that ensures that if
a query is present the create button will be enabled.
The previous bucket retention form component was frusterating to use.
This commit replaces it with a simple duration dropdown that we use in a
few other places. It refactors the various duration utilities to make it
happen.
The hope is to eventually improve this duration dropdown into a combined
text input/dropdown component that can accept custom durations with
validation.
The following steps would result in a server error:
1. Open create bucket overlay
2. Enter valid name
2. Click "Periodically" radio option
3. Click "Never" again
4. Submit
The issue is that the bucket was being submitted with an invaild
retention duration, even though the user had selected to use no
retention duration (by clicking "Never").
The solution was to clear the retention duration state when switching
back to the "Never" radio option.
* refactor(ui): remove action buttons from system bucket cards
* refactor(ui): make check builder more compact
* refactor(ui): add raw data toggle to check editor
* refactor(ui): fix logic for displaying system bucket label
* refactor(ui): remove edit link from system buckets
We want to display a row for each notification, but we were displaying
a row for each field for each notification.
By filtering out the system fields (those that start with an
underscore), we are in left with only a single user-specific field.
Closes https://github.com/influxdata/influxdb/issues/15042
Previously, there was an optional URL provided for the pagerduty
endpoint. However, the pagerduty API url does not change and as a result
it should not have been a parameter. The Pagerduty API does require a
`clientURL` that is presented in the pagerduty UI when an alert is
triggered. Currently that value will default to the alerts history page
for the organization.
Alex Boatwright
Bucky Schwarz
Bucky Schwarz
Andrew Watkins
Deniz Kusefoglu
Iris Scholten
Russ Savage
Lyon Hill
Michael Desa
alexpaxton
Scott Anderson
Christopher Henn
Daniel Campbell