84a713f07f
Use "value" as the field name in graphite
...
Also fix tests.
2015-05-13 09:31:20 +08:00
9a3c28748c
change timestamp to time
2015-05-11 12:28:47 -05:00
150c197bf3
Correct spelling in test titles
2015-05-05 16:56:35 -04:00
ec0acb1b77
Fix race condition when accesing Graphite listener
2015-04-25 10:00:17 -07:00
b689231183
graphite: log the field name when we encounter a value parse failure
...
The java metrics library will dump anything and everything to graphite leading to many error messages like:
[graphite] 2015/04/19 10:11:46 unable to parse data: strconv.ParseFloat: parsing "[J@4deff1ac": invalid syntax
[graphite] 2015/04/19 10:11:46 unable to parse data: strconv.ParseFloat: parsing "[J@5b8c4bb5": invalid syntax
It makes sense to include the name field given that the graphite parsing code has already validated the name and tags by the time the value is parsed.
The field name can then be used to filter the offending field from the stats publish.
The ParseFloat related error messages have been modified such they include the field name and the value that was being parsed (value|timestamp).
2015-04-21 23:16:30 -04:00
ff24d0a00e
fix race condition in graphite endpoints
2015-04-21 15:42:25 -06:00
0b1fc43f88
If Accept() fails due to a closing listener, return
...
Other types of Accept() failures should result in a retry.
2015-04-18 09:55:26 -07:00
28ffd49dfc
Use WaitGroup with UDP Graphite Close()
2015-04-17 18:50:05 -07:00
550f7bf59c
ust use Wait Groups to shutdown Graphite
2015-04-17 18:33:26 -07:00
8113b0cfd4
Also wait until connections are closed
2015-04-17 16:18:28 -07:00
3dff1b0f0b
Add WaitGroups to openTSDB and Graphite close
2015-04-17 16:18:28 -07:00
67f252d561
fix race conditions in graphite/openTSDB endoints
2015-04-17 16:18:28 -07:00
bad336a6ae
wip fixing graphite tests
2015-04-17 16:18:28 -07:00
56c58eb215
Fix swallowed error
2015-04-02 19:01:19 -07:00
c0404e577e
refactoring based on pr review
2015-03-26 14:18:40 -06:00
d653e41712
support fractional time on graphite endpoint
2015-03-26 14:18:40 -06:00
524eb78a69
graphite logs in seconds, not milliseconds
2015-03-26 14:18:40 -06:00
c461c7e7b4
Remove logging to specific file
2015-03-25 17:41:39 -07:00
a19f81d3e9
Graphite numbers are always float64
2015-03-14 09:59:33 -06:00
d82d040e59
Create databases for Graphite at higher level
...
By doing this the SeriesWriter interface stays focused and just has
methods for writing data. Its name then remains coherent.
2015-03-12 13:33:25 -07:00
f8c39d49b1
Fix minor typos in Graphite comments
2015-03-12 12:21:31 -07:00
7717b11e6b
Factor common code into Graphite package
2015-03-12 12:21:27 -07:00
4cf4f96a3a
Rename "Server" interface to "SeriesWriter"
...
Comments imply it should be this name in any event.
2015-03-12 11:55:31 -07:00
58dac30fd5
auto create database for graphite if not specified
2015-03-12 10:20:49 -06:00
2f0fe901e3
Rename "Values" to "Fields" for writes
2015-02-23 15:06:56 -08:00
19992f3ecc
gofmt -s (simplify)
2015-02-01 15:33:12 -05:00
e4604fec36
Refactoring based on PR comments
...
Changing WriteSeries to take a slice of points instead of variable
arguments
Adding godoc comment for public type Point
2015-01-13 16:26:14 -07:00
9e48da134b
change signature of WriteSeries to accept a public struct
2015-01-13 16:00:41 -07:00
30de3704c0
Fix graphite.SeriesWriter signature.
2015-01-13 07:57:13 -07:00
8c2f894fab
Integrate more code review feedback
2015-01-08 11:14:57 -08:00
9e7f6ca3f0
Provide default NameSeparator for Graphite config
2015-01-07 16:15:39 -08:00
fdc6b5b866
Export the Metric type
2015-01-07 16:09:15 -08:00
f57f28f575
Add GoDoc strings
2015-01-07 00:10:46 -08:00
aa92095f90
Graphite unit tests now pass
2015-01-06 23:51:59 -08:00
fe886e17a5
Remove more tests
...
To be replaced later.
2015-01-06 23:41:32 -08:00
eaadf0b3d3
Update unit tests so they build
...
They do not yet pass.
2015-01-06 23:36:56 -08:00
f3650b4797
Implement a distinct Graphite Parser
...
This encapsulates a few previously free-floating methods. This means
that params such as "separator" and "last-enabled" are not passed from
function to function, and also makes initialization of TCP and UDP
Servers somewhat clearer.
It also removes early use of "GraphiteProcessor".
2015-01-06 23:20:01 -08:00
1edbd816fc
Start with a processor.
2015-01-06 15:38:35 -08:00
1f264b6c2d
Refactor into distinct TCP and UDP servers
2015-01-06 15:17:29 -08:00
0334dc5b50
seperator -> separator
2015-01-06 09:57:44 -07:00
7857565e0b
clarifying a conditional
2015-01-05 21:51:04 -07:00
7b669da36c
fixing misc comments
2015-01-05 21:43:33 -07:00
a94254d1a3
Graphite endpoint updates from comments
...
Added ability to specifiy a seperator for a metric_path.
Default is "."
Added ability to specify position of name from metric_path
Options are "first" or "last".
Defaults to the first position.
Normalized the graphite.Metric struct to only have a Value.
Changes to be committed:
modified: cmd/influxd/config.go
modified: cmd/influxd/config_test.go
modified: cmd/influxd/run.go
modified: graphite/graphite.go
modified: graphite/graphite_test.go
2015-01-05 20:14:43 -07:00
b52437f00a
Initial incorporation of fixes from pull request #1276
...
Changes to be committed:
modified: cmd/influxd/config.go
modified: cmd/influxd/config_test.go
modified: cmd/influxd/run.go
renamed: graphite.go -> graphite/graphite.go
renamed: graphite_test.go -> graphite/graphite_test.go
2015-01-02 09:57:04 -06:00
Can ZHANG
ben hockey
Lance A. Brown
Philip O'Toole
Mark Guzman
Cory LaNou
Philip O'Toole
Mark Rushakoff
David Norton
Ben Johnson