Commit Graph

11082 Commits (ab031bd929c81726ae80cdf9a4b713d907eea244)

Author SHA1 Message Date
Dom 13c2633695
Merge branch 'main' into dom/soft-delete-namespaces 2023-02-09 10:37:06 +00:00
Dom Dwyer 61409f062c
refactor(catalog): soft delete namespace column
Adds a "deleted_at" column that will indicate the timestamp at which is
was marked as logically deleted.
2023-02-09 11:35:27 +01:00
Dom a66dd37c91
Merge pull request #6889 from influxdata/dom/always-requeue
fix(ingester2): always maintain persist interval
2023-02-09 10:31:35 +00:00
Dom d44b6d412f
Merge branch 'main' into dom/always-requeue 2023-02-09 10:21:32 +00:00
dependabot[bot] 4911f37fe5
chore(deps): Bump filetime from 0.2.19 to 0.2.20 (#6917)
Bumps [filetime](https://github.com/alexcrichton/filetime) from 0.2.19 to 0.2.20.
- [Release notes](https://github.com/alexcrichton/filetime/releases)
- [Commits](https://github.com/alexcrichton/filetime/compare/0.2.19...0.2.20)

---
updated-dependencies:
- dependency-name: filetime
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-09 10:13:50 +00:00
Cole Abbeduto f6ad37e719
fix: query annotations and params (#6449)
* fix: query.dialect.annotations should be a string[]

* feat: Add query.params support for use in flux queries

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-09 00:08:55 +00:00
Andrew Lamb bd2a72a4b6
test(compactor): Improve file size display in compactor tests (#6909)
* test(compactor): Improve file size display in compactor tests

* fix: try different display

* fix: update

* fix: use b to show size
2023-02-08 22:35:12 +00:00
Marco Neumann 18d5924dfd
test: allow testing the compactor w/o any real data (#6908)
* test: allow testing the compactor w/o any real data

Things that are missing:

- output files have nondeterministic IDs which interferes w/ snapshot
  testing. We should probably normalize the IDs somehow.
- time ranges of output files are not captured correctly (because the
  mock sink doesn't know how to calculate them)

* fix: Add output assertion

* fix: fmt

* docs: improve

Co-authored-by: Andrew Lamb <alamb@influxdata.com>

* fix: fmt

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2023-02-08 19:10:28 +00:00
Andrew Lamb 2f4d901fbe
chore: Update datafusion (#6893)
* chore: Update datafusion

* chore: Run cargo hakari tasks

* fix: update for api change

---------

Co-authored-by: CircleCI[bot] <circleci@influxdata.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-08 18:27:18 +00:00
Marco Neumann 43b11b8be8
fix: metric labels (#6904)
Metric labels are key-value based.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-08 18:18:56 +00:00
Marco Neumann 5e287ac8e6
refactor: make `TestSetup` immutable (#6907)
* refactor: split off file creation

* refactor: make `TestSetup` immutable
2023-02-08 13:17:15 +00:00
Marco Neumann 6f7f608685
refactor: avoid nested test modules (#6906)
Just call it `tests` and avoid nesting a module in a module.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-08 11:16:36 +00:00
dependabot[bot] 0ecde75af5
chore(deps): Bump object_store from 0.5.3 to 0.5.4 (#6900)
Bumps [object_store](https://github.com/apache/arrow-rs) from 0.5.3 to 0.5.4.
- [Release notes](https://github.com/apache/arrow-rs/releases)
- [Changelog](https://github.com/apache/arrow-rs/blob/master/CHANGELOG-old.md)
- [Commits](https://github.com/apache/arrow-rs/compare/object_store_0.5.3...object_store_0.5.4)

---
updated-dependencies:
- dependency-name: object_store
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-08 09:40:11 +00:00
Marco Neumann dcba47ab58
feat: allow the compactor to process all known partitions (#6887)
* feat: `PartitionRepo::list_ids`

* refactor: `CatalogPartitionsSource` => `CatalogToCompactPartitionsSource`

* feat: allow the compactor to process all known partitions

Closes #6648.

* docs: improve

Co-authored-by: Andrew Lamb <alamb@influxdata.com>

---------

Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2023-02-08 09:32:21 +00:00
dependabot[bot] bb825faf06
chore(deps): Bump toml from 0.7.1 to 0.7.2 (#6899)
Bumps [toml](https://github.com/toml-rs/toml) from 0.7.1 to 0.7.2.
- [Release notes](https://github.com/toml-rs/toml/releases)
- [Commits](https://github.com/toml-rs/toml/compare/toml-v0.7.1...toml-v0.7.2)

---
updated-dependencies:
- dependency-name: toml
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-08 09:11:04 +00:00
Andrew Lamb 47b47f225b
chore: add more insta snapshots for initial setup (#6894)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-07 23:44:59 +00:00
Stuart Carnie a2945a77a4
fix: Implement EXPLAIN, ORDER BY and default ordering (#6864)
* chore: Add more tests

* chore: Fix default ordering; implement ORDER BY

* feat: Add EXPLAIN support

* chore: Add additional tests to validate GROUP BY expansion

* chore: More test cases for TZ, and failing log scalar function
2023-02-07 22:18:52 +00:00
Andrew Lamb d4e07eb6ac
chore: Update target_level_upgrade_split to use insta snapshots for partition verificiation (#6892) 2023-02-07 20:36:46 +00:00
Andrew Lamb ea0fc79340
chore: Update tests in compactor2 to ue insta (#6891)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-07 19:58:43 +00:00
Nga Tran beb22f0490
Merge pull request #6880 from influxdata/ntran/c2-skip
feat: Do not skip partition based on num files and size until we reach compaction plan
2023-02-07 14:19:50 -05:00
NGA-TRAN c5025d6271 chore: merge main to branch 2023-02-07 14:04:03 -05:00
NGA-TRAN aab6ac7424 refactor: address review comments 2023-02-07 13:35:11 -05:00
Nga Tran 76172daf39
feat: to prevent OOMs/crrash that will lead to skip compaction, let us compact L1 files when they are large enough (#6877)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-07 17:46:44 +00:00
Dom Dwyer 776ec41384
fix(ingester2): always maintain persist interval
This fixes an issue where persistence that does not ever complete blocks
the periodic enqueuing of persist tasks - this leads to the amount of
buffered data in the buffer tree increasing, and the persist queue depth
stays the same instead of draining the buffer.

This is an issue as the queue depth is designed to act as the
back-pressure of the ingester - once the depth exceeds a configurable
limit, further writes are rejected until the queue has drained
sufficiently (50%).

After this commit, stalled persistence (i.e. object store outage) will
not prevent the queue depth from growing, which should enable the
saturation protection to kick in.
2023-02-07 17:48:07 +01:00
NGA-TRAN db51d77eb8 docs: even more detailed info about skipped partitions 2023-02-07 10:13:58 -05:00
Andrew Lamb f56023b222
feat: use insta_snapshots (#6884)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-07 15:08:47 +00:00
Dom Dwyer 4ffd7fcc68
test: persist timer & wal rotation
Adds a unit test covering WAL rotation, buffer persistence & WAL file
deletion.
2023-02-07 15:52:11 +01:00
Nga Tran 6297ad206f
Merge branch 'main' into ntran/c2-skip 2023-02-07 09:38:23 -05:00
NGA-TRAN 646349c52d docs: addd comments to explain further the skip 2023-02-07 09:34:40 -05:00
Marco Neumann 997cca67a3
fix: `--compaction-process-once` should exit (#6886)
- do not wait for a non-empty partition result (this doesn't make sense
  if we are not running endlessly)
- modify entry point to allow the compactor to exit on its own (this is
  normally not allowed for other server types)
2023-02-07 13:52:17 +00:00
Marco Neumann e179887ede
fix: metric buckets (#6883) 2023-02-07 12:07:45 +00:00
Marco Neumann 3a4364b8f8
fix: partition-done metrics/logs (#6882)
Ignore partitions that where throttled or filtered due to the "not
unique" combo.

This is in line w/ the "partitions source", so the metric for "partition
in" and "partition out" line up.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-07 11:01:33 +00:00
Andrew Lamb 65e7ff779c
feat: verified test output display for compactor (#6859)
* feat: verified test output display for compactor

* fix: demacrofy assert_parquet_files

* fix: demacrofiy assert_parquet_files_split

* refactor: compute min/max without sentinels

* fix: clippy

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-07 10:49:38 +00:00
Dom 25e1c9d7fa
Merge pull request #6873 from influxdata/dom/cache-table-limit
perf(router): cheap table limit enforcement + better errors
2023-02-07 10:13:05 +00:00
Dom 9e8785f9c1
Merge branch 'main' into dom/cache-table-limit 2023-02-07 10:04:50 +00:00
NGA-TRAN 6ec44d697a chore: cleanup 2023-02-06 21:41:35 -05:00
NGA-TRAN 24ebd923a2 chore: Merge branch 'ntran/c2-skip' of https://github.com/influxdata/influxdb_iox into ntran/c2-skip 2023-02-06 21:39:24 -05:00
NGA-TRAN 56ca3186b6 chore: turn test assert on 2023-02-06 21:39:17 -05:00
Nga Tran bce7dba856
Merge branch 'main' into ntran/c2-skip 2023-02-06 21:35:20 -05:00
NGA-TRAN 32715595bb chore: cleanup 2023-02-06 21:32:06 -05:00
NGA-TRAN bdf3e32dcd test: tests for partition filters of resource limit 2023-02-06 21:26:45 -05:00
Christopher M. Wolff a79b4ec899
refactor: better validation of gap filling queries (#6875)
* refactor: propagate origin argument to gap fill operator

* refactor: add param expressions to from_template

* chore: add more validation for gap fill queries

* feat: extract stride, first and last from gap fill params

* chore: clippy

* refactor: code review feedback

* chore: update for changed result type

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-06 23:36:26 +00:00
Stuart Carnie eb245d6774
feat: Initial SQLite catalog schema (#6851)
* feat: Initial SQLite catalog schema

* chore: Run cargo hakari tasks

* feat: impls, many TODOs

* feat: completed `todo!()`'s

* chore: add remaining tests from postgres module

* feat: add SQLite to get_catalog API

* chore: Add docs

* chore: Placate clippy

* chore: Placate clippy

* chore: PR feedback from @domodwyer

---------

Co-authored-by: CircleCI[bot] <circleci@influxdata.com>
2023-02-06 22:55:14 +00:00
NGA-TRAN 9f2fecde90 feat: first step to skip partition until we know what files to compact 2023-02-06 17:30:15 -05:00
Andrew Lamb 452b69cd2c
docs(compactor): Update comments about what `PartitionFilter` does (#6878)
* docs(compactor): Update comments about what `PartitionFilter` does

* fix: Update compactor2/src/components/partition_filter/mod.rs

* fix: fmt

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-06 21:44:32 +00:00
Andrew Lamb 50514a91ff
refactor: reduce duplication for compactor_tests (#6879) 2023-02-06 21:08:12 +00:00
Andrew Lamb ec42aa0ba9
refactor: Consolidate end to end normalization code (#6848) 2023-02-06 19:47:14 +00:00
Carol (Nichols || Goulding) f1f475d552
fix: Remove compactor generate (#6872)
This debugging tool was more useful in previous situations where it was
harder to get real data as input for the compactor.

It's currently causing a flaky test that isn't worth investigating.

Fixes #6190 by making it moot.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2023-02-06 19:19:15 +00:00
Andrew Lamb 0c6b685ee1
refactor: add / cleanup some comments in compactor2 (#6853)
* refactor: add / cleanup some comments in compactor2

* fix: clarify comments after talking Nga

* fix: Update comments
2023-02-06 19:11:10 +00:00
Nga Tran 8689017f8f
chore: debug info (#6874)
* chore: debug info

* chore: Apply suggestions from code review
2023-02-06 18:16:33 +00:00