1. Removing dashboard changes from earlier commit
2. Changing inital state variable name to just be endpoint
3. moving dispatch in check actions
4. Adding notification to endpoints
These are the final tests and rule fix for this issue.
The checks is special in how it was fixed.
But endpoints and rules have the exact same fix on them
All the tests are running smoothly
EsLint was run so this branch should no longer fail from that as well.
1. We fixed the endpoints so it no longer routes to 404 page, instead now routes to the alerting index. When endpoint id does not exist.
2.Added Cypress test to confirm the routing works on checks. Routing the user to the index page when the checks id does not exist.
this fix allows the DI of the vault service configuration. There are place
where we'd like to adminster this with flags, but are locked into
the default env var setup we had previously. One other note is that
calling api.DefaultConfig() calls the ReadEnvironment() method already,
so that was dropped.
hopefully this commit doesnt do anything, but it opens up the ability to
change the static folder of the project through the environment variable
STATIC_FOLDER so that we can cache static files and not cache the index
file (allowing more passive deployment strategies), and allows the user
to change the base path of the project with the BASE_PATH variable,
opening up the ability to run an instance behind an nginx proxy,
though that change is pending an update to the @influxdata/oats package
before we can turn it on
* feat(task): Allow tasks to run more isolated from other task systems
To allow the task internal system to be used for user created tasks as well
as checks, notification and other future additions we needed to take 2 actions:
1 - We need to use type as a first class citizen, meaning that task's have a type
and each system that will be creating tasks will set the task type through the api.
This is a change to the previous assumption that any user could set task types. This change
will allow us to have other service's white label the task service for their own purposes and not
have to worry about colissions between the types.
2 - We needed to allow other systems to add data specific to the problem they are trying to solve.
For this purpose adding a `metadata` field to the internal task system which should allow other systems to
use the task service.
These changes will allow us in the future to allow for the current check's and notifications implementations
to create a task with meta data instead of creating a check object and a task object in the database.
By allowing this new behavior checks, notifications, and user task's can all follow the same pattern:
Field an api request in a system specific http endpoint, use a small translation to the `TaskService` function call,
translate the results to what the api expects for this system, and return results.
* fix(task): undo additional check for ownerID because check is not ready
The QueryServiceProxyBridge would not check for errors properly because
it would return any error encountered when running the query as a read
error on the `io.Reader`. This made it so that the csv decoder could not
identify if the error was related to the query or if it was related to
reading. The csv decoder needed to tell the difference because an error
with reading from the `io.Reader` needs to be returned as a decoder
error while an error from the query needs to be returned as-is.
Instead of adapting the csv decoder to do that, we instead lazily
initialize the result iterator when `More()` is called and call `Peek()`
on the reader. If no bytes can be read, we assume this was an error
while executing the query and return it as such. If we are able to read
at least one byte, we decode it through the csv decoder.
add test for hydrateVars
dashboard variable dropdown test: inspect values, not just array length
add RTL test for variable dropdown changes
lint
fix: Disable saving threshold check if no threshold selected (#15348)
* Prevent check saving if no thresholds
* Add tests
* Add changes to changelog
* make optional props optional
* use false instead of null for boolean
changelog
fix(ui): ignore false change events in VariableForm (#15317)
closes#15059
the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
while exploring containerization of the frontend, i decided to remove the
existing environment configuration from package.json and push them into
external files in an attempt to improve the caching strategies available
for local development. the CI pipeline should be watching the lock file,
but changes to the testing environment locally shouldn't cause a rebuild
of node_modules.
closes#15059
the issue is to persist user data across variable type selection interfaces within the variable editor. this commit pushes all of the variable editor information down to redux to allow persistence outside of the view state until the user clicks "cancel" or "create" in the interface.
j. Emrys Landivar (docmerlin)
Lyon Hill
Zoe Steinkamp
Johnny Steenbergen
Johnny Steenbergen
Alex Boatwright
alexpaxton
Deniz Kusefoglu
Jakub Bednář
Alirie Gray
kelwang
Kelvin Wang
Jonathan A. Sternberg
Edd Robinson
Bucky Schwarz
Bucky Schwarz
Andrew Watkins
Ilya Sevostyanov
Edd Robinson
Iris Scholten