Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
5,388 Commits
205 Branches
453 Tags
382 MiB
Commit Graph

9 Commits (a73d08267c8868bff7817a79521225cac32bc1c8)

Author SHA1 Message Date
Jason Wilder 2e5db51441 Fix data race w/ stopping admin server 
WARNING: DATA RACE
Write by goroutine 9:
  github.com/influxdb/influxdb/admin.func·001()
      /home/ubuntu/.go_project/src/github.com/influxdb/influxdb/admin/admin.go:45 +0x18d

Previous read by goroutine 7:
  github.com/influxdb/influxdb/admin.(*Server).ListenAndServe()
      /home/ubuntu/.go_project/src/github.com/influxdb/influxdb/admin/admin.go:50 +0x3b4
  github.com/influxdb/influxdb/admin_test.func·001()
      /home/ubuntu/.go_project/src/github.com/influxdb/influxdb/admin/admin_test.go:13 +0x4a

Goroutine 9 (running) created at:
  github.com/influxdb/influxdb/admin.(*Server).ListenAndServe()
      /home/ubuntu/.go_project/src/github.com/influxdb/influxdb/admin/admin.go:49 +0x3a4
  github.com/influxdb/influxdb/admin_test.func·001()
      /home/ubuntu/.go_project/src/github.com/influxdb/influxdb/admin/admin_test.go:13 +0x4a

Goroutine 7 (finished) created at:
  github.com/influxdb/influxdb/admin_test.Test_ServesIndexByDefault()
      /home/ubuntu/.go_project/src/github.com/influxdb/influxdb/admin/admin_test.go:13 +0x1af
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:447 +0x133
 2015-04-09 20:51:46 -06:00
Jason Wilder 1494f70786 Close admin server when stopping the node 2015-04-09 20:51:40 -06:00
Julius Volz c919240d93 Fix all lint errors in "admin" and "collectd" packages. 
admin/admin.go:10:2: a blank import should be only in a main or test package, or have a comment justifying it
    admin/admin.go:13:6: exported type Server should have comment or be unexported
    admin/admin.go:19:1: comment on exported function NewServer should be of the form "NewServer ..."
    admin/admin.go:24:1: exported method Server.ListenAndServe should have comment or be unexported
    admin/admin.go:44:1: exported method Server.Close should have comment or be unexported

    collectd/collectd.go:23:6: exported type Server should have comment or be unexported
    collectd/collectd.go:35:1: exported function NewServer should have comment or be unexported
    collectd/collectd.go:46:1: exported function ListenAndServe should have comment or be unexported
    collectd/collectd.go:145:1: exported function Unmarshal should have comment or be unexported
 2015-04-01 03:37:31 +02:00
Todd Persen c0f49e0832 Don't try to close the admin interface if it never starts up. 2015-02-12 22:52:40 -08:00
Todd Persen 4fd6e3707f Some name cleanup and making the admin test not crappy. 2015-02-11 15:48:04 -08:00
Todd Persen 8bb95cb151 Stop setting up the listener on an error. 2015-02-10 23:31:08 -08:00
Todd Persen 7573a9d781 For now, let's not worry if port binding fails. 2015-02-10 23:22:44 -08:00
Todd Persen dc515e7ee0 self => s 2015-02-10 23:17:05 -08:00
Todd Persen 631f2946ff Serve static admin assets. 2015-02-10 23:04:19 -08:00