Commit Graph

654 Commits (75fe1217e09f2bb52968dc3c04ad13e73c382c93)

Author SHA1 Message Date
alamb 9c11ae9869 feat: improve error messages and logging 2020-06-30 12:46:54 -04:00
alamb 8be278aadd fix: speed up end-to-end test harness so it polls rather than waits 2020-06-30 12:21:25 -04:00
alamb dc8d655486 feat: Implement CapabilitiesResponse 2020-06-30 11:17:45 -04:00
Andrew Lamb 97a5eb7e19
Merge pull request #197 from influxdata/alamb/log-requests
feat: Log gRPC calls using trace crate, allow custom log levels
2020-06-30 10:47:11 -04:00
Andrew Lamb 07e61cdf06
fix: fix comments
Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
2020-06-29 16:35:07 -04:00
Jake Goulding fef300e007
Merge pull request #196 from influxdata/file-object-store 2020-06-29 12:07:29 -04:00
Carol (Nichols || Goulding) 7d42a1db83
Merge pull request #198 from influxdata/cn/use-more-clap 2020-06-29 11:36:17 -04:00
Carol (Nichols || Goulding) 2bf9037422 refactor: Use built-in clap functionality that uses FromStr to enum
Then we can pass around an enum value and not worry about doing the
conversion anywhere else.
2020-06-29 10:54:48 -04:00
Carol (Nichols || Goulding) a07bf1c67c refactor: Change enum variant names to be PascalCase
This is general Rust convention for enum variant names.
2020-06-29 10:54:08 -04:00
Carol (Nichols || Goulding) c6f2508abe fix: Use clap's possible_values method
This gets us built-in help text and error messages, and does less work
before failing because of an unsupported value.

Before this change, the help text was:

```
OPTIONS:
        --compression-level <compression_level>
            Compression level: max or compatibility (default). [default: compatibility]
```

After this change, the help text is:

```
OPTIONS:
        --compression-level <compression_level>
            How much to compress the output data. 'max' compresses the most; 'compatibility' compresses in a manner more
            likely to be readable by other tools. [default: compatibility]  [possible values: max, compatibility]
```

Before this change, if you supplied an unsupported value, the error was:

```
[2020-06-29T14:47:42Z INFO  delorean::commands::convert] convert starting
[2020-06-29T14:47:42Z INFO  delorean::commands::convert] Preparing to convert 591 bytes from tests/fixtures/lineproto/temperature.lp
Conversion failed: Error creating a parquet table writer Unknown compression level 'foo'. Valid options 'max' or 'compatibility'
```

After this change, the error is:

```
error: 'foo' isn't a valid value for '--compression-level <compression_level>'
	[possible values: compatibility, max]
```
2020-06-29 10:53:01 -04:00
Andrew Lamb 724a4edcbf
Merge pull request #194 from influxdata/alamb/fix-parquet-decoding
fix: add --compression-level option for parquet decoding compatibility
2020-06-29 10:31:10 -04:00
alamb 6aa37dd7fe fix: clippy 2020-06-29 10:25:43 -04:00
alamb 5fe022366b fix: Use std::str::FromStr and add -c 2020-06-29 10:25:43 -04:00
Andrew Lamb 830bac2e64 fix: avoid string construction on error
Co-authored-by: Jake Goulding <jake.goulding@integer32.com>
2020-06-29 10:25:43 -04:00
alamb c35b0e835c fix: clippy 2020-06-29 10:25:43 -04:00
alamb e8a0233b09 feat: add configurable compression level 2020-06-29 10:25:43 -04:00
Andrew Lamb 430d6f5fe8
Merge pull request #195 from influxdata/alamb/fixture-consolidation
refactor: move benchmark test data to tests/fixtures
2020-06-29 10:12:57 -04:00
alamb 283d6691c6 feat: enable rpc debug tracing, tweaked logging levels, respect RUST_FMT env var 2020-06-29 09:59:22 -04:00
Jake Goulding ad1e3d04bb feat: Add a local filesystem implementation of the object store 2020-06-29 08:48:48 -04:00
Jake Goulding bae67cf43a refactor: Use InternalResult on the implementations of `get` streams 2020-06-29 08:48:48 -04:00
Jake Goulding f2003fbf78 refactor: Use std::io to shorten lines 2020-06-29 08:48:48 -04:00
Jake Goulding 00805a0225 refactor: Use enum variants to shorten matches 2020-06-29 08:48:48 -04:00
alamb 511d2b6436 refactor: move benchmark test data to tests/fixtures 2020-06-26 17:41:37 -04:00
Jake Goulding 99549953d6
Merge pull request #193 from influxdata/idiomatic-snafu 2020-06-26 16:35:23 -04:00
Jake Goulding 672afa1195 refactor: Merge unknown and missing extension errors 2020-06-26 16:07:35 -04:00
Jake Goulding aca63b68b2 refactor: Use more unique errors for the commands 2020-06-26 16:01:59 -04:00
Carol (Nichols || Goulding) 7f838efd80
Merge pull request #187 from influxdata/cn-bool-enc 2020-06-26 15:45:42 -04:00
Jake Goulding f5d73ee580
Merge pull request #173 from influxdata/idiomatic-snafu 2020-06-26 14:22:42 -04:00
Jake Goulding 020d56e021 refactor: use SNAFU more idiomatically in delorean_parquet 2020-06-26 13:26:51 -04:00
Jake Goulding bca4d00716 refactor: use SNAFU more idiomatically in command modules 2020-06-26 13:26:51 -04:00
Jake Goulding eeb5b4a33a chore: Add public constructors for delorean_table::Error 2020-06-26 13:26:51 -04:00
Jake Goulding b72767b695 refactor: use SNAFU more idiomatically in delorean_ingest 2020-06-26 13:26:51 -04:00
Jake Goulding a169a80f33 refactor: No need to return &String 2020-06-26 13:12:19 -04:00
Jake Goulding fdf44d2745 refactor: Support converting EscapedStr into a String 2020-06-26 13:12:19 -04:00
Carol (Nichols || Goulding) 8888f11826
Merge pull request #192 from influxdata/cn-docker-cleanup
refactor: Don't install rust and clippy twice
2020-06-26 13:05:41 -04:00
Carol (Nichols || Goulding) 1d86876bb3 refactor: Don't install rust and clippy twice 2020-06-26 11:45:41 -04:00
Carol (Nichols || Goulding) a2888dbbb2 refactor: Use cmp::min instead of an if 2020-06-26 10:36:27 -04:00
Carol (Nichols || Goulding) 201f7bef41 fix: Add an assertion for the boolean encoder format bit 2020-06-26 10:36:27 -04:00
Carol (Nichols || Goulding) a56957944c refactor: Use a constant value instead of calculating 1 2020-06-26 10:36:27 -04:00
Carol (Nichols || Goulding) 9ef07cac14 feat: Implement boolean encoding
Fixes #149.
2020-06-26 10:36:27 -04:00
Andrew Lamb 463297e8f1
Merge pull request #191 from influxdata/alamb/refactor-rename-timestamp
fix: rename timestamp column "timestamp" -> "time" to be consistent
2020-06-26 09:33:55 -04:00
alamb d4a2cf1bd8 fix: rename timestamp column "timestamp" -> "time" to be consistent 2020-06-26 08:26:16 -04:00
Edd Robinson 18128a72c7
Merge pull request #188 from influxdata/er/tsm-parquet-fix
fix: ensure all rows are returned for all columns
2020-06-26 12:16:48 +01:00
Edd Robinson d15256e0e7 refactor: address PR feedback 2020-06-26 12:08:42 +01:00
Edd Robinson 99268f5260 test: add coverage for converting tsm file 2020-06-26 11:50:37 +01:00
Edd Robinson 9d889828c3 fix: ensure all rows are emitted for each column 2020-06-26 11:50:37 +01:00
Andrew Lamb 305b919bac feat: benchmark for lp->parquet performance (#176) 2020-06-26 11:50:37 +01:00
Carol (Nichols || Goulding) efbff0e5ef
Merge pull request #189 from influxdata/moar-clippy 2020-06-25 10:50:15 -04:00
Carol (Nichols || Goulding) 4df99f1a7c style: Enable the clippy warning to use `Self` when recommended
Fixes #158.
2020-06-25 07:38:58 -04:00
Carol (Nichols || Goulding) afcd1efd1e style: Unify lints everywhere
Then fix the failures, mostly by adding derives and then removing some
unneeded (cheap) clones.

Document places where we purposefully don't use the same lints.

Not unifying missing_docs.

👀 https://github.com/rust-lang/cargo/issues/5034
2020-06-25 07:28:42 -04:00