Commit Graph

706 Commits (5e256f3722703778c8e4bdf80837cdbcfe9baf42)

Author SHA1 Message Date
Jake Goulding 40614bcf87 refactor: Extract function to convert the parsed line into a value 2020-03-11 22:43:09 -04:00
Jake Goulding f5305fd468 feat: Ensure tags are sorted in the line parser 2020-03-11 22:43:07 -04:00
Carol (Nichols || Goulding) 093e1e960f
Merge pull request #50 from influxdata/line-parser
refactor: Rewrite the line parser with nom
2020-03-06 10:14:01 -05:00
Jake Goulding 78a53aa391 refactor: Replace the hand-written parser with one built with nom 2020-03-06 10:00:29 -05:00
Jake Goulding d5d00071e0 test: Ensure the line protocol parser includes the tag set in the series 2020-03-06 09:51:43 -05:00
Jake Goulding db7bb94450 test: Split tests apart to provide better feedback 2020-03-06 09:51:43 -05:00
Jake Goulding 5972381ad2
Merge pull request #51 from influxdata/remove-failure
refactor: Remove unused failure crate
2020-03-02 08:34:10 -05:00
Jake Goulding 5d3f99da98 refactor: Remove unused failure crate 2020-02-28 16:54:28 -05:00
Jake Goulding 8666edb208
Merge pull request #49 from influxdata/unused-import
style: Remove unused import
2020-02-28 11:35:58 -05:00
Jake Goulding a1cbe4235f style: Remove unused import 2020-02-28 09:41:51 -05:00
Edd Robinson bfe17259f1
Merge pull request #21 from influxdata/er-encoder-bench
test: add encoder/decoder benchmarks
2020-02-28 13:05:00 +00:00
Edd Robinson 17051717e2 chore: remove dependency: 2020-02-28 12:55:28 +00:00
Edd Robinson c2b49a7804 refactor: please clippy 2020-02-27 19:41:55 +00:00
Edd Robinson 01fcff539f chore: kick CI 2020-02-27 15:56:51 +00:00
Edd Robinson 38f23ac07a refactor: merge master in 2020-02-27 14:27:23 +00:00
Carol (Nichols || Goulding) f155e64723
Merge pull request #41 from influxdata/cn-storage-grpc-api
feature: Implementing the storage gRPC API except for read group
2020-02-26 16:33:55 -05:00
Carol (Nichols || Goulding) 54a66c14c8 feature: Implement read filter request 2020-02-26 09:51:02 -05:00
Carol (Nichols || Goulding) 7cac8cc10c feature: Implement tag values request 2020-02-26 09:51:02 -05:00
Carol (Nichols || Goulding) 2a4d2fe52d feature: Implement tag keys request 2020-02-26 09:51:02 -05:00
Carol (Nichols || Goulding) 1cd270fdea feature: Add a trait for common parsing of gRPC inputs 2020-02-26 09:01:57 -05:00
Carol (Nichols || Goulding) a6cb0cd8a9 feature: Hook up Storage gRPC trait with requests unimplemented 2020-02-26 08:55:25 -05:00
Carol (Nichols || Goulding) 1f59ead622 feature: Parse SeriesFilter keys to create Tags 2020-02-26 08:48:49 -05:00
Carol (Nichols || Goulding) 5bd9015ca1 feature: Connect tag keys and tag value methods through Database 2020-02-26 08:47:11 -05:00
Carol (Nichols || Goulding) eaea52edc9 feature: Implement a mapping of bucket ID to bucket 2020-02-26 08:45:21 -05:00
Carol (Nichols || Goulding) 12582af08a feature: Add Send constraint to returned iterators 2020-02-26 08:43:43 -05:00
Carol (Nichols || Goulding) 8b48503d10 refactor: Move RPC code to its own module 2020-02-26 08:38:45 -05:00
Carol (Nichols || Goulding) 898e7458e3 refactor: Use TimestampRange from proto rather than Range 2020-02-26 08:38:38 -05:00
Carol (Nichols || Goulding) c41652e45b feature: Add the storage gRPC proto definitions 2020-02-24 08:26:28 -05:00
Carol (Nichols || Goulding) 6ec6f282f9
Merge pull request #46 from influxdata/unify-predicate
refactor: unify predicate evaluation between RocksDB and in-memory
2020-02-24 08:21:05 -05:00
Jake Goulding ff9085a096 refactor: No need to accept an explicit lock guard 2020-02-21 14:46:00 -05:00
Jake Goulding efefe9eb9a refactor: unify predicate evaluation between RocksDB and in-memory 2020-02-21 14:45:54 -05:00
Jake Goulding 284652ff22
Merge pull request #44 from influxdata/simplify-optional
refactor: simplify optionally finding the bucket
2020-02-21 11:49:42 -05:00
Jake Goulding 2d95595681 refactor: simplify optionally finding the bucket 2020-02-21 11:44:50 -05:00
Jake Goulding 98c10de980
Merge pull request #45 from influxdata/raw-strings
refactor: use raw strings instead of escape sequences
2020-02-21 11:43:32 -05:00
Jake Goulding c0b93d7b78
Merge pull request #43 from influxdata/unneeded-string
refactor: Remove unneeded String allocation
2020-02-21 11:43:21 -05:00
Jake Goulding 3a8213cefb
Merge pull request #42 from influxdata/no-require-vec
refactor: Prefer mutable slices over a mutable Vec
2020-02-21 11:43:11 -05:00
Jake Goulding c85f4b45ed refactor: use raw strings instead of escape sequences 2020-02-21 09:55:18 -05:00
Jake Goulding 07b65e32d5 refactor: Remove unneeded String allocation 2020-02-21 09:33:11 -05:00
Jake Goulding 7620adfc70 refactor: Prefer mutable slices over a mutable Vec
We never add anything to the collection, so don't allow for the
possibility.
2020-02-21 09:02:19 -05:00
Carol (Nichols || Goulding) 3afb2c6c70
Merge pull request #35 from influxdata/cn-modrs
refactor: Use the newer style of module file naming scheme
2020-02-19 08:46:44 -05:00
Carol (Nichols || Goulding) 998537da0f refactor: Use the newer style of module file naming scheme
This cuts down on the number of mod.rs files open in your text editor at
the same time.
2020-02-19 08:43:06 -05:00
Carol (Nichols || Goulding) 3a6356b0c6
Merge pull request #40 from influxdata/all-clippy
More clippy
2020-02-19 08:42:50 -05:00
Carol (Nichols || Goulding) cb62590582 style: Warn on unnecessary use of iter and fix all cases
This is more idiomatic than calling `iter` explicitly.
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) c7a7dde51f fix: Remove redundant clones in tests
As suggested by the redundant_clone clippy lint.

This is a little weird because different constructions of `points`
now need clones in different places, but rustc will tell us when
we need to clone and clippy will tell us when we don't.
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) 196b364a00 fix: Assert on an expected error rather than failing if we get Ok
The clippy lints assertions_on_constants and single_match were pointing
at this spot, so it's as good a time as any to take care of the TODO!
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) cdca82fee5 fix: Remove an unnecessary conversion
As found by the identity_conversion clippy lint. Clippy was warning
about this on master, but warnings didn't fail the build until a commit
I'm adding in this PR.
2020-02-19 08:37:39 -05:00
Carol (Nichols || Goulding) 41ddab1a54 fix: Change an arbitrary test input so that clippy doesn't think it looks like pi
I don't think we actually want to use a precise value for pi, but if we
put 3.14, the approx_constant clippy lint will suggest it.
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) eabf96a0d7 fix: Test that floats are approximately equal within machine epsilon
As found by the float_cmp clippy lint.

There are crates that provide macros for this, but it's small enough
that I think a test helper function in-tree is fine.
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) c6eda3a8b5 fix: Allow excessive precision for now
The way these tests are written, any truncation will be made on both the
values used in the test and the values expected in the test, so this is
probably fine.

But we might not be testing with the exact values we think we're testing
with, so we should audit the values clippy warns about at some point.
2020-02-19 08:37:11 -05:00
Carol (Nichols || Goulding) 7cc871b305 style: Parenthesize potentially confusing expression
As suggested by the clippy precedence lint
2020-02-19 08:37:11 -05:00