Commit Graph

11 Commits (5bc1d755a9c090f8629d88580bd08a40d3ac5e9e)

Author SHA1 Message Date
Jacob Marble af2d26584a
chore(tracing): LogError handles nil; remove Jaeger from test (#14260) 2019-07-03 16:43:07 -07:00
Jacob Marble f56c42794b
chore(tracing): Cleanup (#13296)
* chore(tracing): Cleanup

* broken test

* fix unused var

* fix test
2019-04-10 19:28:21 -07:00
Jacob Marble 37e581694b
fix: Use simple function name for tracing operation name (#12586)
* fix: Use simple function name for tracing operation name

Every span has an operation name, which shows up in multiple places in
the Jaeger UI. Verbose function names like
`github.com/influxdata/influxdb/kit/tracing.StartSpanFromContext`
are not readable in this UI. Shorter function names like
`StartSpanFromContext` improve UX. Context is not lost because (1) the
filename and line number are logged with the span and (2) spans are
understood in the context of other spans, marked with service name and
operation name.

Extra cost is ~22 ns per call to StartSpanFromContext. No additional
memory is allocated.

* goimports

* slice more than function name as span operatio name
2019-03-13 11:49:32 -07:00
Jacob Marble 5e9a74f46d add benchmarks to demonstrate performance composition 2019-03-07 22:34:31 -08:00
Stuart Carnie b98a8fed0b
perf(tracing): Use alternate runtime APIs to reduce allocs / cpu
```
benchmark                                                      old ns/op     new ns/op     delta
BenchmarkLocal_StartSpanFromContext-8                          1382          718           -48.05%

benchmark                                       old allocs     new allocs     delta
BenchmarkLocal_StartSpanFromContext-8           6              4              -33.33%

benchmark                                       old bytes     new bytes     delta
BenchmarkLocal_StartSpanFromContext-8           376           224           -40.43%
```
2019-03-07 18:28:57 -07:00
Jacob Marble 2d740fc1ce panic on nil context 2019-03-07 12:12:31 -07:00
Jacob Marble 603a1f26e0 use tracing.StartSpanFromContext 2019-03-07 12:12:31 -07:00
Jacob Marble 8d146db9ad commit to using runtime.Caller and added tests 2019-03-07 12:12:31 -07:00
Jacob Marble 742c5fd166 godoc formatting 2019-03-07 12:12:31 -07:00
Jacob Marble 9541e861a3 goimports -w -local github.com/influxdata/influxdb 2019-03-07 12:12:31 -07:00
Jacob Marble 92fa813c45 add spans to multiple services 2019-03-07 12:12:31 -07:00