We would like to add additional user-configurable options to the display
of axes on Dashboards. This adds three fields to expand settings that
the frontend can persist through the API.
One field of interest here is the "Base" field which controls when and
how axes transition the display of values such as bytes, kilobytes,
megabytes, etc. By default, it's returned from the API as "10" to
indicate decimal, but can be set to anything the frontend wishes--the
immediate differing value will be "2" for the aforementioned use case.
This logic was originally left in place to help future test writers, but
its presence was vexing because it was not exercised in existing test
cases. It has been commented out should future tests need to leverage
it.
The option generator goroutine and the task fetcher goroutine are more
readable when extracted into another method. Also, added some commenting
documenting what their expectations are
This ensures that setup time does not impact the results of the
benchmark since profiling showed that much time was spent setting up the
test array of tasks. This also uses `make` to build that slice instead.
Also, the tests revealed that there was a bug where offsets were
pre-incremented rather than post-incremented, omitting the first 100
results.
Because we were testing the mock client, and not the paginating
kapacitor client for the case where limit and offset were provided, an
issue with that code path was not exposed.
The issues exposed were that the condition was incorrect for triggering
this behavior, and no return clause was present to prevent the remainder
of the ListTasks method from running.
- Largely mimicking the pattern featured in Dropzone.js (I feel this is
a great pattern for file drag & drop)
- Got rid of the button for uploading, change copy to read “Drop a file
here or click to upload”
- Made entire file upload div clickable
- After a file has been uploaded:
- Submit button has been moved inside the div
- Added a “Cancel” button and method to reset the state of the modal
- Hover state of clickable area matches drag-over state
Jared Scheib
Nathan Haugo
Hunter Trujillo
Tim Raymond
Timothy J. Raymond
Alex Paxton
Alex P
Andrew Watkins