Commit Graph

5266 Commits (1718b55283a5abcbe00b460f975ca69087e9ad50)

Author SHA1 Message Date
Carol (Nichols || Goulding) ae7d893199 feat: Add UUID to databases
Connects to #2675.

When a database is created, assign it a UUID and serialize the UUID to
object storage by wrapping the database rules in a new
`PersistedDatabaseRules` type that also contains the UUID.

All APIs to the end user involving rules should continue using only
`DatabaseRules` so the UUID is an internal implementation detail.
2021-10-07 10:19:14 -04:00
Raphael Taylor-Davies d4bc33b921
refactor: use RWLock instead of TaskTracker for query exec shutdown (#2761) 2021-10-07 14:18:40 +00:00
Carol (Nichols || Goulding) 27e7a1f925 refactor: Organize use statements 2021-10-07 10:17:19 -04:00
Andrew Lamb 0b4fd01d04
fix: Cast count aggregates correctly (#2756)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-07 10:49:15 +00:00
Marco Neumann 81c75eec7e fix: interaction of preservation and delete predicates
This is the second part of #2627.
2021-10-07 11:38:09 +02:00
Marco Neumann 57b3be3b2d fix: interaction of compaction and delete predicates
- predicates that existed before the compaction can be forgotten since
  they are materialized during compaction
- predicates that are added while the compaction is running must be
  included into the new chunk

This is the first half of #2627.
2021-10-07 11:24:58 +02:00
kodiakhq[bot] be60b6c473
Merge pull request #2757 from influxdata/crepererum/issue2748
fix: flaky `delete_predicate_preservation`
2021-10-07 09:12:16 +00:00
kodiakhq[bot] 7d6be3f500
Merge branch 'main' into crepererum/issue2748 2021-10-07 09:04:18 +00:00
Raphael Taylor-Davies fb9119fa4c
feat: remove serde from data types (#2652) 2021-10-07 08:58:06 +00:00
kodiakhq[bot] 4c708ab784
Merge pull request #2747 from influxdata/crepererum/chunk_id_uuid
refactor: make `ChunkId` a UUID
2021-10-07 08:39:39 +00:00
Marco Neumann 8b06d72a58 fix: address review comments 2021-10-07 10:24:19 +02:00
Marco Neumann 63d74be490 refactor: make `ChunkId` a UUID 2021-10-07 10:23:27 +02:00
Marco Neumann 0374ba2284 fix: re-enable no longer flaky part of `delete_predicate_preservation`
Fix #2748.
2021-10-07 10:15:49 +02:00
Marco Neumann 2a52fd90d9 fix: transaction pruning logic for "nothing to do" 2021-10-07 10:14:42 +02:00
Nga Tran de148337e8 fix: half way fix the bug to inlcude schema of column in delete predicate into the schema of IOx scan to avoid missing reading columns 2021-10-06 17:43:48 -04:00
Andrew Lamb efa2316626
fix: do not sort the output of read_group with no group keys (#2755) 2021-10-06 18:59:58 +00:00
Raphael Taylor-Davies 39157828b1
feat: remove remaining usages of Instant (#2722) (#2749)
* feat: remove remaining usages of Instant (#2722)

* chore: review feedback

Co-authored-by: Andrew Lamb <alamb@influxdata.com>

Co-authored-by: Andrew Lamb <alamb@influxdata.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-06 16:44:02 +00:00
kodiakhq[bot] 772c7621db
Merge pull request #2746 from influxdata/ntran/no_use_stats
feat: Disable using statistics to query data if there are soft deleted rows
2021-10-06 15:26:49 +00:00
Nga Tran 05387f5a70 test: disable running query after re-create db in delete_predicate_preservation to avoid flaky test 2021-10-06 11:17:02 -04:00
Nga Tran bd93b411c7 chore: cleanup 2021-10-06 10:57:51 -04:00
kodiakhq[bot] 1aee2a49eb
Merge branch 'main' into ntran/no_use_stats 2021-10-06 14:06:01 +00:00
Nga Tran 65a02f7085
refactor: Apply suggestions from code review
Co-authored-by: Edd Robinson <me@edd.io>
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2021-10-06 10:04:28 -04:00
Raphael Taylor-Davies ce5b24e65d
refactor: use DateTime<Utc> in PersistenceWindows (#2722) (#2743)
* refactor: use DateTime<Utc> in PersistenceWindows (#2722)

* chore: fix benchmark

* chore: fmt

* chore: review feedback
2021-10-06 09:39:32 +00:00
Edd Robinson ea26a77217
Merge branch 'main' into ntran/no_use_stats 2021-10-06 09:30:18 +01:00
kodiakhq[bot] fe61a4a868
Merge pull request #2628 from influxdata/crepererum/move_delete_predicate_persistence
refactor: move delete predicate persistence into background job
2021-10-06 06:14:05 +00:00
Marco Neumann d322069dd4 refactor: move delete predicate persistence into background job 2021-10-06 08:05:38 +02:00
Nga Tran 055e69439d test: fix auto created tests 2021-10-05 18:11:27 -04:00
Nga Tran aa64daca86 feat: dDisable using statistics to query data if there are soft deleted rows 2021-10-05 17:52:32 -04:00
Raphael Taylor-Davies a647865e1a
revert: "build: pin smallvec" (#2740)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-05 19:23:00 +00:00
Andrew Lamb 785a62c114
fix: include all group tags, not just group_keys in GroupFrame response (#2741)
* fix: include all group tags, not just group_keys in GroupFrame response

* docs: fix test comments, add doc strings for group_description_to_frames

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-05 19:08:04 +00:00
kodiakhq[bot] 5177e69514
Merge pull request #2742 from influxdata/ntran/delete_cleanup
chore: clean up dead code
2021-10-05 17:49:35 +00:00
Nga Tran eebbb9a165 chore: clea up dead code 2021-10-05 13:08:40 -04:00
kodiakhq[bot] ad60d73657
Merge pull request #2730 from influxdata/crepererum/in_mem_expr_part5
refactor: delete predicate clean-ups
2021-10-05 16:30:32 +00:00
kodiakhq[bot] d72a494198
Merge branch 'main' into crepererum/in_mem_expr_part5 2021-10-05 16:20:24 +00:00
Raphael Taylor-Davies d0929e3a34
feat: persist no chunks (#2712) (#2718)
* feat: persist no chunks (#2712)

* fix: persist partition

* fix: chunk ordering test

* chore: fix logical conflict

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-05 15:18:35 +00:00
Raphael Taylor-Davies 2a584420b3
refactor: make data_types optional dependency (#2739)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-05 15:07:45 +00:00
Andrew Lamb bf73bba1dc
fix: Return `_field` and `_measurement` tags correctly for read_group (#2736)
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-05 14:56:41 +00:00
kodiakhq[bot] f8fd61e2c3
Merge pull request #2737 from influxdata/dom/pin-smallvec
build: pin smallvec
2021-10-05 14:42:01 +00:00
kodiakhq[bot] c9e030e901
Merge branch 'main' into dom/pin-smallvec 2021-10-05 14:32:18 +00:00
Dom 5abc55406d build: pin smallvec
Pin the smallvec version until the rest of the ecosystem catches up.

Fixes https://github.com/influxdata/influxdb_iox/issues/2735.
2021-10-05 16:27:00 +02:00
kodiakhq[bot] e525d75c9a
Merge pull request #2728 from influxdata/ntran/response
feat: handle delete responses
2021-10-05 14:23:14 +00:00
kodiakhq[bot] d92544f142
Merge branch 'main' into ntran/response 2021-10-05 14:13:47 +00:00
Nga Tran 825ddaa34c chore: merge main to branch 2021-10-05 10:12:17 -04:00
kodiakhq[bot] d50f41c427
Merge pull request #2733 from influxdata/dom/cloneable-iox-client-builder
refactor: derive Clone for IOx client builder
2021-10-05 13:57:38 +00:00
Dom 53e49156d6 refactor: derive Clone for IOx client builder
Allows an IOx client builder (with its associated configuration) to be
cloned.
2021-10-05 15:44:57 +02:00
kodiakhq[bot] 08d69d3da7
Merge pull request #2732 from influxdata/crepererum/bytes_for_txn_uuids
refactor: use protobuf bytes for transaction UUIDs
2021-10-05 11:07:22 +00:00
Marco Neumann b8aa4c33ce refactor: use protobuf bytes for transaction UUIDs 2021-10-05 12:27:48 +02:00
Marco Neumann bb7a27e5ed refactor: use proper sets during delete predicate collection
We no longer need hacky pointer tricks to de-duplicate delete predicates
when collecting them for catalog checkpoints. This was once required
when the delete predicates didn't implement `Eq` and `Hash` but now it's
all way easier.
2021-10-05 10:37:34 +02:00
Marco Neumann 28ccf2a8c3 refactor: `TransactionHandle::delete_predicate` cannot fail 2021-10-05 09:41:46 +02:00
kodiakhq[bot] 0a83379e23
Merge pull request #2723 from influxdata/crepererum/in_mem_expr_part4
refactor: remove unused fields from `DeletePredicate` and remove intermediate `ParseDeletePredicate`
2021-10-05 07:37:31 +00:00