Commit Graph

5837 Commits (053afac5e921d0786c9000bc7761e388f4af29b2)

Author SHA1 Message Date
Carol (Nichols || Goulding) 088cdd8f97
fix: Share comfy_table style and give it a more descriptive name and docs 2021-10-28 16:00:58 -04:00
Carol (Nichols || Goulding) c61806f919
fix: Apply commenting and logging suggestions from code review
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2021-10-28 15:32:33 -04:00
Carol (Nichols || Goulding) e4e494f1d9
fix: Remove now-unused transition function. Fixes #2762. 2021-10-28 13:30:43 -04:00
Carol (Nichols || Goulding) f8b5886110
test: Add more test coverage for new behavior 2021-10-28 13:20:29 -04:00
Carol (Nichols || Goulding) d2bd8f05db
fix: Clean up error messages and comments referencing generations 2021-10-28 13:20:29 -04:00
Carol (Nichols || Goulding) 0bccd35f8c
fix: List details about databases only prints active dbs and their UUIDs
We can no longer list deleted databases because the server no longer
knows about them, and we now have UUIDs that are useful to know about,
so change the detailed listing of databases to return UUID instead of
possible deleted at time.
2021-10-28 13:20:29 -04:00
Carol (Nichols || Goulding) ce55cf401c
feat: Return UUID when creating a database
Seems polite and is useful for some test setup
2021-10-28 13:20:29 -04:00
Carol (Nichols || Goulding) 4077d3a20a
fix: Take a UUID when restoring a database 2021-10-28 13:20:29 -04:00
Carol (Nichols || Goulding) 95ba84edca
fix: Return UUID when a database is deleted
So that it can be immediately used to restore elsewhere.
2021-10-28 13:20:29 -04:00
Carol (Nichols || Goulding) e80b902d15
test: Delete tests either irrelevant or covered elsewhere
Now that the database paths use UUIDs instead of names+generation ids,
and that IoxObjectStore checks there are no files in a directory before
it'll create a database directory (and has tests for that).
2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) 990f768cda
fix: Assign a UUID when creating a database 2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) 09ad30cbfd
fix: For dumping a db catalog, look up db location in server config first
Rather than requiring the user of this command to know the database UUID
or otherwise having the knowledge of how to construct a database object
store location in this debugging command.
2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) 4a225cf913
fix: Change database paths to use UUIDs instead of name
This commit changes the iox_object_store crate only; the implications of
these changes are handled in following commits.

Connects to #2675.
2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) f160712f5e
fix: Remove the concept of generations
From iox_object_store and everywhere that fails to compile as a result.

Also make path handling in iox_object_store a bit more consistent.
2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) 80f04e8fec
docs: Move crate documentation to top of lib.rs 2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) eeb017990d
fix: Add missing features to object_store crate to enable running tests separately 2021-10-28 13:20:28 -04:00
Carol (Nichols || Goulding) 8198c1ff2a
refactor: Rename IoxObjectStore constructors to better match what server does with Databases 2021-10-28 13:20:27 -04:00
Marco Neumann 641c7b3051 refactor: make `influxdb_ioxd` server-type-generic 2021-10-28 17:38:06 +02:00
kodiakhq[bot] 94368c339c
Merge pull request #2976 from influxdata/crepererum/run_modes_boilerplate2
refactor: make gRPC server code reusable
2021-10-28 14:39:34 +00:00
Marco Neumann 9996cfc6b3 fix: things I forgot to rename 2021-10-28 16:33:03 +02:00
Marco Neumann 9cd3dfb624 refactor: make gRPC server code reusable
Sadly `tonic` is a bit of a type nightmare (see
<23c1392fb7/tonic/src/transport/server/mod.rs (L452-L470)>
). So I wasn't able to pull into a simple "add all your
services"-function. Instead the server type now builds its own gRPC
server but relies on some helper macros to for common functionality.
2021-10-28 13:19:24 +02:00
kodiakhq[bot] 079ac5cc4b
Merge pull request #2971 from influxdata/crepererum/run_modes_boilerplate
refactor: abstract HTTP inteface for different run modes
2021-10-28 09:25:21 +00:00
Marco Neumann a6e0a069cc refactor: rename "run mode" to "server type" 2021-10-28 11:16:41 +02:00
Marco Neumann 843551d291 docs: improve
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2021-10-28 11:16:41 +02:00
Marco Neumann c465d0af8f refactor: abstract HTTP inteface for different run modes
First iteration of a common interface for the different server run
modes. This splits the existing HTTP server into a part that can be used
by all run modes (e.g. health checks, metrics endpoint, profiling) and a
part that is specific to the the database run mode.

Note that the interface is not final and might require more iterations,
but we have to start somewhere.
2021-10-28 11:16:41 +02:00
Raphael Taylor-Davies ec07c11d36
feat: add PartitionWrite (#2724) (#2974)
* feat: add PartitionWrite (#2724)

* chore: review feedback
2021-10-28 06:18:10 +00:00
Raphael Taylor-Davies 3010ff4176
feat: write entry to MutableBatch (#2972)
* feat: write entry to MutableBatch

* feat: error on empty TableBatch

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-27 14:05:22 +00:00
kodiakhq[bot] 4e49c3bf72
Merge pull request #2951 from influxdata/ntran/group
fix: read_group now returns nothing for empty table (with or without soft delete data)
2021-10-27 13:15:26 +00:00
Nga Tran b397a6b03c
Merge branch 'main' into ntran/group 2021-10-27 09:09:10 -04:00
Raphael Taylor-Davies 9516b0b81a
feat: fuzz test mutable batch (#2970)
* feat: fuzz test mutable batch

* chore: review feedback

* chore: fmt

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-27 12:57:32 +00:00
kodiakhq[bot] 7fa7a3091e
Merge pull request #2967 from influxdata/crepererum/prepare_run_mode_cli
refactor: offer different modes via "run" CLI
2021-10-27 11:10:48 +00:00
kodiakhq[bot] 6ebca13ed7
Merge branch 'main' into crepererum/prepare_run_mode_cli 2021-10-27 11:04:07 +00:00
Marko Mikulicic d5f1d52221
Merge pull request #2969 from influxdata/size_histogram
feat: Add LP batch size histogram metric
2021-10-27 12:34:09 +02:00
Marko Mikulicic cdc0c63cb7
feat: Add LP batch size histogram metric
Part of #2752
2021-10-27 12:14:48 +02:00
Raphael Taylor-Davies aafc618337
fix: PackedStringArray extend_from (#2968)
* fix: PackedStringArray extend_from

* chore: review feedback

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
2021-10-27 08:07:51 +00:00
Marco Neumann 6e29cec502 refactor: rename `query` mode to `database` 2021-10-27 09:31:46 +02:00
Marco Neumann 41bc373fe8 refactor: offer different modes via "run" CLI
Running a server is now using `influxdb_iox run MODE [args]`, e.g.
`influxdb_iox run query --server-id 1`. Another mode that will follow
soon is `router`.

The old syntax `influxdb_iox run [args]` (w/o the mode part) is still
supported but a deprecation note will be printed.
2021-10-27 09:31:46 +02:00
kodiakhq[bot] 6760212e86
Merge branch 'main' into ntran/group 2021-10-26 21:25:57 +00:00
Nga Tran 5c2a5e1030 fix: fmt after appying review comments 2021-10-26 17:17:35 -04:00
Nga Tran 6950e7a9b6
chore: Apply suggestions from code review
Co-authored-by: Andrew Lamb <alamb@influxdata.com>
2021-10-26 17:08:07 -04:00
Nga Tran 7b3b92b161 chore: make comments clearer 2021-10-26 16:52:45 -04:00
Nga Tran 682499d4a7 chore: make comments clearer 2021-10-26 16:50:27 -04:00
Nga Tran 8c43b24745 chore: cleanup 2021-10-26 16:46:50 -04:00
Nga Tran 46cb4df14d fix: now no rows will be return for read_group if the table has no data or all its data is soft deleted or the table does not exist 2021-10-26 16:40:36 -04:00
Marco Neumann 5451a49620
fix: flaky `test_query_cancellation_slow_store` (#2966) 2021-10-26 15:58:28 +00:00
kodiakhq[bot] f19d53c714
Merge pull request #2965 from influxdata/crepererum/workspace_cleanups
chore: flatten workspace
2021-10-26 09:35:48 +00:00
Marco Neumann fc651ea193 chore: move `gprc-router-test-gen` to top level 2021-10-26 11:02:33 +02:00
Marco Neumann a0cdca7781 chore: move `influxdb_iox` into a proper workspace package 2021-10-26 11:02:33 +02:00
kodiakhq[bot] 23fa85994e
Merge pull request #2960 from influxdata/crepererum/no_kafka_end2end
test: remove Kafka from end2end tests
2021-10-26 08:17:44 +00:00
Marco Neumann 3af1504ed2 fix: race condition in file-based write buffer 2021-10-26 10:09:34 +02:00