Commit Graph

14918 Commits (db/6263/compaction-debug-logging)

Author SHA1 Message Date
Edd Robinson 67cfa21732
Merge pull request #10541 from gpomykala/10540
Fix open/close race in SeriesFile
2019-02-19 16:53:25 +00:00
Jeff Wendling 1d9ce868e2 Fix some more shard epoch races
We're not allowed to access the s.epochs map without holding the
mutex against shard creation and deletion, so create a copy of
all of the epoch trackers we will need while we hold the mutex.
2019-02-19 08:59:13 -07:00
Hercules Mango Churchill 190b7df950 Update changelog 2019-02-18 23:34:42 +00:00
Ben Johnson 89497abd7e
Merge pull request #11750 from influxdata/bj-fix-tag-key-value-lock-1.8
Update tagKeyValue mutex to write lock.
2019-02-18 16:34:23 -07:00
Ben Johnson c61db43dc2
Update tagKeyValue mutex to write lock.
This commit changes the read lock to a write lock when calling the
`ids()` function because `ids()` can mutate the underlying series
ids slice.
2019-02-15 09:29:48 -07:00
Hercules Mango Churchill 91ac42815b Update changelog 2019-02-12 23:41:20 +00:00
Jeff Wendling 46dbd94e8a
Merge pull request #11832 from influxdata/jmw-clone-cached-ss
Ensure that cached series id sets are Go heap backed
2019-02-12 16:30:15 -07:00
Jeff Wendling 40d2b70376 Ensure that cached series id sets are Go heap backed 2019-02-12 15:20:24 -07:00
Hercules Mango Churchill 7fa9869b88 Update changelog 2019-02-12 21:55:21 +00:00
Ben Johnson 8c491ce1db
Merge pull request #11829 from influxdata/bj-tag-cache-string-1.8
Convert TagValueSeriesIDCache to use string fields.
2019-02-12 14:45:14 -07:00
Ben Johnson 6e5226437a
Convert TagValueSeriesIDCache to use string fields.
This commit changes `name`, `key`, and `value` to from `[]byte`
to `string`.
2019-02-12 14:22:40 -07:00
Hercules Mango Churchill cbdee3d933 Update changelog 2019-02-11 19:51:16 +00:00
Ben Johnson aa3dfc0662
Merge pull request #11791 from influxdata/bj-revert-limit-full-compaction-1.8
Revert "Limit force-full and cold compaction size."
2019-02-11 12:50:55 -07:00
Ben Johnson b87605f521
Fix shard epoch race. 2019-02-11 12:15:46 -07:00
Ben Johnson 198f6fde38
Fix deleteSeriesRange() race condition. 2019-02-11 11:29:09 -07:00
Ben Johnson 2dd913d71b
Revert "Limit force-full and cold compaction size."
This reverts commit 40db64d0b9.
2019-02-11 11:07:44 -07:00
Edd Robinson 8b5b0fc5d2
Merge pull request #10375 from KimMachineGun/modify-contextkey
Modify context key type
2019-02-11 10:48:24 +00:00
Edd Robinson 05e7def600
Merge pull request #10332 from ludweeg/ludweeg/unslice
Simplify s[:] to s where s is a slice
2019-02-11 10:24:43 +00:00
Hercules Mango Churchill 42ec806e7e Update changelog 2019-02-11 10:23:34 +00:00
Edd Robinson 42267331bd
Merge pull request #10206 from rda0/master
Fix legacy restore bug #10072
2019-02-11 10:23:15 +00:00
Edd Robinson 65b80cc742
Merge pull request #10591 from dbellinghoven/fix-null-pointer-reference
[BUG FIX] Fix nil pointer dereference at /api/v1/prom/read
2019-02-08 22:53:16 +00:00
Hercules Mango Churchill 126e4e2263 Update changelog 2019-02-07 01:14:32 +00:00
Gunnar cba956943a
Merge pull request #11742 from influxdata/ga-amzn-linux-2
Use Systemd for Amazon Linux 2
2019-02-06 17:14:13 -08:00
Gunnar Aasen 0350557c16 Use Systemd for Amazon Linux 2 packages 2019-02-06 16:28:48 -08:00
Grzegorz Pomykala 8448cf4a9c build fixed 2019-02-06 16:27:59 +01:00
Hercules Mango Churchill 5e1e0b122a Update changelog 2019-02-06 15:14:52 +00:00
Jonathan A. Sternberg 2811cde76d
Merge pull request #10414 from seebs/seebs/valuerReuse
reuse ValuerEval objects
2019-02-06 09:14:15 -06:00
Grzegorz Pomykala fb3c837de9 code review sugestions applied 2019-02-06 09:10:51 +01:00
Seebs 5525240de3 reuse ValuerEval objects
Scanner objects and iterators often need a ValuerEval. This
object is created, often with a function call, and has at
least one interface in it, so it allocates storage. Then it's
dropped again right away. The only part of it that might be
subject to change is usually a map. While the map's contents
change over time, the actual map doesn't change for the
lifetime of the object.

So, in both iterators and scanners, stash the ValuerEval
and continue reusing it. On a query returning a fair number
of data points, this produces a small (<5% in practice)
improvement in observed performance, visible as a significant
reduction in time spent in runtime (mallocgc, newobject,
etcetera).

The performance improvement isn't big, but it's reasonably
easy to evaluate it and establish that it's a safe change
to make.

Signed-off-by: seebs <seebs@seebs.net>
2019-02-05 15:10:23 -06:00
Dilan Bellinghoven cb9b89015d
Add back newlines to minimize changes 2019-02-05 07:47:29 -05:00
Dilan Bellinghoven 502ac291e7
Move resp after Store.Read 2019-02-05 07:45:59 -05:00
Dilan Bellinghoven 9aace188cc
Add back newline 2019-02-04 22:28:35 -05:00
Dilan Bellinghoven 4bd67c5c68
Merge branch '1.8' into fix-null-pointer-reference 2019-02-04 22:20:05 -05:00
Dilan Bellinghoven d2e6b91de2
Updated servePromRead to match #10617 and updated handler_test.go to reflect changes 2019-02-04 22:15:44 -05:00
Ben Johnson def9589584
Merge pull request #10522 from hahnjo/fix-compaction-cache-snapshots
Fix compaction logic on infrequent cache snapshots
2019-02-04 08:34:03 -07:00
Ben Johnson 5c2577df8c
Merge pull request #10502 from hpbieker/hpb-no-series-rebuild-on-delete-when-series-still-in-cache
No rebuild series index on delete when the series still exists in cache
2019-02-04 08:32:34 -07:00
Ben Johnson 4083ae01e3
Merge branch '1.8' into hpb-no-series-rebuild-on-delete-when-series-still-in-cache 2019-02-04 08:32:04 -07:00
KimMachineGun 6afad6e322
Merge branch '1.8' into modify-contextkey 2019-02-04 20:41:11 +09:00
Edd Robinson e9dee25dda
Merge pull request #9916 from datamuc/master
add test case for #9522
2019-02-04 03:36:54 -08:00
Edd Robinson e72b24653a
Merge pull request #10546 from iguanesolutions/clientv2_queryctx
clientv2 - QueryCtx()
2019-02-04 03:34:19 -08:00
Edd Robinson f086930d42
Merge pull request #10480 from ShiKaiWi/refactor-writeToShard
improve error handling of PointsWriter.writeToShard
2019-02-04 03:24:40 -08:00
Edd Robinson 3a81921bb0
Merge pull request #10505 from hpbieker/hpb-no-series-rebuild-on-delete-without-overlap-timerange
Do not rebuild series index on delete for series not overlapping in time
2019-02-04 03:22:00 -08:00
Edd Robinson 603e0c9837
Merge pull request #10350 from bvwells/golint-logger
Golint logger package
2019-02-04 02:42:10 -08:00
Edd Robinson 17bec0438f
Merge pull request #10392 from bvwells/misspell
Fix misspelling identified by misspell
2019-02-04 02:38:38 -08:00
Ben Wells e9bada090f Fix misspelling identified by misspell 2019-02-03 20:27:43 +00:00
Ben Wells c6cd433306 Golint logger package 2019-02-03 20:11:31 +00:00
Edouard Hur 35638abd7a
linting all udp error messages 2019-02-03 00:46:59 +01:00
datamuc 6133f91d67
Merge branch '1.8' into master 2019-02-02 17:33:04 +01:00
Edd Robinson 59e4d86cbf
Merge pull request #10438 from smasuda/feature/fix_pr_template
to fix the dead link to InfluxQL in the PR template
2019-02-01 15:52:33 -08:00
Ben Johnson 0c6d77d952
Merge pull request #9944 from michaelyou/hotfix-hashring-mod
Hash ring's hash mod
2019-02-01 12:54:15 -08:00