Improve clarity of variable name

pull/10616/head
Alex P 2017-05-22 17:41:17 -07:00
parent 83dca62d6c
commit fa997b27bd
3 changed files with 12 additions and 12 deletions

View File

@ -20,7 +20,7 @@ const Dashboard = ({
templatesIncludingDashTime, templatesIncludingDashTime,
onSummonOverlayTechnologies, onSummonOverlayTechnologies,
onSelectTemplate, onSelectTemplate,
isTempVarsControlsOpen, showTempVarControls,
}) => { }) => {
if (dashboard.id === 0) { if (dashboard.id === 0) {
return null return null
@ -52,7 +52,7 @@ const Dashboard = ({
templates={dashboard.templates} templates={dashboard.templates}
onSelectTemplate={onSelectTemplate} onSelectTemplate={onSelectTemplate}
onOpenTemplateManager={onOpenTemplateManager} onOpenTemplateManager={onOpenTemplateManager}
isOpen={isTempVarsControlsOpen} isOpen={showTempVarControls}
/> />
{cells.length {cells.length
? <LayoutRenderer ? <LayoutRenderer
@ -119,7 +119,7 @@ Dashboard.propTypes = {
timeRange: shape({}).isRequired, timeRange: shape({}).isRequired,
onOpenTemplateManager: func.isRequired, onOpenTemplateManager: func.isRequired,
onSelectTemplate: func.isRequired, onSelectTemplate: func.isRequired,
isTempVarsControlsOpen: bool, showTempVarControls: bool,
} }
export default Dashboard export default Dashboard

View File

@ -21,7 +21,7 @@ const DashboardHeader = ({
onAddCell, onAddCell,
onEditDashboard, onEditDashboard,
onToggleTempVarControls, onToggleTempVarControls,
isTempVarsControlsOpen, showTempVarControls,
}) => }) =>
isHidden isHidden
? null ? null
@ -65,7 +65,7 @@ const DashboardHeader = ({
{dashboard {dashboard
? <div ? <div
className={classnames('btn btn-info btn-sm', { className={classnames('btn btn-info btn-sm', {
active: isTempVarsControlsOpen, active: showTempVarControls,
})} })}
onClick={onToggleTempVarControls} onClick={onToggleTempVarControls}
> >
@ -109,7 +109,7 @@ DashboardHeader.propTypes = {
onAddCell: func, onAddCell: func,
onEditDashboard: func, onEditDashboard: func,
onToggleTempVarControls: func, onToggleTempVarControls: func,
isTempVarsControlsOpen: bool, showTempVarControls: bool,
} }
export default DashboardHeader export default DashboardHeader

View File

@ -26,7 +26,7 @@ class DashboardPage extends Component {
selectedCell: null, selectedCell: null,
isEditMode: false, isEditMode: false,
isTemplating: false, isTemplating: false,
isTempVarsControlsOpen: false, showTempVarControls: false,
} }
this.handleAddCell = ::this.handleAddCell this.handleAddCell = ::this.handleAddCell
@ -209,12 +209,12 @@ class DashboardPage extends Component {
} }
handleTempVarsControlsToggle(e) { handleTempVarsControlsToggle(e) {
const {isTempVarsControlsOpen} = this.state const {showTempVarControls} = this.state
if (e) { if (e) {
e.stopPropagation() e.stopPropagation()
} }
this.setState({isTempVarsControlsOpen: !isTempVarsControlsOpen}) this.setState({showTempVarControls: !showTempVarControls})
} }
getActiveDashboard() { getActiveDashboard() {
@ -257,7 +257,7 @@ class DashboardPage extends Component {
selectedCell, selectedCell,
isEditMode, isEditMode,
isTemplating, isTemplating,
isTempVarsControlsOpen, showTempVarControls,
} = this.state } = this.state
return ( return (
@ -306,7 +306,7 @@ class DashboardPage extends Component {
onAddCell={this.handleAddCell} onAddCell={this.handleAddCell}
onEditDashboard={this.handleEditDashboard} onEditDashboard={this.handleEditDashboard}
onToggleTempVarControls={this.handleTempVarsControlsToggle} onToggleTempVarControls={this.handleTempVarsControlsToggle}
isTempVarsControlsOpen={isTempVarsControlsOpen} showTempVarControls={showTempVarControls}
> >
{dashboards {dashboards
? dashboards.map((d, i) => ( ? dashboards.map((d, i) => (
@ -338,7 +338,7 @@ class DashboardPage extends Component {
templatesIncludingDashTime={templatesIncludingDashTime} templatesIncludingDashTime={templatesIncludingDashTime}
onSummonOverlayTechnologies={this.handleSummonOverlayTechnologies} onSummonOverlayTechnologies={this.handleSummonOverlayTechnologies}
onSelectTemplate={this.handleSelectTemplate} onSelectTemplate={this.handleSelectTemplate}
isTempVarsControlsOpen={isTempVarsControlsOpen} showTempVarControls={showTempVarControls}
/> />
: null} : null}
</div> </div>