chore(http/duration): mention need for longer duration literals

pull/10616/head
Chris Goller 2018-09-25 18:11:20 -05:00
parent 916b5f49a5
commit f70a8cb3ce
1 changed files with 6 additions and 0 deletions

View File

@ -85,6 +85,8 @@ func ParseDuration(s string) (time.Duration, error) {
i += 2 i += 2
continue continue
case 'o': // mo == month case 'o': // mo == month
// TODO(goller): use real duration values:
// https://github.com/influxdata/platform/issues/657
unit = string(a[i : i+2]) unit = string(a[i : i+2])
d += time.Duration(n) * 30 * 24 * time.Hour d += time.Duration(n) * 30 * 24 * time.Hour
i += 2 i += 2
@ -99,8 +101,12 @@ func ParseDuration(s string) (time.Duration, error) {
case 'd': case 'd':
d += time.Duration(n) * 24 * time.Hour d += time.Duration(n) * 24 * time.Hour
case 'w': case 'w':
// TODO(goller): use real duration values:
// https://github.com/influxdata/platform/issues/657
d += time.Duration(n) * 7 * 24 * time.Hour d += time.Duration(n) * 7 * 24 * time.Hour
case 'y': case 'y':
// TODO(goller): use real duration values:
// https://github.com/influxdata/platform/issues/657
d += time.Duration(n) * 365 * 24 * time.Hour d += time.Duration(n) * 365 * 24 * time.Hour
default: default:
return 0, ErrInvalidDuration return 0, ErrInvalidDuration