Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: use nil Sources field in /api/v2/delete (#24145) 

An empty slice in Sources causes an empty
WHERE clause to be generated by
Statement.String(). Use a nil in the field
to omit the WHERE clause completely

closes https://github.com/influxdata/influxdb/issues/24144
pull/24198/head
davidby-influx 2023-03-17 07:38:14 -07:00 committed by GitHub
parent c31e99574f
commit f365bb7e3a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
services/httpd/handler.go
View File

@ -1001,9 +1001,13 @@ func (h *Handler) serveDeleteV2(w http.ResponseWriter, r *http.Request, user met
return
}
srcs := make([]influxql.Source, 0)
const measurement = "_measurement"
// This has to be nil if there are no sources;
// an empty slice causes the Statement.String()
// function into adding an empty WHERE clause.
// And that breaks Enterprise remote query execution.
var srcs []influxql.Source = nil
// take out the _measurement = 'mymeasurement' clause to pass separately
// Also check for illegal operands.
_, remainingExpr, err := influxql.PartitionExpr(influxql.CloneExpr(cond), func(e influxql.Expr) (bool, error) {