Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test: close test SQL store before deleting its tmp dir in tests (#22421)

pull/22422/head
Daniel Moran 2021-09-08 11:12:21 -04:00 committed by GitHub
parent a7cd53a732
commit eb5f5c3c5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sqlite/sqlite_helpers.go
View File

@ -5,24 +5,20 @@ import (
"os" "os"
"testing" "testing"
"github.com/stretchr/testify/require"
"go.uber.org/zap" "go.uber.org/zap"
) )
func NewTestStore(t *testing.T) (*SqlStore, func(t *testing.T)) { func NewTestStore(t *testing.T) (*SqlStore, func(t *testing.T)) {
tempDir, err := ioutil.TempDir("", "") tempDir, err := ioutil.TempDir("", "")
if err != nil { require.NoError(t, err, "unable to create temporary test directory")
t.Fatalf("unable to create temporary test directory %v", err)
}
cleanUpFn := func(t *testing.T) {
if err := os.RemoveAll(tempDir); err != nil {
t.Fatalf("unable to delete temporary test directory %s: %v", tempDir, err)
}
}
s, err := NewSqlStore(tempDir+"/"+DefaultFilename, zap.NewNop()) s, err := NewSqlStore(tempDir+"/"+DefaultFilename, zap.NewNop())
if err != nil { require.NoError(t, err, "unable to open testing database")
t.Fatal("unable to open testing database")
cleanUpFn := func(t *testing.T) {
require.NoError(t, s.Close(), "failed to close testing database")
require.NoErrorf(t, os.RemoveAll(tempDir), "unable to delete temporary test directory %s", tempDir)
} }
return s, cleanUpFn return s, cleanUpFn