fix(ui/cloudNav): Update cloud subnav feature flag to use env var (#14171)

Subnav should be visible in acceptance but feature flagged in production

ui/src/pageLayout/components/CloudNav.tsx

@@ -25,7 +25,7 @@ export default class CloudNav extends PureComponent {
             </a>
           )}
         >
-          <FeatureFlag name="cloudSubNav">
+          <FeatureFlag name="cloudBilling">
             <NavMenu.SubItem
               active={false}
               titleLink={className => (

ui/src/shared/constants/index.ts

@@ -47,6 +47,8 @@ export const GIT_SHA = process.env.GIT_SHA
 export const CLOUD = process.env.CLOUD && process.env.CLOUD === 'true'
 export const CLOUD_SIGNIN_PATHNAME = '/api/v2/signin'
 export const CLOUD_SIGNOUT_URL = process.env.CLOUD_LOGOUT_URL
+export const CLOUD_BILLING_VISIBLE =
+  CLOUD && process.env.CLOUD_BILLING_VISIBLE === 'true'
 
 export const VIS_THEME: Partial<Config> = {
   axisColor: '#31313d',

ui/src/shared/utils/featureFlag.ts

@@ -1,5 +1,5 @@
 import {FunctionComponent} from 'react'
-import {CLOUD} from 'src/shared/constants'
+import {CLOUD, CLOUD_BILLING_VISIBLE} from 'src/shared/constants'
 
 const OSS_FLAGS = {
   heatmap: true,
@@ -11,6 +11,7 @@ const CLOUD_FLAGS = {
   heatmap: false, // We need to ensure the API updates have been deployed before enabling
   scatter: false, // ditto ^^
   lineGraphShading: false, // ditto! ^^
+  cloudBilling: CLOUD_BILLING_VISIBLE, // should be visible in dev and acceptance, but not in cloud
 }
 
 export const isFlagEnabled = (flagName: string) => {