Merge branch 'main' into dom/partition-contains-key

arrow_util/src/lib.rs

@@ -1,5 +1,14 @@
 #![deny(rustdoc::broken_intra_doc_links, rustdoc::bare_urls, rust_2018_idioms)]
 #![allow(clippy::clone_on_ref_ptr)]
+#![warn(
+    missing_copy_implementations,
+    missing_debug_implementations,
+    clippy::explicit_iter_loop,
+    clippy::future_not_send,
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
+)]
 
 pub mod bitset;
 pub mod dictionary;

arrow_util/src/string.rs

@@ -175,6 +175,7 @@ impl PackedStringArray<i32> {
     }
 }
 
+#[derive(Debug)]
 pub struct PackedStringIterator<'a, K> {
     array: &'a PackedStringArray<K>,
     index: usize,

arrow_util/src/test_util.rs

@@ -80,7 +80,7 @@ pub fn sort_record_batch(batch: RecordBatch) -> RecordBatch {
         .columns()
         .iter()
         .map(|col| SortColumn {
-            values: col.clone(),
+            values: Arc::clone(col),
             options: Some(SortOptions {
                 descending: false,
                 nulls_first: false,

backoff/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 use observability_deps::tracing::info;
 use rand::prelude::*;

cache_system/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod addressable_heap;

clap_blocks/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 pub mod catalog_dsn;
 pub mod compactor;

client_util/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

compactor/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub(crate) mod cold;

data_types/src/lib.rs

@@ -8,7 +8,9 @@
     missing_docs,
     clippy::explicit_iter_loop,
     clippy::future_not_send,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use influxdb_line_protocol::FieldValue;

dml/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::time::Duration;

executor/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use parking_lot::Mutex;
@@ -621,7 +623,7 @@ mod tests {
     async fn wait_for_tasks(exec: &DedicatedExecutor, num: usize) {
         tokio::time::timeout(Duration::from_secs(1), async {
             loop {
-                if dbg!(exec.tasks()) == num {
+                if exec.tasks() == num {
                     return;
                 }
                 tokio::time::sleep(Duration::from_millis(1)).await;

garbage_collector/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

grpc-binary-logger/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod predicate;

influxdb2_client/src/lib.rs

@@ -7,7 +7,9 @@
     missing_docs,
     clippy::explicit_iter_loop,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 //! # influxdb2_client

influxdb_influxql_parser/src/lib.rs

@@ -9,7 +9,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::common::statement_terminator;

influxdb_iox_client/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

influxdb_line_protocol/src/lib.rs

@@ -13,7 +13,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod builder;

influxdb_storage_client/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

influxdb_tsm/src/lib.rs

@@ -4,7 +4,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod encoders;

influxrpc_parser/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::use_self,
     clippy::clone_on_ref_ptr,
     clippy::str_to_string,
-    clippy::string_to_string
+    clippy::string_to_string,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod predicate;

ingester/src/lib.rs

@@ -7,10 +7,14 @@
     missing_copy_implementations,
     missing_debug_implementations,
     missing_docs,
+    clippy::todo,
+    clippy::dbg_macro,
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub(crate) mod compact;

iox_catalog/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::interface::{

iox_data_generator/src/lib.rs

@@ -24,7 +24,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::{agent::Agent, tag_set::GeneratedTagSets};

iox_query/src/lib.rs

@@ -5,7 +5,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use async_trait::async_trait;

iox_tests/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod util;

iox_time/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use chrono::{DateTime, TimeZone, Timelike, Utc};

ioxd_garbage_collector/src/lib.rs

@@ -11,7 +11,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items)]
 

metric/src/lib.rs

@@ -107,7 +107,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use parking_lot::Mutex;

metric_exporters/src/lib.rs

@@ -3,7 +3,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use metric::{Attributes, MetricKind, Observation};

mutable_batch/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 //! A mutable data structure for a collection of writes.

mutable_batch_lp/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use hashbrown::{hash_map::Entry, HashMap, HashSet};

mutable_batch_pb/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod decode;

packers/src/lib.rs

@@ -4,7 +4,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod packers;

panic_logging/src/lib.rs

@@ -6,7 +6,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::{fmt, panic, sync::Arc};

predicate/src/lib.rs

@@ -5,7 +5,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 pub mod delete_expr;

querier/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod cache;

query_functions/src/lib.rs

@@ -6,7 +6,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use datafusion::{

read_buffer/src/column.rs

@@ -188,7 +188,7 @@ impl Column {
                 Some((min, max)) => (OwnedValue::Boolean(min), OwnedValue::Boolean(max)),
                 None => (OwnedValue::new_null(), OwnedValue::new_null()),
             },
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -216,11 +216,11 @@ impl Column {
     }
 
     pub fn column_min(&self) -> Value<'_> {
-        todo!()
+        unimplemented!()
     }
 
     pub fn column_max(&self) -> Value<'_> {
-        todo!()
+        unimplemented!()
     }
 
     //
@@ -242,7 +242,7 @@ impl Column {
             Self::Integer(_, data) => data.value(row_id),
             Self::Unsigned(_, data) => data.value(row_id),
             Self::Bool(_, data) => data.value(row_id),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -261,7 +261,7 @@ impl Column {
             Self::Integer(_, data) => data.values(row_ids),
             Self::Unsigned(_, data) => data.values(row_ids),
             Self::Bool(_, data) => data.values(row_ids),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -293,7 +293,7 @@ impl Column {
             Self::Integer(_, data) => data.all_values(),
             Self::Unsigned(_, data) => data.all_values(),
             Self::Bool(_, data) => data.all_values(),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -313,7 +313,7 @@ impl Column {
     pub fn decode_id(&self, encoded_id: u32) -> Value<'_> {
         match &self {
             Self::String(_, data) => data.decode_id(encoded_id),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
             _ => panic!("unsupported operation"),
         }
     }
@@ -412,7 +412,7 @@ impl Column {
             Self::Integer(_, data) => data.row_ids_filter(op, value.scalar(), dst),
             Self::Unsigned(_, data) => data.row_ids_filter(op, value.scalar(), dst),
             Self::Bool(_, data) => data.row_ids_filter(op, value.bool(), dst),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         };
 
         if row_ids.is_empty() {
@@ -471,7 +471,7 @@ impl Column {
                 data.row_ids_filter_range((&low.0, low.1.scalar()), (&high.0, high.1.scalar()), dst)
             }
             Self::Bool(_, _) => unimplemented!("filter_range not supported on boolean column"),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         };
 
         if row_ids.is_empty() {
@@ -555,7 +555,7 @@ impl Column {
                 Value::Boolean(b) => meta.might_contain_value(*b),
                 v => panic!("cannot compare boolean to {:?}", v),
             },
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -624,7 +624,7 @@ impl Column {
                     v => panic!("cannot compare on boolean column using {:?}", v),
                 }
             }
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -648,7 +648,7 @@ impl Column {
             Self::Integer(meta, _) => meta.match_no_values(op, value.scalar().as_i64()),
             Self::Unsigned(meta, _) => meta.match_no_values(op, value.scalar().as_u64()),
             Self::Bool(meta, _) => meta.match_no_values(op, value.bool()),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -666,7 +666,7 @@ impl Column {
             Self::Integer(_, data) => data.min(row_ids),
             Self::Unsigned(_, data) => data.min(row_ids),
             Self::Bool(_, data) => data.min(row_ids),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -680,7 +680,7 @@ impl Column {
             Self::Integer(_, data) => data.max(row_ids),
             Self::Unsigned(_, data) => data.max(row_ids),
             Self::Bool(_, data) => data.max(row_ids),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -710,7 +710,7 @@ impl Column {
             Self::Integer(_, data) => data.count(row_ids),
             Self::Unsigned(_, data) => data.count(row_ids),
             Self::Bool(_, data) => data.count(row_ids),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -726,7 +726,7 @@ impl Column {
             Self::Integer(_, data) => data.contains_null(),
             Self::Unsigned(_, data) => data.contains_null(),
             Self::Bool(_, data) => data.contains_null(),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -739,7 +739,7 @@ impl Column {
             Self::Integer(_, data) => data.has_non_null_value(row_ids),
             Self::Unsigned(_, data) => data.has_non_null_value(row_ids),
             Self::Bool(_, data) => data.has_non_null_value(row_ids),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 
@@ -751,7 +751,7 @@ impl Column {
             Self::Integer(_, data) => data.has_any_non_null_value(),
             Self::Unsigned(_, data) => data.has_any_non_null_value(),
             Self::Bool(_, data) => data.has_any_non_null_value(),
-            Self::ByteArray(_, _) => todo!(),
+            Self::ByteArray(_, _) => unimplemented!(),
         }
     }
 

read_buffer/src/column/encoding/scalar/rle.rs

@@ -607,19 +607,19 @@ where
     }
 
     fn count(&self, _row_ids: &[u32]) -> u32 {
-        todo!()
+        unimplemented!()
     }
 
     fn sum(&self, _row_ids: &[u32]) -> Option<L> {
-        todo!()
+        unimplemented!()
     }
 
     fn min(&self, _row_ids: &[u32]) -> Option<L> {
-        todo!()
+        unimplemented!()
     }
 
     fn max(&self, _row_ids: &[u32]) -> Option<L> {
-        todo!()
+        unimplemented!()
     }
 }
 

read_buffer/src/column/encoding/string/dictionary.rs

@@ -631,20 +631,20 @@ impl Dictionary {
     /// ids. NULL values are not considered the minimum value if any non-null
     /// value exists at any of the provided row ids.
     pub fn min<'a>(&'a self, _row_ids: &[u32]) -> Option<&'a String> {
-        todo!()
+        unimplemented!()
     }
 
     /// Returns the lexicographical maximum value for the provided set of row
     /// ids. NULL values are not considered the maximum value if any non-null
     /// value exists at any of the provided row ids.
     pub fn max<'a>(&'a self, _row_ids: &[u32]) -> Option<&'a String> {
-        todo!()
+        unimplemented!()
     }
 
     /// Returns the total number of non-null values found at the provided set of
     /// row ids.
     pub fn count(&self, _row_ids: &[u32]) -> u32 {
-        todo!()
+        unimplemented!()
     }
 
     /// Returns references to the logical (decoded) values for all the rows in
@@ -788,7 +788,7 @@ impl Dictionary {
     // Returns true if there exists an encoded non-null value at any of the row
     // ids.
     fn find_non_null_value(&self, _row_ids: &[u32]) -> bool {
-        todo!()
+        unimplemented!()
     }
 }
 

read_buffer/src/lib.rs

@@ -3,7 +3,9 @@
     clippy::clone_on_ref_ptr,
     clippy::use_self,
     clippy::str_to_string,
-    clippy::string_to_string
+    clippy::string_to_string,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(dead_code, clippy::too_many_arguments)]
 mod chunk;

read_buffer/src/row_group.rs

@@ -1031,7 +1031,7 @@ impl RowGroup {
         _group_column: ColumnName<'_>,
         _aggregates: &[(ColumnName<'_>, AggregateType)],
     ) {
-        todo!()
+        unimplemented!()
     }
 
     // Applies aggregates on multiple columns with an optional predicate.

read_buffer/src/table.rs

@@ -412,7 +412,7 @@ impl Table {
         // identify segments where time range and predicates match could match
         // using segment meta data, and then execute against those segments and
         // merge results.
-        todo!()
+        unimplemented!()
     }
 
     //
@@ -442,7 +442,7 @@ impl Table {
         //
         // Tied values (multiple equivalent min timestamps) results in an
         // arbitrary value from the result set being returned.
-        todo!();
+        unimplemented!();
     }
 
     /// The inverse of `first`. Of note here is that the returned value must
@@ -458,7 +458,7 @@ impl Table {
         //
         // Tied values (multiple equivalent min timestamps) results in an
         // arbitrary value from the result set being returned.
-        todo!();
+        unimplemented!();
     }
 
     //

router/src/lib.rs

@@ -20,6 +20,7 @@
     missing_docs,
     clippy::todo,
     clippy::dbg_macro,
+    clippy::explicit_iter_loop,
     clippy::clone_on_ref_ptr,
     clippy::future_not_send
 )]

router/src/namespace_cache/sharded_cache.rs

@@ -84,12 +84,12 @@ mod tests {
             .collect::<HashMap<_, _>>();
 
         // The cache should be empty.
-        for (name, _) in names.iter() {
+        for name in names.keys() {
             assert!(cache.get_schema(name).is_none());
         }
 
         // Populate the cache
-        for (name, id) in names.iter() {
+        for (name, id) in &names {
             let schema = schema_with_id(*id as _);
             assert!(cache.put_schema(name.clone(), schema).is_none());
         }

service_grpc_catalog/src/lib.rs

@@ -8,7 +8,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use data_types::{PartitionId, TableId};

service_grpc_object_store/src/lib.rs

@@ -9,7 +9,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use futures::{stream::BoxStream, StreamExt};

sqlx-hotswap-pool/src/lib.rs

@@ -10,7 +10,9 @@
     clippy::todo,
     clippy::dbg_macro,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 #![allow(clippy::missing_docs_in_private_items, clippy::type_complexity)]
 

test_helpers/src/lib.rs

@@ -4,7 +4,9 @@
     missing_debug_implementations,
     clippy::explicit_iter_loop,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::{

trace/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use std::{any::Any, collections::VecDeque};

trace_exporters/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 use crate::export::AsyncExporter;

trace_http/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod classify;

tracker/src/lib.rs

@@ -4,7 +4,9 @@
     clippy::explicit_iter_loop,
     clippy::use_self,
     clippy::clone_on_ref_ptr,
-    clippy::future_not_send
+    clippy::future_not_send,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 mod async_semaphore;

trogging/src/lib.rs

@@ -7,7 +7,9 @@
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,
-    clippy::clone_on_ref_ptr
+    clippy::clone_on_ref_ptr,
+    clippy::todo,
+    clippy::dbg_macro
 )]
 
 #[cfg(feature = "clap")]

write_buffer/src/kafka/mod.rs

@@ -326,7 +326,7 @@ impl WriteBufferStreamHandler for RSKafkaStreamHandler {
     async fn seek(&mut self, sequence_number: SequenceNumber) -> Result<(), WriteBufferError> {
         let offset = sequence_number.get();
         let current = self.partition_client.get_offset(OffsetAt::Latest).await?;
-        if dbg!(offset) > dbg!(current) {
+        if offset > current {
             return Err(WriteBufferError::sequence_number_after_watermark(format!(
                 "attempted to seek to offset {offset}, but current high \
                 watermark for partition {p} is {current}",

write_buffer/src/lib.rs

@@ -2,6 +2,8 @@
 #![warn(
     missing_copy_implementations,
     missing_debug_implementations,
+    clippy::todo,
+    clippy::dbg_macro,
     clippy::explicit_iter_loop,
     clippy::future_not_send,
     clippy::use_self,