From e1b57aaec4902d5ac45638d2bf6ab5d1c481b724 Mon Sep 17 00:00:00 2001 From: Edd Robinson Date: Fri, 4 Dec 2020 17:36:14 +0000 Subject: [PATCH] perf: copy as needed --- segment_store/src/segment.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/segment_store/src/segment.rs b/segment_store/src/segment.rs index 814282169d..6d7a62cd06 100644 --- a/segment_store/src/segment.rs +++ b/segment_store/src/segment.rs @@ -413,7 +413,7 @@ impl Segment { // non-empty sets. let group_keys = encoded_groups .iter() - .map(|ids| ids.keys().cloned()) + .map(|ids| ids.keys()) .multi_cartesian_product(); // Let's figure out which of the candidate group keys are actually @@ -451,7 +451,7 @@ impl Segment { // be safe to use `small_vec` here without blowing the stack up. let mut material_key = Vec::with_capacity(group_key.len()); for (col_idx, &encoded_id) in group_key.iter().enumerate() { - material_key.push(group_columns[col_idx].decode_id(encoded_id)); + material_key.push(group_columns[col_idx].decode_id(*encoded_id)); } result.group_keys.push(material_key);