fix: Move allow dead code to be more specific in compactor; remove actually dead code

compactor/src/compact.rs

@@ -13,7 +13,7 @@ use backoff::{Backoff, BackoffConfig};
 use bytes::Bytes;
 use data_types::{
     ParquetFile, ParquetFileId, ParquetFileWithMetadata, PartitionId, SequencerId, TableId,
-    TablePartition, Timestamp, Tombstone, TombstoneId,
+    Timestamp, Tombstone, TombstoneId,
 };
 use datafusion::error::DataFusionError;
 use iox_catalog::interface::{Catalog, Transaction};
@@ -286,21 +286,6 @@ impl Compactor {
             .context(Level0Snafu)
     }
 
-    async fn level_1_parquet_files(
-        &self,
-        table_partition: TablePartition,
-        min_time: Timestamp,
-        max_time: Timestamp,
-    ) -> Result<Vec<ParquetFile>> {
-        let mut repos = self.catalog.repositories().await;
-
-        repos
-            .parquet_files()
-            .level_1(table_partition, min_time, max_time)
-            .await
-            .context(Level1Snafu)
-    }
-
     async fn update_to_level_1(&self, parquet_file_ids: &[ParquetFileId]) -> Result<()> {
         let mut repos = self.catalog.repositories().await;
 

compactor/src/handler.rs

@@ -48,6 +48,7 @@ fn shared_handle(handle: JoinHandle<()>) -> SharedJoinHandle {
 #[derive(Debug)]
 pub struct CompactorHandlerImpl {
     /// Data to compact
+    #[allow(dead_code)]
     compactor_data: Arc<Compactor>,
 
     /// A token that is used to trigger shutdown of the background worker

compactor/src/lib.rs

@@ -10,7 +10,6 @@
     clippy::use_self,
     clippy::clone_on_ref_ptr
 )]
-#![allow(dead_code)]
 
 pub mod compact;
 pub mod garbage_collector;

compactor/src/utils.rs

@@ -156,6 +156,7 @@ impl CompactedData {
 /// Information needed to update the catalog after compacting a group of files
 #[derive(Debug)]
 pub struct CatalogUpdate {
+    #[allow(dead_code)]
     pub(crate) meta: IoxMetadata,
     pub(crate) tombstones: BTreeMap<TombstoneId, Tombstone>,
     pub(crate) parquet_file: ParquetFileParams,