From cf7ab909fb813365ba3544e1f4218a3e28bbe101 Mon Sep 17 00:00:00 2001 From: alexpaxton Date: Tue, 15 Jan 2019 15:56:15 -0800 Subject: [PATCH] Various Polish Stories (#11123) * Decrease space below overlay headings * Make panels contrast with background when nested in a tabbed page * Improve styling of user settings page * Improve styling of Labels and Tokens pages * Polish Bucket overlays * Link to org profile from dashboards list * Refer to actual resource type instead of "This Resource" * Link homepage card to collectors page * Update test snapshots --- .../components/overlays/Overlay.scss | 2 +- ui/src/clockface/components/panel/Panel.scss | 11 + .../components/dashboard_index/TableRow.tsx | 11 +- ui/src/me/components/GettingStarted.tsx | 34 +- ui/src/me/components/account/Settings.tsx | 30 +- ui/src/me/components/account/Tokens.tsx | 54 +- ui/src/me/components/account/TokensList.tsx | 6 +- .../__snapshots__/Settings.test.tsx.snap | 144 +-- .../__snapshots__/Tokens.test.tsx.snap | 866 +++++++++--------- .../components/BucketOverlayForm.tsx | 29 +- .../components/CreateBucketOverlay.tsx | 2 +- ui/src/organizations/components/Labels.tsx | 19 +- ui/src/organizations/components/Retention.tsx | 40 +- .../components/RetentionDuration.tsx | 8 +- .../components/UpdateBucketOverlay.tsx | 6 +- ui/src/tasks/components/TaskRow.tsx | 2 +- 16 files changed, 664 insertions(+), 600 deletions(-) diff --git a/ui/src/clockface/components/overlays/Overlay.scss b/ui/src/clockface/components/overlays/Overlay.scss index 4f9a928fc3..57520a903c 100644 --- a/ui/src/clockface/components/overlays/Overlay.scss +++ b/ui/src/clockface/components/overlays/Overlay.scss @@ -121,6 +121,6 @@ $overlay-min-height: 150px; .overlay--body { padding: $overlay-gutter; - padding-top: 18px; + padding-top: 0; min-height: $overlay-min-height; } diff --git a/ui/src/clockface/components/panel/Panel.scss b/ui/src/clockface/components/panel/Panel.scss index bc480486df..8bccdfeb00 100644 --- a/ui/src/clockface/components/panel/Panel.scss +++ b/ui/src/clockface/components/panel/Panel.scss @@ -5,6 +5,7 @@ $panel-gutter: $ix-marg-b * 2; $panel-background: $g3-castle; +$panel-nested-background: $g4-onyx; .panel { display: flex; @@ -55,3 +56,13 @@ $panel-background: $g3-castle; .panel-body hr { margin: $ix-marg-c 0; } + +// Panels Nested inside Tabbed Pages +// ---------------------------------------------------------------------------- +.tabbed-page .panel { + background-color: $panel-nested-background; + + .panel-footer { + background-color: mix($panel-nested-background, $g3-castle, 50%); + } +} diff --git a/ui/src/dashboards/components/dashboard_index/TableRow.tsx b/ui/src/dashboards/components/dashboard_index/TableRow.tsx index 7a871c713d..1216c7c2ad 100644 --- a/ui/src/dashboards/components/dashboard_index/TableRow.tsx +++ b/ui/src/dashboards/components/dashboard_index/TableRow.tsx @@ -98,6 +98,7 @@ export default class DashboardsIndexTableRow extends PureComponent { limitChildCount={4} className="index-list--labels" onEdit={this.handleEditLabels} + resourceName="this Dashboard" /> ) } @@ -107,6 +108,7 @@ export default class DashboardsIndexTableRow extends PureComponent { limitChildCount={4} className="index-list--labels" onEdit={this.handleEditLabels} + resourceName="this Dashboard" > {dashboard.labels.map(label => (