adding pr checklist
parent
2507540c27
commit
cd76a5a416
|
@ -54,6 +54,15 @@ To submit a pull request you should fork the InfluxDB repository, and make your
|
|||
|
||||
There will usually be some back and forth as we finalize the change, but once that completes it may be merged.
|
||||
|
||||
To assist in review for the PR, please add the following to your pull request comment:
|
||||
|
||||
```md
|
||||
- [ ] CHANGELOG.md updated
|
||||
- [ ] Rebased/mergable
|
||||
- [ ] Tests pass
|
||||
- [ ] Sign [CLA](http://influxdb.com/community/cla.html) (if not already signed)
|
||||
```
|
||||
|
||||
Use of third-party packages
|
||||
------------
|
||||
A third-party package is defined as one that is not part of the standard Go distribution. Generally speaking we prefer to minimize our use of third-party packages, and avoid them unless absolutely necessarly. We'll often write a little bit of code rather than pull in a third-party package. Of course, we do use some third-party packages -- most importantly we use [BoltDB](https://github.com/boltdb/bolt) as the storage engine. So to maximise the chance your change will be accepted by us, use only the standard libaries, or the third-party packages we have decided to use.
|
||||
|
|
Loading…
Reference in New Issue