Prevent multiple dropdown menus from rendering

pull/10616/head
Alex P 2017-05-23 12:10:50 -07:00
parent f706c58215
commit ca57416a57
1 changed files with 13 additions and 3 deletions

View File

@ -281,6 +281,7 @@ class Dropdown extends Component {
items,
selected,
className,
menuClass,
iconName,
buttonSize,
buttonColor,
@ -318,14 +319,23 @@ class Dropdown extends Component {
<span className="dropdown-selected">{selected}</span>
<span className="caret" />
</div>}
{isOpen && menuItems.length < DROPDOWN_MENU_ITEM_THRESHOLD
{isOpen &&
menuItems.length &&
menuItems.length < DROPDOWN_MENU_ITEM_THRESHOLD
? this.renderShortMenu()
: null}
{isOpen && menuItems.length >= DROPDOWN_MENU_ITEM_THRESHOLD
{isOpen &&
menuItems.length &&
menuItems.length >= DROPDOWN_MENU_ITEM_THRESHOLD
? this.renderLongMenu()
: null}
{isOpen && !menuItems.length
? <ul className="dropdown-menu">
? <ul
className={classnames('dropdown-menu', {
'dropdown-menu--no-highlight': useAutoComplete,
[menuClass]: menuClass,
})}
>
<li className="dropdown-empty">No matching items</li>
</ul>
: null}