Influxdata
/
influxdb
mirror of https://github.com/influxdata/influxdb.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: apply namespace name validation on create 

Prior to this commit, the gRPC NamespaceService would allow namespaces
to be created with invalid names due to a missing call to NamespaceName
that performs validation.
pull/24376/head
Dom Dwyer 2023-04-18 14:50:51 +02:00
parent 54d4ca8729
commit c4a802cea8
No known key found for this signature in database
GPG Key ID: E4C40DBD9157879A
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
service_grpc_namespace/src/lib.rs
View File

@ -1,7 +1,7 @@
//! Implementation of the namespace gRPC service
use std::sync::Arc;
use data_types::{Namespace as CatalogNamespace, QueryPoolId, TopicId};
use data_types::{Namespace as CatalogNamespace, NamespaceName, QueryPoolId, TopicId};
use generated_types::influxdata::iox::namespace::v1::{
update_namespace_service_protection_limit_request::LimitUpdate, *,
};
@ -69,6 +69,11 @@ impl namespace_service_server::NamespaceService for NamespaceService {
retention_period_ns,
} = request.into_inner();
// Ensure the namespace name is consistently processed within IOx - this
// is handled by the NamespaceName type.
let namespace_name = NamespaceName::try_from(namespace_name)
.map_err(|v| Status::invalid_argument(v.to_string()))?;
let retention_period_ns = map_retention_period(retention_period_ns)?;
debug!(%namespace_name, ?retention_period_ns, "Creating namespace");
@ -88,7 +93,7 @@ impl namespace_service_server::NamespaceService for NamespaceService {
})?;
info!(
namespace_name,
%namespace_name,
namespace_id = %namespace.id,
"created namespace"
);